From: Matthew Wilcox <matthew@wil.cx>
To: Grant Grundler <grundler@cup.hp.com>
Cc: Matthieu Delahaye <delahaym@esiee.fr>, parisc-linux@thepuffingroup.com
Subject: Re: [parisc-linux] Unregister driver patch
Date: Mon, 26 Feb 2001 16:38:33 +0000 [thread overview]
Message-ID: <20010226163833.C22753@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <200102260431.UAA23094@milano.cup.hp.com>; from grundler@cup.hp.com on Sun, Feb 25, 2001 at 08:30:55PM -0800
On Sun, Feb 25, 2001 at 08:30:55PM -0800, Grant Grundler wrote:
> > - if (device->managed) continue;
> > + if ((int)device->driver) continue;
>
> I'll change this to:
> if (NULL != device->driver) continue;
we definitely don't want to cast this to an int. But what's wrong with
if (device->driver)
continue;
it reads properly `if device has driver then continue'. Sure, it's complex
to think about if you try and puzzle it out `so, if i've assigned a value to
driver then it's not 0, so this is true in which case continue', but if you
just read it, it says what it means.
--
Revolutions do not require corporate support.
next prev parent reply other threads:[~2001-02-26 17:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-24 15:56 [parisc-linux] Unregister driver patch Matthieu Delahaye
2001-02-25 6:16 ` Grant Grundler
2001-02-25 11:02 ` Matthieu Delahaye
2001-02-26 4:30 ` Grant Grundler
2001-02-26 16:38 ` Matthew Wilcox [this message]
2001-02-26 5:30 ` Grant Grundler
2001-02-26 10:00 ` Matthieu Delahaye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010226163833.C22753@parcelfarce.linux.theplanet.co.uk \
--to=matthew@wil.cx \
--cc=delahaym@esiee.fr \
--cc=grundler@cup.hp.com \
--cc=parisc-linux@thepuffingroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox