* [parisc-linux] Re: [parisc-linux-cvs] DIFF 2.4.20-rc1-pa7
[not found] ` <20021122182325.52708482B@dsl2.external.hp.com>
@ 2002-11-22 20:01 ` Matthew Wilcox
2002-11-22 21:37 ` Grant Grundler
0 siblings, 1 reply; 2+ messages in thread
From: Matthew Wilcox @ 2002-11-22 20:01 UTC (permalink / raw)
To: Grant Grundler; +Cc: parisc-linux
On Fri, Nov 22, 2002 at 11:23:25AM -0700, Grant Grundler wrote:
> Index: drivers/net/ppp_generic.c
> ===================================================================
> RCS file: /var/cvs/linux/drivers/net/ppp_generic.c,v
> retrieving revision 1.14
> diff -u -p -r1.14 ppp_generic.c
> --- drivers/net/ppp_generic.c 13 Nov 2002 16:57:46 -0000 1.14
> +++ drivers/net/ppp_generic.c 22 Nov 2002 05:53:55 -0000
> @@ -387,9 +387,9 @@ static ssize_t ppp_read(struct file *fil
> for (;;) {
> set_current_state(TASK_INTERRUPTIBLE);
> skb = skb_dequeue(&pf->rq);
> + ret = 0;
> if (skb)
> break;
> - ret = 0;
> if (pf->dead)
> break;
> ret = -EAGAIN;
Uhh.. why have you made this change? It's clearly wrong and diverges
from upstream.
--
Revolutions do not require corporate support.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [parisc-linux] Re: [parisc-linux-cvs] DIFF 2.4.20-rc1-pa7
2002-11-22 20:01 ` [parisc-linux] Re: [parisc-linux-cvs] DIFF 2.4.20-rc1-pa7 Matthew Wilcox
@ 2002-11-22 21:37 ` Grant Grundler
0 siblings, 0 replies; 2+ messages in thread
From: Grant Grundler @ 2002-11-22 21:37 UTC (permalink / raw)
To: Matthew Wilcox; +Cc: parisc-linux
Matthew Wilcox wrote:
> Uhh.. why have you made this change? It's clearly wrong and diverges
> from upstream.
reverted - I didn't see upstream had fixed it differently.
sorry,
grant
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-11-22 21:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20021122055423.B892D482B@dsl2.external.hp.com>
[not found] ` <20021122182325.52708482B@dsl2.external.hp.com>
2002-11-22 20:01 ` [parisc-linux] Re: [parisc-linux-cvs] DIFF 2.4.20-rc1-pa7 Matthew Wilcox
2002-11-22 21:37 ` Grant Grundler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox