[parisc-linux] Typo?

[parisc-linux] Typo?

[jsoe0708]

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

Here attached some diff which seems to be typo.

Joel

********************************************************************************
Controlez mieux votre consommation Internet...surfez Tiscali Complete...http://tiscali.complete.be




[-- Attachment #2: Typo-sba_iommu.c.diff --]
[-- Type: application/octet-stream, Size: 581 bytes --]

diff -NaurX dontdiff linux-2.4.20-pa8t/arch/parisc/kernel/sba_iommu.c linux-2.4.20-pa9/arch/parisc/kernel/sba_iommu.c
--- linux-2.4.20-pa8t/arch/parisc/kernel/sba_iommu.c	2002-11-26 15:52:15.000000000 +0100
+++ linux-2.4.20-pa9/arch/parisc/kernel/sba_iommu.c	2002-11-18 09:07:18.000000000 +0100
@@ -1056,7 +1056,7 @@
 			printk(KERN_DEBUG " %2d : %08lx/%05x %p/%05x\n",
 				nents,
 				(unsigned long) sg_dma_address(startsg), cnt,
-				sg_virt_addr(startsg), startsg->length
+				sg_virt_address(startsg), startsg->length
 		);
 #else
 		DBG_RUN_SG(" %d : %08lx/%05x %p/%05x\n",

Re: [parisc-linux] Typo?

[Matthew Wilcox]

On Fri, Nov 29, 2002 at 10:57:50AM +0100, jsoe0708@tiscali.be wrote:
> Here attached some diff which seems to be typo.

patch looks correct to me.  grant?



-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk

Re: [parisc-linux] Typo?

[Grant Grundler]

Matthew Wilcox wrote:
> On Fri, Nov 29, 2002 at 10:57:50AM +0100, jsoe0708@tiscali.be wrote:
> > Here attached some diff which seems to be typo.
> 
> patch looks correct to me.  grant?

yup - a typo in the debug code. I'll commit Joels patch shortly.

thanks!
grant

Re: [parisc-linux] Typo?

[Grant Grundler]

Matthew Wilcox wrote:
> On Fri, Nov 29, 2002 at 10:57:50AM +0100, jsoe0708@tiscali.be wrote:
> > Here attached some diff which seems to be typo.
> 
> patch looks correct to me.  grant?

I was off on holiday...I guess I didn't advertise that well enough.

I just committed Joel's patch and just now realized it's *WRONG*.
I don't know why I thought sg_virt_address() was correct before.
Brain fart.

grundler <520>fgrep sg_virt include/asm-parisc/scatterlist.h 
#define sg_virt_addr(sg) (((sg)->address) ? ((sg)->address) : \

I'll fix my mess. *sigh*.
BTW, I'll fix pci-dma.c too. I've got the B180 to test it on tomorrow.

thanks!
grant