[parisc-linux] second sr0 patch

[parisc-linux] second sr0 patch

[Matthew Wilcox]

forgot to cc p-l on this one.  sorry.

----- Forwarded message from Matthew Wilcox <willy@wil.cx> -----

Index: gas/ChangeLog
===================================================================
RCS file: /cvs/src/src/gas/ChangeLog,v
retrieving revision 1.1677
diff -u -p -r1.1677 ChangeLog
--- gas/ChangeLog	21 Feb 2003 19:05:01 -0000	1.1677
+++ gas/ChangeLog	23 Feb 2003 19:21:05 -0000
@@ -1,3 +1,8 @@
+2003-02-23  Matthew Wilcox  <willy@debian.org>
+
+	* config/tc-hppa.c: Do not accept sr0 as a valid space register when
+	  constructing an instruction with a 2-bit s field.
+
 2003-02-21  Nick Clifton  <nickc@redhat.com>
 
 	* NEWS: Mention availability of test generator program.
Index: gas/config/tc-hppa.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-hppa.c,v
retrieving revision 1.102
diff -u -p -r1.102 tc-hppa.c
--- gas/config/tc-hppa.c	23 Jan 2003 12:51:04 -0000	1.102
+++ gas/config/tc-hppa.c	23 Feb 2003 19:21:09 -0000
@@ -1794,7 +1794,7 @@ pa_ip (str)
 	      if (!pa_parse_number (&s, 0))
 		break;
 	      num = pa_number;
-	      CHECK_FIELD (num, 3, 0, 1);
+	      CHECK_FIELD (num, 3, 1, 1);
 	      INSERT_FIELD_AND_CONTINUE (opcode, num, 14);
 
 	    /* Handle a 3 bit space identifier at 18.  */

----- End forwarded message -----

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk

Re: [parisc-linux] second sr0 patch

[LaMont Jones]

In article <20030223204842.E2938@parcelfarce.linux.theplanet.co.uk> you wrote:

> --- gas/config/tc-hppa.c	23 Jan 2003 12:51:04 -0000	1.102
> +++ gas/config/tc-hppa.c	23 Feb 2003 19:21:09 -0000
> @@ -1794,7 +1794,7 @@ pa_ip (str)
>  	      if (!pa_parse_number (&s, 0))
>  		break;
>  	      num = pa_number;
> -	      CHECK_FIELD (num, 3, 0, 1);
> +	      CHECK_FIELD (num, 3, 1, 1);
>  	      INSERT_FIELD_AND_CONTINUE (opcode, num, 14);
>  
>  	    /* Handle a 3 bit space identifier at 18.  */

I don't think this is a good plan.  Emit a warning, sure, but there is
a large collection of legacy PARISC assembly code out there that has
this perfectly legal, and hp-ux assembler-accepted-from-day-0 construct.

lamont

Re: [parisc-linux] second sr0 patch

[LaMont Jones]

In article <20030223204842.E2938@parcelfarce.linux.theplanet.co.uk> you wrote:

> --- gas/config/tc-hppa.c	23 Jan 2003 12:51:04 -0000	1.102
> +++ gas/config/tc-hppa.c	23 Feb 2003 19:21:09 -0000
> @@ -1794,7 +1794,7 @@ pa_ip (str)
>  	      if (!pa_parse_number (&s, 0))
>  		break;
>  	      num = pa_number;
> -	      CHECK_FIELD (num, 3, 0, 1);
> +	      CHECK_FIELD (num, 3, 1, 1);
>  	      INSERT_FIELD_AND_CONTINUE (opcode, num, 14);
>  
>  	    /* Handle a 3 bit space identifier at 18.  */

I don't think this is a good plan.  Emit a warning, sure, but there is
a large collection of legacy PARISC assembly code out there that has
this perfectly legal, and hp-ux assembler-accepted-from-day-0 construct.

lamont

Re: [parisc-linux] second sr0 patch

[Matthew Wilcox]

On Sun, Feb 23, 2003 at 03:20:35PM -0700, LaMont Jones wrote:
> In article <20030223204842.E2938@parcelfarce.linux.theplanet.co.uk> you wrote:
> > +++ gas/config/tc-hppa.c	23 Feb 2003 19:21:09 -0000
> > @@ -1794,7 +1794,7 @@ pa_ip (str)
> >  	      if (!pa_parse_number (&s, 0))
> >  		break;
> >  	      num = pa_number;
> > -	      CHECK_FIELD (num, 3, 0, 1);
> > +	      CHECK_FIELD (num, 3, 1, 1);

> I don't think this is a good plan.  Emit a warning, sure, but there is
> a large collection of legacy PARISC assembly code out there that has
> this perfectly legal, and hp-ux assembler-accepted-from-day-0 construct.

OK, patch withdrawn.  It's misleading to use this construct, but if people
have been doing it for fifteen years then it's just not reasonable to
not support it now.

The other patch still stands; we're not using sr0 so it's misleading to
pretend that we are.

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk

Re: [parisc-linux] second sr0 patch

[Matthew Wilcox]

On Sun, Feb 23, 2003 at 03:20:35PM -0700, LaMont Jones wrote:
> In article <20030223204842.E2938@parcelfarce.linux.theplanet.co.uk> you wrote:
> > +++ gas/config/tc-hppa.c	23 Feb 2003 19:21:09 -0000
> > @@ -1794,7 +1794,7 @@ pa_ip (str)
> >  	      if (!pa_parse_number (&s, 0))
> >  		break;
> >  	      num = pa_number;
> > -	      CHECK_FIELD (num, 3, 0, 1);
> > +	      CHECK_FIELD (num, 3, 1, 1);

> I don't think this is a good plan.  Emit a warning, sure, but there is
> a large collection of legacy PARISC assembly code out there that has
> this perfectly legal, and hp-ux assembler-accepted-from-day-0 construct.

OK, patch withdrawn.  It's misleading to use this construct, but if people
have been doing it for fifteen years then it's just not reasonable to
not support it now.

The other patch still stands; we're not using sr0 so it's misleading to
pretend that we are.

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk