Linux PARISC architecture development
 help / color / mirror / Atom feed
From: Grant Grundler <grundler@parisc-linux.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: parisc-linux@lists.parisc-linux.org, "M. Grabert" <xam@cs.ucc.ie>
Subject: Re: [parisc-linux] C3000 and Promise Ultra100 TX2 PCI Controller
Date: Fri, 27 Feb 2004 14:23:56 -0700	[thread overview]
Message-ID: <20040227212356.GA28668@colo.lackof.org> (raw)
In-Reply-To: <1077907459.29711.13.camel@dhcp23.swansea.linux.org.uk>

On Fri, Feb 27, 2004 at 06:44:20PM +0000, Alan Cox wrote:
> On Iau, 2004-02-26 at 15:56, Grant Grundler wrote:
> > yes - the endian issue is probably harder to fix.
> 
> All mmio and pio goes through helper functions, so it suggests the
> helper ifdefs are simply wrong in ide-iops.c - which should make fixing
> stuff easier - probably the insw() op is the problem.

Correct. parisc insw/insl/outsw/outsl are all broken.
They all have cpu_to_leXX (or leXX_to_cpu()) calls and the
basic inw/outw are already taking care of the byte swap.
This has been mostly my fault since I originally didn't
know how the byte swapping was supposed to be
handled for a big endian arch.

Anyone interested in deleted all use of the cpu_to_leXX
and leXX_to_cpu in linux-2.6/arch/parisc/lib/io.c?

please post the tested patch here. I'll review and assign
bla^H^H^Hglory to the submitter when I commit it.

BTW, linux-2.4 has the same issue.
I expect the same patch will apply to both if it's
easier to test with linux-2.4.

thanks,
grant

  reply	other threads:[~2004-02-27 21:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-26  0:52 [parisc-linux] C3000 and Promise Ultra100 TX2 PCI Controller M. Grabert
2004-02-26  1:08 ` Alan Cox
2004-02-26  1:59   ` M. Grabert
     [not found]     ` <20040226051124.GB3645@colo.lackof.org>
     [not found]       ` <Pine.LNX.4.58.0402260513010.28003@sal.ucc.ie>
2004-02-26 15:56         ` Grant Grundler
2004-02-27 18:44           ` Alan Cox
2004-02-27 21:23             ` Grant Grundler [this message]
2004-02-27 23:50               ` M. Grabert
2004-02-28  1:05                 ` M. Grabert
2004-02-28 16:07                   ` Alan Cox
2004-02-28 16:45                     ` Grant Grundler
2004-02-28 17:24                       ` James Bottomley
2004-02-28 17:41                       ` Matthew Wilcox
2004-02-28 19:48                         ` Grant Grundler
2004-02-28  1:53                 ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040227212356.GA28668@colo.lackof.org \
    --to=grundler@parisc-linux.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=parisc-linux@lists.parisc-linux.org \
    --cc=xam@cs.ucc.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox