* [parisc-linux] Re: [PATCH] parisc: remove copat_ioctl entires for pp
[not found] <20051112095213.GA15918@lst.de>
@ 2005-11-12 13:33 ` Matthew Wilcox
0 siblings, 0 replies; only message in thread
From: Matthew Wilcox @ 2005-11-12 13:33 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: akpm, netdev, parisc-linux
On Sat, Nov 12, 2005 at 10:52:13AM +0100, Christoph Hellwig wrote:
> ppp ioctls handlers in parisc are wrong:
>
> - they would need to do a copat_ptr on ifr->ifr_ifru.ifru_data
> - SIOCGPPP* ioctls are defines as SIOCDEVPRIVATE + n, so they'd
> kick in for all private ioctls which is defintely wrong.
>
> to implement proper ppp compat_ioctl handlig we'd need a compat_ioctl
> method in struct net_device, which we don't have yet.
While I agree that this is theoretically wrong, the problem is that if
we remove them, people using ppp on 64-bit PA machines will no longer be
able to do so. And yes, there are some, that's why these got added in
the first place.
Perhaps I'll look into the compat_ioctl route later. In any case, I
would prefer this patch not be added for the moment.
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux
^ permalink raw reply [flat|nested] only message in thread