[parisc-linux] a small hunk to cleanup 2 build warning?

[parisc-linux] a small hunk to cleanup 2 build warning?

[Joel Soete]

Hi pa*,

those 2 warning crossed my look during the build of n4k (64bit) smp kerne=
l (in
a loop to stress it a bit):
  CC      kernel/compat.o
/usr/src/linux-2.6.16-pa4/kernel/compat.c: In function 'compat_sys_timer_=
create':
/usr/src/linux-2.6.16-pa4/kernel/compat.c:531: warning: implicit declarat=
ion
of function 'get_compat_sigevent'
[...]
  CC      ipc/compat_mq.o
/usr/src/linux-2.6.16-pa4/ipc/compat_mq.c: In function 'compat_sys_mq_not=
ify':
/usr/src/linux-2.6.16-pa4/ipc/compat_mq.c:113: warning: implicit declarat=
ion
of function 'get_compat_sigevent'
[...]

imho this simple hunk could be helpfull:
--- ./include/linux/compat_siginfo.h.Orig       2006-03-24 14:04:10.00000=
0000
+0100
+++ ./include/linux/compat_siginfo.h    2006-03-24 14:24:49.000000000 +01=
00
@@ -171,6 +171,9 @@
 
 #endif /* !HAVE_ARCH_COMPAT_COPY_SIGINFO */
 
+extern int get_compat_sigevent(struct sigevent *event,
+                       const struct compat_sigevent __user *u_event);
+
 extern int compat_copy_siginfo_to_user(compat_siginfo_t __user *to, stru=
ct
siginfo *from);
 extern int compat_copy_siginfo_from_user(struct siginfo *to, compat_sigi=
nfo_t
__user *from);
 
=3D=3D=3D=3D<>=3D=3D=3D=3D

If Ok can you ci?

TIA,
    Joel=0A=0A-------------------------------------------------------=0AN=
OTE! My email address is changing to ... @scarlet.be=0APlease make the ne=
cessary changes in your address book. =0A=0A

_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

Re: [parisc-linux] a small hunk to cleanup 2 build warning?

[Helge Deller]

Hello Joel,

thank you for the patch.
I just looked how it is fixed currently in Linus' (>2.6.16) tree, and there this was added to include/linux/compat.h.
Since I don't think we will push the changes you propose to 2.6.16 in the file compat_siginfo.h upstream (since it has been fixed differently), I think it's easier to just stick with this small warning at the moment.
If others here think differently just go ahead...

Regards,
Helge

On Friday 24 March 2006 15:41, Joel Soete wrote:
> Hi pa*,
> 
> those 2 warning crossed my look during the build of n4k (64bit) smp kernel (in
> a loop to stress it a bit):
>   CC      kernel/compat.o
> /usr/src/linux-2.6.16-pa4/kernel/compat.c: In function 'compat_sys_timer_create':
> /usr/src/linux-2.6.16-pa4/kernel/compat.c:531: warning: implicit declaration
> of function 'get_compat_sigevent'
> [...]
>   CC      ipc/compat_mq.o
> /usr/src/linux-2.6.16-pa4/ipc/compat_mq.c: In function 'compat_sys_mq_notify':
> /usr/src/linux-2.6.16-pa4/ipc/compat_mq.c:113: warning: implicit declaration
> of function 'get_compat_sigevent'
> [...]
> 
> imho this simple hunk could be helpfull:
> --- ./include/linux/compat_siginfo.h.Orig       2006-03-24 14:04:10.000000000
> +0100
> +++ ./include/linux/compat_siginfo.h    2006-03-24 14:24:49.000000000 +0100
> @@ -171,6 +171,9 @@
>  
>  #endif /* !HAVE_ARCH_COMPAT_COPY_SIGINFO */
>  
> +extern int get_compat_sigevent(struct sigevent *event,
> +                       const struct compat_sigevent __user *u_event);
> +
>  extern int compat_copy_siginfo_to_user(compat_siginfo_t __user *to, struct
> siginfo *from);
>  extern int compat_copy_siginfo_from_user(struct siginfo *to, compat_siginfo_t
> __user *from);
>  
> ====<>====
> 
> If Ok can you ci?
> 
> TIA,
>     Joel
> 
> -------------------------------------------------------
> NOTE! My email address is changing to ... @scarlet.be
> Please make the necessary changes in your address book. 
> 
> 
> 
> _______________________________________________
> parisc-linux mailing list
> parisc-linux@lists.parisc-linux.org
> http://lists.parisc-linux.org/mailman/listinfo/parisc-linux
> 
> 
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

Re: [parisc-linux] a small hunk to cleanup 2 build warning?

[Grant Grundler]

On Fri, Mar 24, 2006 at 05:58:27PM +0100, Helge Deller wrote:
> Since I don't think we will push the changes you propose to 2.6.16 in
> the file compat_siginfo.h upstream (since it has been fixed differently),
> I think it's easier to just stick with this small warning at the moment.
> If others here think differently just go ahead...

I agree. If it's already fixed upstream, I can live with the warning for now.

thanks,
grant

Re: [parisc-linux] a small hunk to cleanup 2 build warning?

[Joel Soete]

> On Fri, Mar 24, 2006 at 05:58:27PM +0100, Helge Deller wrote:
> > Since I don't think we will push the changes you propose to 2.6.16 in=

> > the file compat_siginfo.h upstream (since it has been fixed different=
ly),
Ah interesting, I try it first in compat.h but complaining about 'struct
compat_sigevent' not define, that will may be learn me more about C ;-)
 
> > I think it's easier to just stick with this small warning at the mome=
nt.
> > If others here think differently just go ahead...
> 
> I agree. If it's already fixed upstream, I can live with the warning fo=
r now.
> 
Oh yes, just a suggestion in case that gcc could confuse stuff and may be=

related to 'Bug' encountered recently. 

Tx a lot for feedback,
    Joel=0A=0A-------------------------------------------------------=0AN=
OTE! My email address is changing to ... @scarlet.be=0APlease make the ne=
cessary changes in your address book. =0A=0A