Linux PARISC architecture development
 help / color / mirror / Atom feed
* [parisc-linux] K410 SCSI 53c700 issue with PLEXTOR PX-R820T
@ 2006-11-12 15:03 Guy Martin
  2006-11-12 19:14 ` Matthew Wilcox
  0 siblings, 1 reply; 15+ messages in thread
From: Guy Martin @ 2006-11-12 15:03 UTC (permalink / raw)
  To: parisc-linux


Hi all,


I'm experiencing an issue with the LASI 53c700 SCSI driver. It looks similar to the problem found by Joel earlier :
http://lists.parisc-linux.org/pipermail/parisc-linux/2006-July/029506.html
http://lists.parisc-linux.org/pipermail/parisc-linux/2006-September/030202.html

My plextor cd burner works fine on an x86 and on that K410 with HP-UX or linux 2.4.

This is how 2.4 detects it :
scsi3: (4:0) Synchronous at offset 8, period 100ns
  Vendor: PLEXTOR   Model: CD-R   PX-R820T   Rev: 1.08
  Type:   CD-ROM                             ANSI SCSI revision: 02

And this is how 2.6 detects it :
[42949430.090000]   Vendor: PLEXTOR   Model: CD-R   PX-R820T   Rev: 1.08
[42949430.150000]   Type:   CD-ROM                             ANSI SCSI revision: 02
[42949430.170000]  target2:0:4: Beginning Domain Validation
[42949430.180000]  target2:0:4: asynchronous
[42949430.190000]  target2:0:4: FAST-10 SCSI 10.0 MB/s ST (100 ns, offset 8)
[42949430.200000]  target2:0:4: Domain Validation skipping write tests
[42949430.210000]  target2:0:4: Ending Domain Validation


The main difference seems that 2.4 detects and syncronous drive while 2.6 detects an async one.

Full 2.4 dmesg : https://www.tuxicoman.be/temp/dmesg-2.4-53c700
Full 2.6 dmesg : https://www.tuxicoman.be/temp/dmesg-2.6-53c700
2.6 kernel config : https://www.tuxicoman.be/temp/k410-2.6.18.2-pa0.config

On my 2.6 kernel, when you try to mount it, you get the those error messages in loop.

[  297.870000] scsi2: (4:0) phase mismatch at 01e8, phase IO BSY DATA_IN
[  297.870000] scsi2: Bus Reset detected, executing command 4f7bb840, slot 4ff50520, dsp 001c01e8[01e8]
[  297.870000]  failing command because of reset, slot 4ff50520, cmnd 4f7bb840
[  327.880000] sr 2:0:4:0: New error handler wants to abort command
[  327.880000] 	sr 2:0:4:0: 
[  327.880000]         command: cdb[0]=0x0: 00 00 00 00 00 00
[  327.880000] scsi2: Bus Reset detected, executing command 4f7bb840, slot 4ff50520, dsp 001c0010[0010]
[  327.880000]  failing command because of reset, slot 4ff50520, cmnd 4f7bb840
[  327.890000] sr 2:0:4:0: New error handler wants BUS reset, cmd 4f7bb840
[  327.890000] 	sr 2:0:4:0: 
[  327.890000]         command: cdb[0]=0x0: 00 00 00 00 00 00
[  327.890000] scsi2: Bus Reset detected, executing command 00000000, slot 00000000, dsp 001c0010[0010]


As you can see in the dmesg, I have another CDROM drive on the same SCSI bus and this one works like a charm.



Please have a look at it and let me know if you need any other info.

Thanks,
  Guy
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [parisc-linux] K410 SCSI 53c700 issue with PLEXTOR PX-R820T
  2006-11-12 15:03 [parisc-linux] K410 SCSI 53c700 issue with PLEXTOR PX-R820T Guy Martin
@ 2006-11-12 19:14 ` Matthew Wilcox
  2006-11-15 23:49   ` Guy Martin
  2006-11-27 10:58   ` Guy Martin
  0 siblings, 2 replies; 15+ messages in thread
From: Matthew Wilcox @ 2006-11-12 19:14 UTC (permalink / raw)
  To: Guy Martin; +Cc: parisc-linux

On Sun, Nov 12, 2006 at 04:03:50PM +0100, Guy Martin wrote:
> This is how 2.4 detects it :
> scsi3: (4:0) Synchronous at offset 8, period 100ns
>   Vendor: PLEXTOR   Model: CD-R   PX-R820T   Rev: 1.08
>   Type:   CD-ROM                             ANSI SCSI revision: 02
> 
> And this is how 2.6 detects it :
> [42949430.090000]   Vendor: PLEXTOR   Model: CD-R   PX-R820T   Rev: 1.08
> [42949430.150000]   Type:   CD-ROM                             ANSI SCSI revision: 02
> [42949430.170000]  target2:0:4: Beginning Domain Validation
> [42949430.180000]  target2:0:4: asynchronous
> [42949430.190000]  target2:0:4: FAST-10 SCSI 10.0 MB/s ST (100 ns, offset 8)
> [42949430.200000]  target2:0:4: Domain Validation skipping write tests
> [42949430.210000]  target2:0:4: Ending Domain Validation
> 
> 
> The main difference seems that 2.4 detects and syncronous drive while 2.6 detects an async one.

Um, you're just confused by the debug output from the DV code.  First it
negotiates async, then it negotiates FAST-10.

> Full 2.4 dmesg : https://www.tuxicoman.be/temp/dmesg-2.4-53c700
> Full 2.6 dmesg : https://www.tuxicoman.be/temp/dmesg-2.6-53c700
> 2.6 kernel config : https://www.tuxicoman.be/temp/k410-2.6.18.2-pa0.config
> 
> On my 2.6 kernel, when you try to mount it, you get the those error messages in loop.
> 
> Please have a look at it and let me know if you need any other info.

Presumably at some point in 2.6, this device worked fine.  Any chance
you could bisect and figure out when it started failing?  I'd start with
looking at something in the 2.6.8 sort of timeframe.
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [parisc-linux] K410 SCSI 53c700 issue with PLEXTOR PX-R820T
  2006-11-12 19:14 ` Matthew Wilcox
@ 2006-11-15 23:49   ` Guy Martin
  2006-11-27 10:58   ` Guy Martin
  1 sibling, 0 replies; 15+ messages in thread
From: Guy Martin @ 2006-11-15 23:49 UTC (permalink / raw)
  To: Matthew Wilcox; +Cc: parisc-linux

On Sun, 12 Nov 2006 12:14:37 -0700
Matthew Wilcox <matthew@wil.cx> wrote:

> > Please have a look at it and let me know if you need any other info.
> 
> Presumably at some point in 2.6, this device worked fine.  Any chance
> you could bisect and figure out when it started failing?  I'd start with
> looking at something in the 2.6.8 sort of timeframe.


I've tried from kernels since 2.6.8 and it looks like it breaks since 2.6.18.

The dmesg of the last working kernel is here :
https://www.tuxicoman.be/temp/dmesg-2.6.17-53c700

The dmesg of the non working one is here :
https://www.tuxicoman.be/temp/dmesg-2.6-53c700


According 2.6.18's changelog, it looks like a few fixes were merged in this release.

As usual, if you need any other info or even access to this box, let me know.

Cheers,
  Guy
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [parisc-linux] K410 SCSI 53c700 issue with PLEXTOR PX-R820T
  2006-11-12 19:14 ` Matthew Wilcox
  2006-11-15 23:49   ` Guy Martin
@ 2006-11-27 10:58   ` Guy Martin
  2006-11-27 15:37     ` Matthew Wilcox
  1 sibling, 1 reply; 15+ messages in thread
From: Guy Martin @ 2006-11-27 10:58 UTC (permalink / raw)
  To: Matthew Wilcox; +Cc: parisc-linux


Hi Matthew,

Some more detail on this issue.
This burner still works at commit 6391a11375de5e2bb1eb8481e54619761dc65d9f but breaks at commit 0f13fc09db68de92585558984bff1c51b87db72f.

There are one or two commits in between those two but the scsi driver doesn't work at all.

For reference, this is the log for those changes :

commit 0f13fc09db68de92585558984bff1c51b87db72f
Author: James Bottomley <James.Bottomley@steeleye.com>
Date:   Thu Jun 29 13:02:11 2006 -0400

    [SCSI] 53c700: fix breakage caused by the autosense update
    
    A bit of a brown paper bag issue.  The previous patch to remove the soon
    to be ripped out fields that were used in autosense actually broke the
    driver.  This patch fixes it and has been tested (honestly).
    
    Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>

commit 4311fa60b0d1cb5a2f62f646978294bca7b46cbb
Author: Dave Jones <davej@redhat.com>
Date:   Thu Jun 22 15:46:15 2006 -0400

    [SCSI] kmalloc argument switcheroo in recent 53c700 change.
    
    On Wed, Jun 21, 2006 at 07:00:34PM +0000, Linux Kernel wrote:
     > commit 67d59dfdeb21df2c16dcd478b66177e91178ecd0
     > tree ae85703651d81740f4a6cd398f9dd4d6aabe6a2f
     > parent 6db874fbdbedba5e15e76cc03b42f52ea70338c0
     > author James Bottomley <James.Bottomley@steeleye.com> Wed, 14 Jun 2006 07:31:19 -0500
     > committer James Bottomley <jejb@mulgrave.il.steeleye.com> Tue, 20 Jun 2006 05:34:01 -0500
     >
     > [SCSI] 53c700: remove reliance on deprecated cmnd fields
     >  ...
     >
     > +        SDp->hostdata = kmalloc(GFP_KERNEL, sizeof(struct NCR_700_sense));
     > +
     > +        if (!SDp->hostdata)
     > +                return -ENOMEM;
    
    "I'll take reversed arguments for $100 please Alex".
    
    Signed-off-by: Dave Jones <davej@redhat.com>
    Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>

commit 67d59dfdeb21df2c16dcd478b66177e91178ecd0
Author: James Bottomley <James.Bottomley@steeleye.com>
Date:   Tue Jun 13 21:31:19 2006 -0500

    [SCSI] 53c700: remove reliance on deprecated cmnd fields
    
    This one's quite tricky.  The 53c700 uses the now deprecated fields of
    the command structure for saving the prior command when it does
    autosense.  To fix this, we have to add extra fields to the LUN to
    accommodate a copy of the real command.
    
    Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>

commit 6391a11375de5e2bb1eb8481e54619761dc65d9f



Regards,
  Guy

On Sun, 12 Nov 2006 12:14:37 -0700
Matthew Wilcox <matthew@wil.cx> wrote:

> On Sun, Nov 12, 2006 at 04:03:50PM +0100, Guy Martin wrote:
> > This is how 2.4 detects it :
> > scsi3: (4:0) Synchronous at offset 8, period 100ns
> >   Vendor: PLEXTOR   Model: CD-R   PX-R820T   Rev: 1.08
> >   Type:   CD-ROM                             ANSI SCSI revision: 02
> > 
> > And this is how 2.6 detects it :
> > [42949430.090000]   Vendor: PLEXTOR   Model: CD-R   PX-R820T   Rev: 1.08
> > [42949430.150000]   Type:   CD-ROM                             ANSI SCSI revision: 02
> > [42949430.170000]  target2:0:4: Beginning Domain Validation
> > [42949430.180000]  target2:0:4: asynchronous
> > [42949430.190000]  target2:0:4: FAST-10 SCSI 10.0 MB/s ST (100 ns, offset 8)
> > [42949430.200000]  target2:0:4: Domain Validation skipping write tests
> > [42949430.210000]  target2:0:4: Ending Domain Validation
> > 
> > 
> > The main difference seems that 2.4 detects and syncronous drive while 2.6 detects an async one.
> 
> Um, you're just confused by the debug output from the DV code.  First it
> negotiates async, then it negotiates FAST-10.
> 
> > Full 2.4 dmesg : https://www.tuxicoman.be/temp/dmesg-2.4-53c700
> > Full 2.6 dmesg : https://www.tuxicoman.be/temp/dmesg-2.6-53c700
> > 2.6 kernel config : https://www.tuxicoman.be/temp/k410-2.6.18.2-pa0.config
> > 
> > On my 2.6 kernel, when you try to mount it, you get the those error messages in loop.
> > 
> > Please have a look at it and let me know if you need any other info.
> 
> Presumably at some point in 2.6, this device worked fine.  Any chance
> you could bisect and figure out when it started failing?  I'd start with
> looking at something in the 2.6.8 sort of timeframe.
> _______________________________________________
> parisc-linux mailing list
> parisc-linux@lists.parisc-linux.org
> http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [parisc-linux] K410 SCSI 53c700 issue with PLEXTOR PX-R820T
  2006-11-27 10:58   ` Guy Martin
@ 2006-11-27 15:37     ` Matthew Wilcox
  2006-11-27 17:10       ` Guy Martin
       [not found]       ` <20061130101805.2a82273b.gmsoft@tuxicoman.be>
  0 siblings, 2 replies; 15+ messages in thread
From: Matthew Wilcox @ 2006-11-27 15:37 UTC (permalink / raw)
  To: Guy Martin; +Cc: parisc-linux

On Mon, Nov 27, 2006 at 11:58:32AM +0100, Guy Martin wrote:
> Some more detail on this issue.
> This burner still works at commit 6391a11375de5e2bb1eb8481e54619761dc65d9f but breaks at commit 0f13fc09db68de92585558984bff1c51b87db72f.

Thanks for narrowing it down so much!

> commit 0f13fc09db68de92585558984bff1c51b87db72f
> Author: James Bottomley <James.Bottomley@steeleye.com>
> Date:   Thu Jun 29 13:02:11 2006 -0400
> 
>     [SCSI] 53c700: fix breakage caused by the autosense update
>     
>     A bit of a brown paper bag issue.  The previous patch to remove the soon
>     to be ripped out fields that were used in autosense actually broke the
>     driver.  This patch fixes it and has been tested (honestly).

If James says he tested it, I believe him.  I *think* we're in the
situation where it works on machines without an IOMMU and breaks on
machines with an IOMMU.  Joel, Guy, do I have that right?
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [parisc-linux] K410 SCSI 53c700 issue with PLEXTOR PX-R820T
  2006-11-27 15:37     ` Matthew Wilcox
@ 2006-11-27 17:10       ` Guy Martin
  2006-11-30 16:50         ` Joel Soete
       [not found]       ` <20061130101805.2a82273b.gmsoft@tuxicoman.be>
  1 sibling, 1 reply; 15+ messages in thread
From: Guy Martin @ 2006-11-27 17:10 UTC (permalink / raw)
  To: Matthew Wilcox; +Cc: parisc-linux


Matthew,

In only tested on my K410. I'm clueless about IOMMU besides what I can read about it on wikipedia :)

I can give it a try on my b180l but I don't know if there is a point and if it has the right connector.

As James said, it looks like the size of some commands is not negociated properly or so.
http://lists.parisc-linux.org/pipermail/parisc-linux/2006-September/030204.html

Is there a way I make this negociation more verbose ?

However, unlike Joel's problem, those errors start to appear when I try to mount a cd or even before that when udevd starts and not after some untar/rm iterations. I sould mention that if I eject the media while mount is stuck, it aborts.

  Guy


On Mon, 27 Nov 2006 08:37:14 -0700
Matthew Wilcox <matthew@wil.cx> wrote:

> On Mon, Nov 27, 2006 at 11:58:32AM +0100, Guy Martin wrote:
> > Some more detail on this issue.
> > This burner still works at commit 6391a11375de5e2bb1eb8481e54619761dc65d9f but breaks at commit 0f13fc09db68de92585558984bff1c51b87db72f.
> 
> Thanks for narrowing it down so much!
> 
> > commit 0f13fc09db68de92585558984bff1c51b87db72f
> > Author: James Bottomley <James.Bottomley@steeleye.com>
> > Date:   Thu Jun 29 13:02:11 2006 -0400
> > 
> >     [SCSI] 53c700: fix breakage caused by the autosense update
> >     
> >     A bit of a brown paper bag issue.  The previous patch to remove the soon
> >     to be ripped out fields that were used in autosense actually broke the
> >     driver.  This patch fixes it and has been tested (honestly).
> 
> If James says he tested it, I believe him.  I *think* we're in the
> situation where it works on machines without an IOMMU and breaks on
> machines with an IOMMU.  Joel, Guy, do I have that right?
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [parisc-linux] K410 SCSI 53c700 issue with PLEXTOR PX-R820T
  2006-11-27 17:10       ` Guy Martin
@ 2006-11-30 16:50         ` Joel Soete
  0 siblings, 0 replies; 15+ messages in thread
From: Joel Soete @ 2006-11-30 16:50 UTC (permalink / raw)
  To: Guy Martin; +Cc: parisc-linux, Matthew Wilcox



Guy Martin wrote:
> Matthew,
> 
> In only tested on my K410. I'm clueless about IOMMU besides what I can read about it on wikipedia :)
> 
> I can give it a try on my b180l but I don't know if there is a point and if it has the right connector.
> 
Yes connectors and even hba are afaik the same (into LASI), the diff stand in this Uturn/U2 bus converter/adapter (ioscan 
name it bc, mstm ba?) on your K model (as on my D) and not on B180L+.

> As James said, it looks like the size of some commands is not negociated properly or so.
> http://lists.parisc-linux.org/pipermail/parisc-linux/2006-September/030204.html
> 
> Is there a way I make this negociation more verbose ?
> 
> However, unlike Joel's problem, those errors start to appear when I try to mount a cd or even before that when udevd starts and not after some untar/rm iterations. I sould mention that if I eject the media while mount is stuck, it aborts.
> 
>   Guy
> 
> 
> On Mon, 27 Nov 2006 08:37:14 -0700
> Matthew Wilcox <matthew@wil.cx> wrote:
> 
>> On Mon, Nov 27, 2006 at 11:58:32AM +0100, Guy Martin wrote:
>>> Some more detail on this issue.
>>> This burner still works at commit 6391a11375de5e2bb1eb8481e54619761dc65d9f but breaks at commit 0f13fc09db68de92585558984bff1c51b87db72f.
>> Thanks for narrowing it down so much!
>>
>>> commit 0f13fc09db68de92585558984bff1c51b87db72f
>>> Author: James Bottomley <James.Bottomley@steeleye.com>
>>> Date:   Thu Jun 29 13:02:11 2006 -0400
>>>
>>>     [SCSI] 53c700: fix breakage caused by the autosense update
>>>     
>>>     A bit of a brown paper bag issue.  The previous patch to remove the soon
>>>     to be ripped out fields that were used in autosense actually broke the
>>>     driver.  This patch fixes it and has been tested (honestly).
>> If James says he tested it, I believe him.  I *think* we're in the
>> situation where it works on machines without an IOMMU and breaks on
>> machines with an IOMMU.  Joel, Guy, do I have that right?
> 
Well my test case is totaly different as far as I just tested se-scsi disk.
And I don't own any PLEXTOR, so only GMSoft test on its b180 could confirm us if it's same kind of pb.

The only thing of what I still sure is that the pb occure to me when I tried to stress (high io rate) this driver.

Joel

> 
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [parisc-linux] K410 SCSI 53c700 issue with PLEXTOR PX-R820T
       [not found]       ` <20061130101805.2a82273b.gmsoft@tuxicoman.be>
@ 2006-11-30 17:17         ` James Bottomley
       [not found]         ` <1164907064.22826.23.camel@mulgrave.il.steeleye.com>
  1 sibling, 0 replies; 15+ messages in thread
From: James Bottomley @ 2006-11-30 17:17 UTC (permalink / raw)
  To: Guy Martin; +Cc: parisc-linux, Matthew Wilcox

Actually, your analysis isn't quite correct.  This is the real problem

On Thu, 2006-11-30 at 10:18 +0100, Guy Martin wrote:
> [42949427.280000] 53c700: scsi2, command sr 2:0:2:0: 
> [42949427.280000]         command: cdb[0]=0x43: 43 00 00 00 00 00 00 00 0c 40

READ_TOC(10) command (i.e. 10 byte command)

> [42949427.280000]  scatter block 0: move 12[0900000c] from 0x1d48e00
> [42949427.280000]  SETTING 001c0528 to 90080000
> [42949427.280000]  script, patching short field MessageCount at 30 to 0xe000001
> [42949427.280000]  script, patching ID field Device_ID at 0 to 0x41040000
> [42949427.280000]  script, patching CommandAddress at 121 to 0x1d508f8
> [42949427.280000]  script, patching short field CommandCount at 120 to 0xa00000a
> [42949427.280000]  script, patching SGScriptStartAddress at 191 to 0x1c0520
> [42949427.280000]  script, patching SGScriptStartAddress at 207 to 0x1c0520
> [42949427.290000] scsi2: istat 01 sstat0 00 dstat 84 dsp 012a[001c04a8] dsps 0x401
> [42949427.290000] scsi2: (2:0) ====>SCRIPT INTERRUPT<====
> [42949427.290000]   COMMAND COMPLETE, status=02

Returns Check Condition, causing the driver to send out a REQUEST_SENSE
command, which it begins here using the same slot:

> [42949427.290000]  script, patching short field MessageCount at 30 to 0xe000006
> [42949427.290000]  script, patching ID field Device_ID at 0 to 0x41040000
> [42949427.290000]  script, patching CommandAddress at 121 to 0x1d58c20
> [42949427.290000]  script, patching short field CommandCount at 120 to 0xa00000a

This patches the command length to ten bytes, but REQUEST_SENSE is only
a 6 byte command ... it's clearly inherited the length parameter from
the previous command.

> [42949427.290000]  script, patching SGScriptStartAddress at 191 to 0x1c0520
> [42949427.290000]  script, patching SGScriptStartAddress at 207 to 0x1c0520
> [42949427.290000] scsi2: Issuing saved command slot 4f6b8520, cmd 4f23b8c0      
> [42949427.300000] scsi2: istat 09 sstat0 00 dstat 84 dsp 00ba[001c02e8] dsps 0x250
> [42949427.300000] scsi2: (2:0) ====>SCRIPT INTERRUPT<====
> [42949427.300000] scsi2 (2:0): message before command phase: 01 03 01 3b 08 
> [42949427.300000] Attempting to resume at 1c02e8
> [42949427.320000] scsi2: istat 0a sstat0 c0 dstat 00 dsp 007a[001c01e8] dsps 0x1d58c20
> [42949427.320000] scsi2: (2:0) phase mismatch at 01e8, phase IO BSY DATA_IN

And here we get a phase mismatch in the command phase because the drive
transitions to data phase after six bytes and the driver still thinks it
has another four to send.

I'd have the maintainer shot ... he clearly forgot to set up the command
length for auto request sense.

James


_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [parisc-linux] K410 SCSI 53c700 issue with PLEXTOR PX-R820T
       [not found]         ` <1164907064.22826.23.camel@mulgrave.il.steeleye.com>
@ 2006-11-30 18:13           ` James Bottomley
       [not found]           ` <1164910427.22826.37.camel@mulgrave.il.steeleye.com>
  1 sibling, 0 replies; 15+ messages in thread
From: James Bottomley @ 2006-11-30 18:13 UTC (permalink / raw)
  To: Guy Martin; +Cc: Matthew Wilcox, parisc-linux

On Thu, 2006-11-30 at 12:17 -0500, James Bottomley wrote:
> And here we get a phase mismatch in the command phase because the drive
> transitions to data phase after six bytes and the driver still thinks it
> has another four to send.
> 
> I'd have the maintainer shot ... he clearly forgot to set up the command
> length for auto request sense.

Try this and see if it fixes the problem

James

diff --git a/drivers/scsi/53c700.c b/drivers/scsi/53c700.c
index 562432d..9aabb64 100644
--- a/drivers/scsi/53c700.c
+++ b/drivers/scsi/53c700.c
@@ -622,8 +622,10 @@ #endif
 			dma_unmap_single(hostdata->dev, slot->dma_handle, sizeof(SCp->sense_buffer), DMA_FROM_DEVICE);
 			/* restore the old result if the request sense was
 			 * successful */
-			if(result == 0)
+			if (result == 0)
 				result = cmnd[7];
+			/* restore the original length */
+			SCp->cmd_len = cmnd[8];
 		} else
 			NCR_700_unmap(hostdata, SCp, slot);
 
@@ -1007,6 +1009,9 @@ #endif
 				 * of the command */
 				cmnd[6] = NCR_700_INTERNAL_SENSE_MAGIC;
 				cmnd[7] = hostdata->status[0];
+				cmnd[8] = SCp->cmd_len;
+				SCp->cmd_len = 6; /* command length for 
+						   * REQUEST_SENSE */
 				slot->pCmd = dma_map_single(hostdata->dev, cmnd, MAX_COMMAND_SIZE, DMA_TO_DEVICE);
 				slot->dma_handle = dma_map_single(hostdata->dev, SCp->sense_buffer, sizeof(SCp->sense_buffer), DMA_FROM_DEVICE);
 				slot->SG[0].ins = bS_to_host(SCRIPT_MOVE_DATA_IN | sizeof(SCp->sense_buffer));


_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [parisc-linux] K410 SCSI 53c700 issue with PLEXTOR PX-R820T
       [not found]           ` <1164910427.22826.37.camel@mulgrave.il.steeleye.com>
@ 2006-11-30 18:48             ` Guy Martin
       [not found]             ` <20061130194830.90043d05.gmsoft@tuxicoman.be>
  1 sibling, 0 replies; 15+ messages in thread
From: Guy Martin @ 2006-11-30 18:48 UTC (permalink / raw)
  To: James Bottomley; +Cc: Matthew Wilcox, parisc-linux


Hi James,

This is working fine ! Thanks a lot !

I was able to mount a cd without any pb.

Cheers,
  Guy

On Thu, 30 Nov 2006 13:13:46 -0500
James Bottomley <James.Bottomley@SteelEye.com> wrote:

> On Thu, 2006-11-30 at 12:17 -0500, James Bottomley wrote:
> > And here we get a phase mismatch in the command phase because the drive
> > transitions to data phase after six bytes and the driver still thinks it
> > has another four to send.
> > 
> > I'd have the maintainer shot ... he clearly forgot to set up the command
> > length for auto request sense.
> 
> Try this and see if it fixes the problem
> 
> James

_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [parisc-linux] K410 SCSI 53c700 issue with PLEXTOR PX-R820T
       [not found]             ` <20061130194830.90043d05.gmsoft@tuxicoman.be>
@ 2006-12-01 15:58               ` Joel Soete
       [not found]               ` <45705108.3080500@scarlet.be>
  1 sibling, 0 replies; 15+ messages in thread
From: Joel Soete @ 2006-12-01 15:58 UTC (permalink / raw)
  To: Guy Martin; +Cc: James Bottomley, parisc-linux, Matthew Wilcox



Guy Martin wrote:
> Hi James,
> 
> This is working fine ! Thanks a lot !
> 
> I was able to mount a cd without any pb.
> 
> Cheers,
>   Guy
> 
> On Thu, 30 Nov 2006 13:13:46 -0500
> James Bottomley <James.Bottomley@SteelEye.com> wrote:
> 
>> On Thu, 2006-11-30 at 12:17 -0500, James Bottomley wrote:
>>> And here we get a phase mismatch in the command phase because the drive
>>> transitions to data phase after six bytes and the driver still thinks it
>>> has another four to send.
>>>
>>> I'd have the maintainer shot ... he clearly forgot to set up the command
>>> length for auto request sense.
>> Try this and see if it fixes the problem
>>
>> James
> 
Sorry no yet a fix for my pb :_(
scsi1: (3:0) phase mismatch at 01e8, phase IO CD MSG BSY REQ MSG IN
scsi1: Bus Reset detected, executing command 15db93c0, slot 2ff48520, dsp 001c81e8[01e8]
  failing command because of reset, slot 2ff48520, cmnd 15db93c0
  failing command because of reset, slot 2ff4864c, cmnd 2feb03c0
  failing command because of reset, slot 2ff48778, cmnd 2feb0840
  failing command because of reset, slot 2ff488a4, cmnd 2feb0720

May be DEBUG will help too (but my c110 is naturally slow, so not sure, anyway I am trying)

Joel
anyway some progress has to be noticed: I can kill the process (Ctrl-C) and the system stay usable
> _______________________________________________
> parisc-linux mailing list
> parisc-linux@lists.parisc-linux.org
> http://lists.parisc-linux.org/mailman/listinfo/parisc-linux
> 
> 
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [parisc-linux] K410 SCSI 53c700 issue with PLEXTOR PX-R820T
       [not found]               ` <45705108.3080500@scarlet.be>
@ 2006-12-01 16:10                 ` Matthew Wilcox
       [not found]                 ` <20061201161033.GO14076@parisc-linux.org>
  1 sibling, 0 replies; 15+ messages in thread
From: Matthew Wilcox @ 2006-12-01 16:10 UTC (permalink / raw)
  To: Joel Soete; +Cc: Guy Martin, James Bottomley, parisc-linux

On Fri, Dec 01, 2006 at 03:58:00PM +0000, Joel Soete wrote:
> Sorry no yet a fix for my pb :_(

It'd be useful to know if your problem was introduced at the same time.
Can you try the same git revisions that Guy tried and let us know if
that's the same commit that broke your machine?
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [parisc-linux] K410 SCSI 53c700 issue with PLEXTOR PX-R820T
       [not found]                 ` <20061201161033.GO14076@parisc-linux.org>
@ 2006-12-01 22:42                   ` Joel Soete
       [not found]                   ` <4570AFC3.1050304@scarlet.be>
  1 sibling, 0 replies; 15+ messages in thread
From: Joel Soete @ 2006-12-01 22:42 UTC (permalink / raw)
  To: Matthew Wilcox; +Cc: Guy Martin, James Bottomley, parisc-linux



Matthew Wilcox wrote:
> On Fri, Dec 01, 2006 at 03:58:00PM +0000, Joel Soete wrote:
>> Sorry no yet a fix for my pb :_(
> 
> It'd be useful to know if your problem was introduced at the same time.
> Can you try the same git revisions that Guy tried and let us know if
> that's the same commit that broke your machine?
> 
mmm reading back this pr <http://lists.parisc-linux.org/pipermail/parisc-linux/2006-July/029506.html>
my pb seems to be already in early 2.6.18-rc1-pa1 and most probably in 2.6.17 (according to my ps at this time).

Eventhought I have the filling that there was always pbs with this driver on my c110 
(<http://lists.parisc-linux.org/pipermail/parisc-linux/2004-September/024736.html>),
I am ready to grab what Guy tried;
may be can you send me the git cmdl parameters to grab exactely the same stuff.

Joel

PS: the d380 I have for testing have to go back to production, sorry it couldn't help us for a while :_(

_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [parisc-linux] K410 SCSI 53c700 issue with PLEXTOR PX-R820T
       [not found]                   ` <4570AFC3.1050304@scarlet.be>
@ 2006-12-01 23:02                     ` Joel Soete
  2006-12-02  7:19                     ` Guy Martin
  1 sibling, 0 replies; 15+ messages in thread
From: Joel Soete @ 2006-12-01 23:02 UTC (permalink / raw)
  To: Joel Soete; +Cc: Guy Martin, James Bottomley, parisc-linux, Matthew Wilcox

Sorry for this auto followup but during am i writing previous line I was testing a older vmlinux-2.6.16-pa10 and this pb was 
showing his face after a bit more then 30min of loop test:
scsi1: (3:0) phase mismatch at 01e8, phase IO CD MSG BSY REQ MSG IN
scsi1: Bus Reset detected, executing command 2ca36620, slot 2fd18520, dsp 001c81e8[01e8]
  failing command because of reset, slot 2fd18520, cmnd 2ca36620
  failing command because of reset, slot 2fd1864c, cmnd 2ca368e0
  failing command because of reset, slot 2fd18778, cmnd 2ca36200
  failing command because of reset, slot 2fd188a4, cmnd 149c6320

but:
   - one time (after about 45 min)
   - and the test can continue (while in 2.6.18-rc1-pa1 it finished always by panicing
     because ccio finished by being overloaded.

Joel



Joel Soete wrote:
> 
> 
> Matthew Wilcox wrote:
>> On Fri, Dec 01, 2006 at 03:58:00PM +0000, Joel Soete wrote:
>>> Sorry no yet a fix for my pb :_(
>>
>> It'd be useful to know if your problem was introduced at the same time.
>> Can you try the same git revisions that Guy tried and let us know if
>> that's the same commit that broke your machine?
>>
> mmm reading back this pr 
> <http://lists.parisc-linux.org/pipermail/parisc-linux/2006-July/029506.html> 
> 
> my pb seems to be already in early 2.6.18-rc1-pa1 and most probably in 
> 2.6.17 (according to my ps at this time).
> 
> Eventhought I have the filling that there was always pbs with this 
> driver on my c110 
> (<http://lists.parisc-linux.org/pipermail/parisc-linux/2004-September/024736.html>), 
> 
> I am ready to grab what Guy tried;
> may be can you send me the git cmdl parameters to grab exactely the same 
> stuff.
> 
> Joel
> 
> PS: the d380 I have for testing have to go back to production, sorry it 
> couldn't help us for a while :_(
> 
> _______________________________________________
> parisc-linux mailing list
> parisc-linux@lists.parisc-linux.org
> http://lists.parisc-linux.org/mailman/listinfo/parisc-linux
> 
> 
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [parisc-linux] K410 SCSI 53c700 issue with PLEXTOR PX-R820T
       [not found]                   ` <4570AFC3.1050304@scarlet.be>
  2006-12-01 23:02                     ` Joel Soete
@ 2006-12-02  7:19                     ` Guy Martin
  1 sibling, 0 replies; 15+ messages in thread
From: Guy Martin @ 2006-12-02  7:19 UTC (permalink / raw)
  To: Joel Soete; +Cc: James.Bottomley, parisc-linux, matthew



Joel,

The git commands I used may not be the best but it works :)

You have to find out the commit you want with git log or anything else.
Then do "git branch <branchname> <commit#>" to create a new branch at that commit. Then you can "git checkout <branchname>" to have your workdir reflect that branch.
Maybe it's more appropriate to do this with tags but I don't think it's possible to checkout on tags.


  Guy


On Fri, 01 Dec 2006 22:42:11 +0000
Joel Soete <soete.joel@scarlet.be> wrote:

> 
> 
> Matthew Wilcox wrote:
> > On Fri, Dec 01, 2006 at 03:58:00PM +0000, Joel Soete wrote:
> >> Sorry no yet a fix for my pb :_(
> > 
> > It'd be useful to know if your problem was introduced at the same time.
> > Can you try the same git revisions that Guy tried and let us know if
> > that's the same commit that broke your machine?
> > 
> mmm reading back this pr <http://lists.parisc-linux.org/pipermail/parisc-linux/2006-July/029506.html>
> my pb seems to be already in early 2.6.18-rc1-pa1 and most probably in 2.6.17 (according to my ps at this time).
> 
> Eventhought I have the filling that there was always pbs with this driver on my c110 
> (<http://lists.parisc-linux.org/pipermail/parisc-linux/2004-September/024736.html>),
> I am ready to grab what Guy tried;
> may be can you send me the git cmdl parameters to grab exactely the same stuff.
> 
> Joel
> 
> PS: the d380 I have for testing have to go back to production, sorry it couldn't help us for a while :_(
> 


_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2006-12-02  7:19 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-12 15:03 [parisc-linux] K410 SCSI 53c700 issue with PLEXTOR PX-R820T Guy Martin
2006-11-12 19:14 ` Matthew Wilcox
2006-11-15 23:49   ` Guy Martin
2006-11-27 10:58   ` Guy Martin
2006-11-27 15:37     ` Matthew Wilcox
2006-11-27 17:10       ` Guy Martin
2006-11-30 16:50         ` Joel Soete
     [not found]       ` <20061130101805.2a82273b.gmsoft@tuxicoman.be>
2006-11-30 17:17         ` James Bottomley
     [not found]         ` <1164907064.22826.23.camel@mulgrave.il.steeleye.com>
2006-11-30 18:13           ` James Bottomley
     [not found]           ` <1164910427.22826.37.camel@mulgrave.il.steeleye.com>
2006-11-30 18:48             ` Guy Martin
     [not found]             ` <20061130194830.90043d05.gmsoft@tuxicoman.be>
2006-12-01 15:58               ` Joel Soete
     [not found]               ` <45705108.3080500@scarlet.be>
2006-12-01 16:10                 ` Matthew Wilcox
     [not found]                 ` <20061201161033.GO14076@parisc-linux.org>
2006-12-01 22:42                   ` Joel Soete
     [not found]                   ` <4570AFC3.1050304@scarlet.be>
2006-12-01 23:02                     ` Joel Soete
2006-12-02  7:19                     ` Guy Martin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox