Linux PARISC architecture development
 help / color / mirror / Atom feed
From: Grant Grundler <grundler@parisc-linux.org>
To: Helge Deller <deller@gmx.de>
Cc: linux-parisc <linux-parisc@vger.kernel.org>,
	Kyle McMartin <kyle@mcmartin.ca>
Subject: Re: [PATCH] Change cpu_data[] and cpu_devices[] from array sized by NR_CPUS to per_cpu variables
Date: Tue, 26 Aug 2008 22:51:10 -0600	[thread overview]
Message-ID: <20080827045110.GA30954@colo.lackof.org> (raw)
In-Reply-To: <48B1D185.4060805@gmx.de>

On Sun, Aug 24, 2008 at 11:24:21PM +0200, Helge Deller wrote:
> Updated patch attached, which fixes some build problems and section 
> mismatches.
> Boot-tested on a UP 32bit machine with CONFIG_SMP=y.

Fixed this build failure (64-bit):
  CC      arch/parisc/kernel/perf.o
arch/parisc/kernel/perf.c: In function 'perf_init':
arch/parisc/kernel/perf.c:544: error: 'cpu_data' undeclared (first use in this function)
arch/parisc/kernel/perf.c:544: error: (Each undeclared identifier is reported only once
arch/parisc/kernel/perf.c:544: error: for each function it appears in.)
make[1]: *** [arch/parisc/kernel/perf.o] Error 1

Signed-off-by: Grant Grundler <grundler@parisc-linux.org>

diff --git a/arch/parisc/kernel/perf.c b/arch/parisc/kernel/perf.c
index f696f57..c661db7 100644
--- a/arch/parisc/kernel/perf.c
+++ b/arch/parisc/kernel/perf.c
@@ -55,6 +55,7 @@
 #include <asm/processor.h>
 #include <asm/runway.h>
 #include <asm/io.h>		/* for __raw_read() */
+#include <asm/percpu.h>
 
 #include "perf_images.h"
 
@@ -541,9 +542,9 @@ static int __init perf_init(void)
 	spin_lock_init(&perf_lock);
 
 	/* TODO: this only lets us access the first cpu.. what to do for SMP? */
-	cpu_device = cpu_data[0].dev;
+	cpu_device = per_cpu(cpu_data, 0).dev;
 	printk("Performance monitoring counters enabled for %s\n",
-		cpu_data[0].dev->name);
+		cpu_device->name);
 
 	return 0;
 }

  reply	other threads:[~2008-08-27  4:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-24 18:26 [PATCH] - Patch series for parisc Helge Deller
2008-08-24 18:33 ` [PATCH] compat_sys_ptrace conversions " Helge Deller
2008-08-25 16:52   ` Christoph Hellwig
2008-08-26 21:09     ` Roland McGrath
2008-08-25 17:11   ` Kyle McMartin
2008-08-25 17:49     ` Helge Deller
2008-08-26 20:03       ` Christoph Hellwig
2008-08-24 18:45 ` [PATCH] fix crash when trying to unwind user space Helge Deller
2008-08-24 18:51 ` [PATCH] drop superfluous .align 16 Helge Deller
2008-08-24 18:57   ` James Bottomley
2008-08-25 12:31     ` Helge Deller
2008-08-26  4:26       ` Grant Grundler
2008-08-26 12:42         ` Carlos O'Donell
2008-08-26 14:10           ` James Bottomley
2008-08-26 15:35             ` Carlos O'Donell
2008-08-24 19:04 ` [PATCH] ldcw inline assembler patch Helge Deller
2008-08-24 19:21 ` [PATCH] Change cpu_data[] and cpu_devices[] from array sized by NR_CPUS to per_cpu variables Helge Deller
2008-08-24 21:24   ` Helge Deller
2008-08-27  4:51     ` Grant Grundler [this message]
2008-08-27 20:42       ` Helge Deller
2008-08-24 19:49 ` [PATCH] - Patch series for parisc Helge Deller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080827045110.GA30954@colo.lackof.org \
    --to=grundler@parisc-linux.org \
    --cc=deller@gmx.de \
    --cc=kyle@mcmartin.ca \
    --cc=linux-parisc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox