Re: [PATCH] drop superfluous .align 16

[Helge Deller <deller@gmx.de>]

James Bottomley wrote:
> On Sun, 2008-08-24 at 20:51 +0200, Helge Deller wrote:
>> This .align 16 is misplaced and should be in front of the ENTRY(lws_lock_start).
>> Works because of pure luck since we have a .align PAGE_SIZE before it instead.
>>
>> Signed-off-by: Helge Deller <deller@gmx.de>
>>
>> diff --git a/arch/parisc/kernel/syscall.S b/arch/parisc/kernel/syscall.S
>> index 69b6eeb..c6ff81f 100644
>> --- a/arch/parisc/kernel/syscall.S
>> +++ b/arch/parisc/kernel/syscall.S
>> @@ -640,7 +640,6 @@ END(sys_call_table64)
>>  	.align	PAGE_SIZE
>>  ENTRY(lws_lock_start)
>>  	/* lws locks */
>> -	.align 16
>>  	.rept 16
>>  	/* Keep locks aligned at 16-bytes */
>>  	.word 1
> 
> I think I'd really rather keep this.  It may be technically superfluous
> because of the .align PAGE_SIZE above it, but that belongs to the
> syscall table.  

> If anyone ever moved this section in head.S, the align
> 16 ensures nothing goes wrong.

Hi James,

If the block is moved, then that's exactly what this .align does not 
ensure.
We had this discussion already here on the list. Please read the full 
thread: http://marc.info/?t=121554765000005&r=1&w=2

Helge