Linux PARISC architecture development
 help / color / mirror / Atom feed
* [PATCH] parisc: ccio-dma: fix build failure without procfs
@ 2009-04-03 12:08 Alexander Beregalov
  2009-04-03 17:59 ` Kyle McMartin
  0 siblings, 1 reply; 3+ messages in thread
From: Alexander Beregalov @ 2009-04-03 12:08 UTC (permalink / raw)
  To: kyle, linux-parisc

Fix this build error when CONFIG_PROC_FS is not set:
drivers/parisc/ccio-dma.c:1574: error: 'ccio_proc_info_fops' undeclared

Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
---

 drivers/parisc/ccio-dma.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/parisc/ccio-dma.c b/drivers/parisc/ccio-dma.c
index 5d610cb..0f0e0b9 100644
--- a/drivers/parisc/ccio-dma.c
+++ b/drivers/parisc/ccio-dma.c
@@ -1134,7 +1134,7 @@ static const struct file_operations ccio_proc_bitmap_fops = {
 	.llseek = seq_lseek,
 	.release = single_release,
 };
-#endif
+#endif /* CONFIG_PROC_FS */
 
 /**
  * ccio_find_ioc - Find the ioc in the ioc_list
@@ -1568,14 +1568,15 @@ static int __init ccio_probe(struct parisc_device *dev)
 	/* if this fails, no I/O cards will work, so may as well bug */
 	BUG_ON(dev->dev.platform_data == NULL);
 	HBA_DATA(dev->dev.platform_data)->iommu = ioc;
-	
+
+#ifdef CONFIG_PROC_FS
 	if (ioc_count == 0) {
 		proc_create(MODULE_NAME, 0, proc_runway_root,
 			    &ccio_proc_info_fops);
 		proc_create(MODULE_NAME"-bitmap", 0, proc_runway_root,
 			    &ccio_proc_bitmap_fops);
 	}

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] parisc: ccio-dma: fix build failure without procfs
  2009-04-03 12:08 [PATCH] parisc: ccio-dma: fix build failure without procfs Alexander Beregalov
@ 2009-04-03 17:59 ` Kyle McMartin
  2009-05-14 10:30   ` Alexander Beregalov
  0 siblings, 1 reply; 3+ messages in thread
From: Kyle McMartin @ 2009-04-03 17:59 UTC (permalink / raw)
  To: Alexander Beregalov; +Cc: kyle, linux-parisc

On Fri, Apr 03, 2009 at 04:08:54PM +0400, Alexander Beregalov wrote:
> Fix this build error when CONFIG_PROC_FS is not set:
> drivers/parisc/ccio-dma.c:1574: error: 'ccio_proc_info_fops' undeclared
> 
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>

Applied to the fixes branch.

cheers, Kyle

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] parisc: ccio-dma: fix build failure without procfs
  2009-04-03 17:59 ` Kyle McMartin
@ 2009-05-14 10:30   ` Alexander Beregalov
  0 siblings, 0 replies; 3+ messages in thread
From: Alexander Beregalov @ 2009-05-14 10:30 UTC (permalink / raw)
  To: Kyle McMartin; +Cc: linux-parisc

2009/4/3 Kyle McMartin <kyle@mcmartin.ca>:
> On Fri, Apr 03, 2009 at 04:08:54PM +0400, Alexander Beregalov wrote:
>> Fix this build error when CONFIG_PROC_FS is not set:
>> drivers/parisc/ccio-dma.c:1574: error: 'ccio_proc_info_fops' undeclared
>>
>> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
>
> Applied to the fixes branch.

Hi Kyle.

It still fails with linux-next.

Could you please send it to Linus or ask Stephen to pull different
branch (with all latest changes) of your tree?

Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-05-14 10:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-03 12:08 [PATCH] parisc: ccio-dma: fix build failure without procfs Alexander Beregalov
2009-04-03 17:59 ` Kyle McMartin
2009-05-14 10:30   ` Alexander Beregalov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox