* [PATCH] Do not set CROSS_COMPILE but let CONFIG_CROSS_COMPILE handle it all.
@ 2011-05-24 17:47 Jeroen Roovers
2011-05-26 5:15 ` Mike Frysinger
2011-05-26 5:16 ` Mike Frysinger
0 siblings, 2 replies; 3+ messages in thread
From: Jeroen Roovers @ 2011-05-24 17:47 UTC (permalink / raw)
To: linux-parisc
Do not set CROSS_COMPILE but let CONFIG_CROSS_COMPILE handle it all.
The problem this fixes manifests itself when you try to build a 64-bit kernel
on a distro which does not provide hppa$(WIDTH)-linux-gnu- but perhaps
hppa$(WIDTH)-unknown-linux-gnu- instead, like Gentoo Linux.
Signed-off-by: Jeroen Roovers <jer@gentoo.org>
---
--- a/arch/parisc/Makefile
+++ b/arch/parisc/Makefile
@@ -31,16 +31,10 @@
UTS_MACHINE := parisc64
CHECKFLAGS += -D__LP64__=1 -m64
WIDTH := 64
-CROSS_COMPILE := hppa64-linux-gnu-
else # 32-bit
WIDTH :=
endif
-# attempt to help out folks who are cross-compiling
-ifeq ($(NATIVE),1)
-CROSS_COMPILE := hppa$(WIDTH)-linux-
-endif
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Do not set CROSS_COMPILE but let CONFIG_CROSS_COMPILE handle it all.
2011-05-24 17:47 [PATCH] Do not set CROSS_COMPILE but let CONFIG_CROSS_COMPILE handle it all Jeroen Roovers
@ 2011-05-26 5:15 ` Mike Frysinger
2011-05-26 5:16 ` Mike Frysinger
1 sibling, 0 replies; 3+ messages in thread
From: Mike Frysinger @ 2011-05-26 5:15 UTC (permalink / raw)
To: Jeroen Roovers; +Cc: linux-parisc
[-- Attachment #1: Type: Text/Plain, Size: 1029 bytes --]
On Tuesday, May 24, 2011 13:47:01 Jeroen Roovers wrote:
> Do not set CROSS_COMPILE but let CONFIG_CROSS_COMPILE handle it all.
> The problem this fixes manifests itself when you try to build a 64-bit
> kernel on a distro which does not provide hppa$(WIDTH)-linux-gnu- but
> perhaps hppa$(WIDTH)-unknown-linux-gnu- instead, like Gentoo Linux.
>
> --- a/arch/parisc/Makefile
> +++ b/arch/parisc/Makefile
> @@ -31,16 +31,10 @@
> UTS_MACHINE := parisc64
> CHECKFLAGS += -D__LP64__=1 -m64
> WIDTH := 64
> -CROSS_COMPILE := hppa64-linux-gnu-
> else # 32-bit
> WIDTH :=
> endif
>
> -# attempt to help out folks who are cross-compiling
> -ifeq ($(NATIVE),1)
> -CROSS_COMPILE := hppa$(WIDTH)-linux-
> -endif
i wonder if there isnt some middle ground. like only setting CROSS_COMPILE
like so:
ifeq ($(CROSS_COMPILE),)
CROSS_COMPILE := hppa$(WIDTH)-linux-
endif
i think that should still work if people set CONFIG_CROSS_COMPILE, but if they
havent, get the existing (semi-sane) defaults.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Do not set CROSS_COMPILE but let CONFIG_CROSS_COMPILE handle it all.
2011-05-24 17:47 [PATCH] Do not set CROSS_COMPILE but let CONFIG_CROSS_COMPILE handle it all Jeroen Roovers
2011-05-26 5:15 ` Mike Frysinger
@ 2011-05-26 5:16 ` Mike Frysinger
1 sibling, 0 replies; 3+ messages in thread
From: Mike Frysinger @ 2011-05-26 5:16 UTC (permalink / raw)
To: Jeroen Roovers; +Cc: linux-parisc
[-- Attachment #1: Type: Text/Plain, Size: 168 bytes --]
also, since this is a parisc-specific patch, i'd suggest a summary that
reflects that. perhaps something like:
parisc: do not always override CROSS_COMPILE
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-26 5:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-24 17:47 [PATCH] Do not set CROSS_COMPILE but let CONFIG_CROSS_COMPILE handle it all Jeroen Roovers
2011-05-26 5:15 ` Mike Frysinger
2011-05-26 5:16 ` Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox