* [PATCH] parisc: fix NATIVE set up in build
@ 2013-05-04 16:50 Mike Frysinger
2013-05-04 17:33 ` Rolf Eike Beer
2013-05-07 23:24 ` John David Anglin
0 siblings, 2 replies; 4+ messages in thread
From: Mike Frysinger @ 2013-05-04 16:50 UTC (permalink / raw)
To: linux-parisc, Helge Deller, James E.J. Bottomley
The ifeq operator does not accept globs, so this little bit of code will
never match (unless uname literally prints out "parsic*"). Rewrite to
use a pattern matching operator so that NATIVE is set to 1 on parisc.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
arch/parisc/Makefile | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
index 113e282..2f967cc 100644
--- a/arch/parisc/Makefile
+++ b/arch/parisc/Makefile
@@ -24,9 +24,7 @@ CHECKFLAGS += -D__hppa__=1
LIBGCC = $(shell $(CC) $(KBUILD_CFLAGS) -print-libgcc-file-name)
MACHINE := $(shell uname -m)
-ifeq ($(MACHINE),parisc*)
-NATIVE := 1
-endif
+NATIVE := $(if $(filter parisc%,$(MACHINE)),1,0)
ifdef CONFIG_64BIT
UTS_MACHINE := parisc64
--
1.8.2.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] parisc: fix NATIVE set up in build
2013-05-04 16:50 [PATCH] parisc: fix NATIVE set up in build Mike Frysinger
@ 2013-05-04 17:33 ` Rolf Eike Beer
2013-05-07 23:24 ` John David Anglin
1 sibling, 0 replies; 4+ messages in thread
From: Rolf Eike Beer @ 2013-05-04 17:33 UTC (permalink / raw)
To: Mike Frysinger; +Cc: linux-parisc, Helge Deller, James E.J. Bottomley
Am 04.05.2013 18:50, schrieb Mike Frysinger:
> The ifeq operator does not accept globs, so this little bit of code
> will
> never match (unless uname literally prints out "parsic*"). Rewrite to
^^^^^^
That would never match ;)
Eike
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] parisc: fix NATIVE set up in build
2013-05-04 16:50 [PATCH] parisc: fix NATIVE set up in build Mike Frysinger
2013-05-04 17:33 ` Rolf Eike Beer
@ 2013-05-07 23:24 ` John David Anglin
2013-05-09 5:04 ` Mike Frysinger
1 sibling, 1 reply; 4+ messages in thread
From: John David Anglin @ 2013-05-07 23:24 UTC (permalink / raw)
To: Mike Frysinger; +Cc: linux-parisc, Helge Deller, James E.J. Bottomley
This patch breaks builds on current Debian systems that want compiler
prefixes
like hppa64-linux-gnu-", "hppa-linux-gnu-" or no prefix for native 32-
bit. The NATIVE
match previous failed and we got the correct FSF prefix.
Dave
On 4-May-13, at 12:50 PM, Mike Frysinger wrote:
> The ifeq operator does not accept globs, so this little bit of code
> will
> never match (unless uname literally prints out "parsic*"). Rewrite to
> use a pattern matching operator so that NATIVE is set to 1 on parisc.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> arch/parisc/Makefile | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
> index 113e282..2f967cc 100644
> --- a/arch/parisc/Makefile
> +++ b/arch/parisc/Makefile
> @@ -24,9 +24,7 @@ CHECKFLAGS += -D__hppa__=1
> LIBGCC = $(shell $(CC) $(KBUILD_CFLAGS) -print-libgcc-file-name)
>
> MACHINE := $(shell uname -m)
> -ifeq ($(MACHINE),parisc*)
> -NATIVE := 1
> -endif
> +NATIVE := $(if $(filter parisc%,$(MACHINE)),1,0)
>
> ifdef CONFIG_64BIT
> UTS_MACHINE := parisc64
> --
> 1.8.2.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-
> parisc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
John David Anglin dave.anglin@bell.net
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] parisc: fix NATIVE set up in build
2013-05-07 23:24 ` John David Anglin
@ 2013-05-09 5:04 ` Mike Frysinger
0 siblings, 0 replies; 4+ messages in thread
From: Mike Frysinger @ 2013-05-09 5:04 UTC (permalink / raw)
To: John David Anglin; +Cc: linux-parisc, Helge Deller, James E.J. Bottomley
[-- Attachment #1: Type: Text/Plain, Size: 333 bytes --]
On Tuesday 07 May 2013 19:24:04 John David Anglin wrote:
> This patch breaks builds on current Debian systems that want compiler
> prefixes
> like hppa64-linux-gnu-", "hppa-linux-gnu-" or no prefix for native 32-
> bit. The NATIVE
> match previous failed and we got the correct FSF prefix.
that was the intention of the code
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-09 5:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-04 16:50 [PATCH] parisc: fix NATIVE set up in build Mike Frysinger
2013-05-04 17:33 ` Rolf Eike Beer
2013-05-07 23:24 ` John David Anglin
2013-05-09 5:04 ` Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox