* [PATCH] parisc: parport_gsc: constify parisc_device_id
@ 2017-08-19 17:08 Arvind Yadav
2017-10-14 21:27 ` Sudip Mukherjee
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-08-19 17:08 UTC (permalink / raw)
To: jejb, deller, sudipm.mukherjee; +Cc: linux-kernel, linux-parisc
parisc_device_id are not supposed to change at runtime. All functions
working with parisc_device_id provided by <asm/parisc-device.h> work
with
const parisc_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/parport/parport_gsc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/parport/parport_gsc.c b/drivers/parport/parport_gsc.c
index 3858b87..8be1a0c 100644
--- a/drivers/parport/parport_gsc.c
+++ b/drivers/parport/parport_gsc.c
@@ -403,7 +403,7 @@ static int parport_remove_chip(struct parisc_device *dev)
return 0;
}
-static struct parisc_device_id parport_tbl[] = {
+static const struct parisc_device_id parport_tbl[] = {
{ HPHW_FIO, HVERSION_REV_ANY_ID, HVERSION_ANY_ID, 0x74 },
{ 0, }
};
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] parisc: parport_gsc: constify parisc_device_id
2017-08-19 17:08 [PATCH] parisc: parport_gsc: constify parisc_device_id Arvind Yadav
@ 2017-10-14 21:27 ` Sudip Mukherjee
0 siblings, 0 replies; 2+ messages in thread
From: Sudip Mukherjee @ 2017-10-14 21:27 UTC (permalink / raw)
To: Arvind Yadav; +Cc: jejb, deller, linux-kernel, linux-parisc
On Sat, Aug 19, 2017 at 10:38:41PM +0530, Arvind Yadav wrote:
> parisc_device_id are not supposed to change at runtime. All functions
> working with parisc_device_id provided by <asm/parisc-device.h> work
> with
> const parisc_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/parport/parport_gsc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This has already been done by f0973443bef7 ("parisc/parport_gsc: Fix section mismatches")
--
Regards
Sudip
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-14 21:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-19 17:08 [PATCH] parisc: parport_gsc: constify parisc_device_id Arvind Yadav
2017-10-14 21:27 ` Sudip Mukherjee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox