* Re: [PATCH v9 01/16] tracing: move function tracer options to Kconfig (causing parisc build failures) [not found] ` <20201211184633.3213045-2-samitolvanen@google.com> @ 2021-02-24 20:17 ` Guenter Roeck 2021-02-24 20:38 ` Kees Cook 0 siblings, 1 reply; 6+ messages in thread From: Guenter Roeck @ 2021-02-24 20:17 UTC (permalink / raw) To: Sami Tolvanen Cc: Masahiro Yamada, Steven Rostedt, Will Deacon, Josh Poimboeuf, Peter Zijlstra, Greg Kroah-Hartman, Paul E. McKenney, Kees Cook, Nick Desaulniers, clang-built-linux, kernel-hardening, linux-arch, linux-arm-kernel, linux-kbuild, linux-kernel, linux-pci, linux-parisc, Helge Deller On Fri, Dec 11, 2020 at 10:46:18AM -0800, Sami Tolvanen wrote: > Move function tracer options to Kconfig to make it easier to add > new methods for generating __mcount_loc, and to make the options > available also when building kernel modules. > > Note that FTRACE_MCOUNT_USE_* options are updated on rebuild and > therefore, work even if the .config was generated in a different > environment. > > Signed-off-by: Sami Tolvanen <samitolvanen@google.com> > Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org> With this patch in place, parisc:allmodconfig no longer builds. Error log: Arch parisc is not supported with CONFIG_FTRACE_MCOUNT_RECORD at scripts/recordmcount.pl line 405. make[2]: *** [scripts/mod/empty.o] Error 2 Due to this problem, CONFIG_FTRACE_MCOUNT_RECORD can no longer be enabled in parisc builds. Since that is auto-selected by DYNAMIC_FTRACE, DYNAMIC_FTRACE can no longer be enabled, and with it everything that depends on it. Bisect log attached. Guenter --- # bad: [414eece95b98b209cef0f49cfcac108fd00b8ced] Merge tag 'clang-lto-v5.12-rc1-part2' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux # good: [b12b47249688915e987a9a2a393b522f86f6b7ab] Merge tag 'powerpc-5.12-1' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux git bisect start '414eece95b98' 'b12b47249688' # bad: [f6e1e1d1e149802ed4062fa514c2d184d30aacdf] Merge tag 'gfs2-for-5.12' of git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2 git bisect bad f6e1e1d1e149802ed4062fa514c2d184d30aacdf # bad: [79db4d2293eba2ce6265a341bedf6caecad5eeb3] Merge tag 'clang-lto-v5.12-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux git bisect bad 79db4d2293eba2ce6265a341bedf6caecad5eeb3 # good: [9d5032f97e9e0655e8c507ab1f43237e31520b00] dt-bindings: mediatek: mt8192: Fix dt_binding_check warning git bisect good 9d5032f97e9e0655e8c507ab1f43237e31520b00 # good: [f81f213850ca84b3d5e59e17d17acb2ecfc24076] Merge tag 'for-linus-5.12-1' of git://github.com/cminyard/linux-ipmi git bisect good f81f213850ca84b3d5e59e17d17acb2ecfc24076 # bad: [112b6a8e038d793d016e330f53acb9383ac504b3] arm64: allow LTO to be selected git bisect bad 112b6a8e038d793d016e330f53acb9383ac504b3 # bad: [3578ad11f3fba07e64c26d8db68cfd3dde28c59e] init: lto: fix PREL32 relocations git bisect bad 3578ad11f3fba07e64c26d8db68cfd3dde28c59e # bad: [22d429e75f24d114d99223389d6ba7047e952e32] kbuild: lto: limit inlining git bisect bad 22d429e75f24d114d99223389d6ba7047e952e32 # bad: [dc5723b02e523b2c4a68667f7e28c65018f7202f] kbuild: add support for Clang LTO git bisect bad dc5723b02e523b2c4a68667f7e28c65018f7202f # bad: [3b15cdc15956673ba1551d79bceae471436ac6a9] tracing: move function tracer options to Kconfig git bisect bad 3b15cdc15956673ba1551d79bceae471436ac6a9 # first bad commit: [3b15cdc15956673ba1551d79bceae471436ac6a9] tracing: move function tracer options to Kconfig ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v9 01/16] tracing: move function tracer options to Kconfig (causing parisc build failures) 2021-02-24 20:17 ` [PATCH v9 01/16] tracing: move function tracer options to Kconfig (causing parisc build failures) Guenter Roeck @ 2021-02-24 20:38 ` Kees Cook 2021-02-24 20:54 ` Sami Tolvanen 2021-02-24 22:28 ` Guenter Roeck 0 siblings, 2 replies; 6+ messages in thread From: Kees Cook @ 2021-02-24 20:38 UTC (permalink / raw) To: Guenter Roeck Cc: Sami Tolvanen, Masahiro Yamada, Steven Rostedt, Will Deacon, Josh Poimboeuf, Peter Zijlstra, Greg Kroah-Hartman, Paul E. McKenney, Nick Desaulniers, clang-built-linux, kernel-hardening, linux-arch, linux-arm-kernel, linux-kbuild, linux-kernel, linux-pci, linux-parisc, Helge Deller On Wed, Feb 24, 2021 at 12:17:23PM -0800, Guenter Roeck wrote: > On Fri, Dec 11, 2020 at 10:46:18AM -0800, Sami Tolvanen wrote: > > Move function tracer options to Kconfig to make it easier to add > > new methods for generating __mcount_loc, and to make the options > > available also when building kernel modules. > > > > Note that FTRACE_MCOUNT_USE_* options are updated on rebuild and > > therefore, work even if the .config was generated in a different > > environment. > > > > Signed-off-by: Sami Tolvanen <samitolvanen@google.com> > > Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org> > > With this patch in place, parisc:allmodconfig no longer builds. > > Error log: > Arch parisc is not supported with CONFIG_FTRACE_MCOUNT_RECORD at scripts/recordmcount.pl line 405. > make[2]: *** [scripts/mod/empty.o] Error 2 > > Due to this problem, CONFIG_FTRACE_MCOUNT_RECORD can no longer be > enabled in parisc builds. Since that is auto-selected by DYNAMIC_FTRACE, > DYNAMIC_FTRACE can no longer be enabled, and with it everything that > depends on it. Ew. Any idea why this didn't show up while it was in linux-next? -- Kees Cook ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v9 01/16] tracing: move function tracer options to Kconfig (causing parisc build failures) 2021-02-24 20:38 ` Kees Cook @ 2021-02-24 20:54 ` Sami Tolvanen 2021-02-24 22:29 ` Guenter Roeck 2021-02-24 22:28 ` Guenter Roeck 1 sibling, 1 reply; 6+ messages in thread From: Sami Tolvanen @ 2021-02-24 20:54 UTC (permalink / raw) To: Kees Cook Cc: Guenter Roeck, Masahiro Yamada, Steven Rostedt, Will Deacon, Josh Poimboeuf, Peter Zijlstra, Greg Kroah-Hartman, Paul E. McKenney, Nick Desaulniers, clang-built-linux, Kernel Hardening, linux-arch, linux-arm-kernel, linux-kbuild, LKML, PCI, linux-parisc, Helge Deller On Wed, Feb 24, 2021 at 12:38 PM Kees Cook <keescook@chromium.org> wrote: > > On Wed, Feb 24, 2021 at 12:17:23PM -0800, Guenter Roeck wrote: > > On Fri, Dec 11, 2020 at 10:46:18AM -0800, Sami Tolvanen wrote: > > > Move function tracer options to Kconfig to make it easier to add > > > new methods for generating __mcount_loc, and to make the options > > > available also when building kernel modules. > > > > > > Note that FTRACE_MCOUNT_USE_* options are updated on rebuild and > > > therefore, work even if the .config was generated in a different > > > environment. > > > > > > Signed-off-by: Sami Tolvanen <samitolvanen@google.com> > > > Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org> > > > > With this patch in place, parisc:allmodconfig no longer builds. > > > > Error log: > > Arch parisc is not supported with CONFIG_FTRACE_MCOUNT_RECORD at scripts/recordmcount.pl line 405. > > make[2]: *** [scripts/mod/empty.o] Error 2 > > > > Due to this problem, CONFIG_FTRACE_MCOUNT_RECORD can no longer be > > enabled in parisc builds. Since that is auto-selected by DYNAMIC_FTRACE, > > DYNAMIC_FTRACE can no longer be enabled, and with it everything that > > depends on it. > > Ew. Any idea why this didn't show up while it was in linux-next? Does anyone build parisc allmodconfig from -next? parisc seems to always use -fpatchable-function-entry with dynamic ftrace, so we just need to select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY to stop it from defaulting to recordmcount: diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig index ecef9aff9d72..9ee806f68123 100644 --- a/arch/parisc/Kconfig +++ b/arch/parisc/Kconfig @@ -60,6 +60,7 @@ config PARISC select HAVE_KPROBES select HAVE_KRETPROBES select HAVE_DYNAMIC_FTRACE if $(cc-option,-fpatchable-function-entry=1,1) + select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY if HAVE_DYNAMIC_FTRACE select HAVE_FTRACE_MCOUNT_RECORD if HAVE_DYNAMIC_FTRACE select HAVE_KPROBES_ON_FTRACE select HAVE_DYNAMIC_FTRACE_WITH_REGS I'll send a proper patch shortly. Sami ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v9 01/16] tracing: move function tracer options to Kconfig (causing parisc build failures) 2021-02-24 20:54 ` Sami Tolvanen @ 2021-02-24 22:29 ` Guenter Roeck 0 siblings, 0 replies; 6+ messages in thread From: Guenter Roeck @ 2021-02-24 22:29 UTC (permalink / raw) To: Sami Tolvanen Cc: Kees Cook, Masahiro Yamada, Steven Rostedt, Will Deacon, Josh Poimboeuf, Peter Zijlstra, Greg Kroah-Hartman, Paul E. McKenney, Nick Desaulniers, clang-built-linux, Kernel Hardening, linux-arch, linux-arm-kernel, linux-kbuild, LKML, PCI, linux-parisc, Helge Deller On Wed, Feb 24, 2021 at 12:54:15PM -0800, Sami Tolvanen wrote: > On Wed, Feb 24, 2021 at 12:38 PM Kees Cook <keescook@chromium.org> wrote: > > > > On Wed, Feb 24, 2021 at 12:17:23PM -0800, Guenter Roeck wrote: > > > On Fri, Dec 11, 2020 at 10:46:18AM -0800, Sami Tolvanen wrote: > > > > Move function tracer options to Kconfig to make it easier to add > > > > new methods for generating __mcount_loc, and to make the options > > > > available also when building kernel modules. > > > > > > > > Note that FTRACE_MCOUNT_USE_* options are updated on rebuild and > > > > therefore, work even if the .config was generated in a different > > > > environment. > > > > > > > > Signed-off-by: Sami Tolvanen <samitolvanen@google.com> > > > > Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org> > > > > > > With this patch in place, parisc:allmodconfig no longer builds. > > > > > > Error log: > > > Arch parisc is not supported with CONFIG_FTRACE_MCOUNT_RECORD at scripts/recordmcount.pl line 405. > > > make[2]: *** [scripts/mod/empty.o] Error 2 > > > > > > Due to this problem, CONFIG_FTRACE_MCOUNT_RECORD can no longer be > > > enabled in parisc builds. Since that is auto-selected by DYNAMIC_FTRACE, > > > DYNAMIC_FTRACE can no longer be enabled, and with it everything that > > > depends on it. > > > > Ew. Any idea why this didn't show up while it was in linux-next? > > Does anyone build parisc allmodconfig from -next? > https://kerneltests.org/builders/next-parisc-next Guenter > parisc seems to always use -fpatchable-function-entry with dynamic > ftrace, so we just need to select > FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY to stop it from defaulting > to recordmcount: > > diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig > index ecef9aff9d72..9ee806f68123 100644 > --- a/arch/parisc/Kconfig > +++ b/arch/parisc/Kconfig > @@ -60,6 +60,7 @@ config PARISC > select HAVE_KPROBES > select HAVE_KRETPROBES > select HAVE_DYNAMIC_FTRACE if > $(cc-option,-fpatchable-function-entry=1,1) > + select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY if HAVE_DYNAMIC_FTRACE > select HAVE_FTRACE_MCOUNT_RECORD if HAVE_DYNAMIC_FTRACE > select HAVE_KPROBES_ON_FTRACE > select HAVE_DYNAMIC_FTRACE_WITH_REGS > > I'll send a proper patch shortly. > > Sami ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v9 01/16] tracing: move function tracer options to Kconfig (causing parisc build failures) 2021-02-24 20:38 ` Kees Cook 2021-02-24 20:54 ` Sami Tolvanen @ 2021-02-24 22:28 ` Guenter Roeck 2021-02-24 22:42 ` Kees Cook 1 sibling, 1 reply; 6+ messages in thread From: Guenter Roeck @ 2021-02-24 22:28 UTC (permalink / raw) To: Kees Cook Cc: Sami Tolvanen, Masahiro Yamada, Steven Rostedt, Will Deacon, Josh Poimboeuf, Peter Zijlstra, Greg Kroah-Hartman, Paul E. McKenney, Nick Desaulniers, clang-built-linux, kernel-hardening, linux-arch, linux-arm-kernel, linux-kbuild, linux-kernel, linux-pci, linux-parisc, Helge Deller On Wed, Feb 24, 2021 at 12:38:54PM -0800, Kees Cook wrote: > On Wed, Feb 24, 2021 at 12:17:23PM -0800, Guenter Roeck wrote: > > On Fri, Dec 11, 2020 at 10:46:18AM -0800, Sami Tolvanen wrote: > > > Move function tracer options to Kconfig to make it easier to add > > > new methods for generating __mcount_loc, and to make the options > > > available also when building kernel modules. > > > > > > Note that FTRACE_MCOUNT_USE_* options are updated on rebuild and > > > therefore, work even if the .config was generated in a different > > > environment. > > > > > > Signed-off-by: Sami Tolvanen <samitolvanen@google.com> > > > Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org> > > > > With this patch in place, parisc:allmodconfig no longer builds. > > > > Error log: > > Arch parisc is not supported with CONFIG_FTRACE_MCOUNT_RECORD at scripts/recordmcount.pl line 405. > > make[2]: *** [scripts/mod/empty.o] Error 2 > > > > Due to this problem, CONFIG_FTRACE_MCOUNT_RECORD can no longer be > > enabled in parisc builds. Since that is auto-selected by DYNAMIC_FTRACE, > > DYNAMIC_FTRACE can no longer be enabled, and with it everything that > > depends on it. > > Ew. Any idea why this didn't show up while it was in linux-next? > It did, I just wasn't able to bisect it there. Guenter ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v9 01/16] tracing: move function tracer options to Kconfig (causing parisc build failures) 2021-02-24 22:28 ` Guenter Roeck @ 2021-02-24 22:42 ` Kees Cook 0 siblings, 0 replies; 6+ messages in thread From: Kees Cook @ 2021-02-24 22:42 UTC (permalink / raw) To: Guenter Roeck Cc: Sami Tolvanen, Masahiro Yamada, Steven Rostedt, Will Deacon, Josh Poimboeuf, Peter Zijlstra, Greg Kroah-Hartman, Paul E. McKenney, Nick Desaulniers, clang-built-linux, kernel-hardening, linux-arch, linux-arm-kernel, linux-kbuild, linux-kernel, linux-pci, linux-parisc, Helge Deller On Wed, Feb 24, 2021 at 02:28:07PM -0800, Guenter Roeck wrote: > On Wed, Feb 24, 2021 at 12:38:54PM -0800, Kees Cook wrote: > > On Wed, Feb 24, 2021 at 12:17:23PM -0800, Guenter Roeck wrote: > > > On Fri, Dec 11, 2020 at 10:46:18AM -0800, Sami Tolvanen wrote: > > > > Move function tracer options to Kconfig to make it easier to add > > > > new methods for generating __mcount_loc, and to make the options > > > > available also when building kernel modules. > > > > > > > > Note that FTRACE_MCOUNT_USE_* options are updated on rebuild and > > > > therefore, work even if the .config was generated in a different > > > > environment. > > > > > > > > Signed-off-by: Sami Tolvanen <samitolvanen@google.com> > > > > Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org> > > > > > > With this patch in place, parisc:allmodconfig no longer builds. > > > > > > Error log: > > > Arch parisc is not supported with CONFIG_FTRACE_MCOUNT_RECORD at scripts/recordmcount.pl line 405. > > > make[2]: *** [scripts/mod/empty.o] Error 2 > > > > > > Due to this problem, CONFIG_FTRACE_MCOUNT_RECORD can no longer be > > > enabled in parisc builds. Since that is auto-selected by DYNAMIC_FTRACE, > > > DYNAMIC_FTRACE can no longer be enabled, and with it everything that > > > depends on it. > > > > Ew. Any idea why this didn't show up while it was in linux-next? > > > > It did, I just wasn't able to bisect it there. Ah-ha! Okay, thanks. Sorry it's been broken for so long! I've added parisc to my local cross builder now. -- Kees Cook ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-24 22:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20201211184633.3213045-1-samitolvanen@google.com>
[not found] ` <20201211184633.3213045-2-samitolvanen@google.com>
2021-02-24 20:17 ` [PATCH v9 01/16] tracing: move function tracer options to Kconfig (causing parisc build failures) Guenter Roeck
2021-02-24 20:38 ` Kees Cook
2021-02-24 20:54 ` Sami Tolvanen
2021-02-24 22:29 ` Guenter Roeck
2021-02-24 22:28 ` Guenter Roeck
2021-02-24 22:42 ` Kees Cook
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox