From: Kees Cook <keescook@chromium.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ard Biesheuvel <ardb@kernel.org>, Helge Deller <deller@gmx.de>,
linux-parisc <linux-parisc@vger.kernel.org>
Subject: Re: parisc build failures in mainline kernel
Date: Fri, 5 Nov 2021 12:43:00 -0700 [thread overview]
Message-ID: <202111051242.86E9DBF@keescook> (raw)
In-Reply-To: <CAHk-=wjZo3yj46FwVi0BNKfy5fZ4-UeWkeQ6nhcAbbnKS7K=dQ@mail.gmail.com>
On Wed, Nov 03, 2021 at 09:45:47PM -0700, Linus Torvalds wrote:
> On Wed, Nov 3, 2021 at 9:30 PM Guenter Roeck <linux@roeck-us.net> wrote:
> >
> > Unfortunately not. With that patch it complains about task_struct.
>
> Gaah. You'll need something like this too
>
> - DEFINE(TASK_CPU, offsetof(struct task_struct, cpu));
> + DEFINE(TASK_CPU, offsetof(struct task_struct, thread_info.cpu));
>
> in arch/parisc/kernel/asm-offsets.c.
>
> And really, it should probably be renamed as TASK_TI_CPU, but then you
> have to rename all the uses too.
>
> There might be other details like that lurking.
I'll check this out too if Ard doesn't beat me to it. Thanks for the
investigation and sorry for the breakage!
--
Kees Cook
next prev parent reply other threads:[~2021-11-05 19:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 3:15 parisc build failures in mainline kernel Guenter Roeck
2021-11-04 4:18 ` Linus Torvalds
2021-11-04 4:30 ` Guenter Roeck
2021-11-04 4:45 ` Linus Torvalds
2021-11-05 19:43 ` Kees Cook [this message]
2021-11-05 19:43 ` Ard Biesheuvel
2021-11-05 19:55 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202111051242.86E9DBF@keescook \
--to=keescook@chromium.org \
--cc=ardb@kernel.org \
--cc=deller@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox