From: Kees Cook <keescook@chromium.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Helge Deller <deller@gmx.de>,
linux-parisc <linux-parisc@vger.kernel.org>
Subject: Re: parisc build failures in mainline kernel
Date: Fri, 5 Nov 2021 12:55:15 -0700 [thread overview]
Message-ID: <202111051254.1AAE34273@keescook> (raw)
In-Reply-To: <CAMj1kXGhHGD047BzXC3m9afW+9x_UBj1jgDdC+i2GLqHbrj-Fg@mail.gmail.com>
On Fri, Nov 05, 2021 at 08:43:52PM +0100, Ard Biesheuvel wrote:
> On Fri, 5 Nov 2021 at 20:43, Kees Cook <keescook@chromium.org> wrote:
> >
> > On Wed, Nov 03, 2021 at 09:45:47PM -0700, Linus Torvalds wrote:
> > > On Wed, Nov 3, 2021 at 9:30 PM Guenter Roeck <linux@roeck-us.net> wrote:
> > > >
> > > > Unfortunately not. With that patch it complains about task_struct.
> > >
> > > Gaah. You'll need something like this too
> > >
> > > - DEFINE(TASK_CPU, offsetof(struct task_struct, cpu));
> > > + DEFINE(TASK_CPU, offsetof(struct task_struct, thread_info.cpu));
> > >
> > > in arch/parisc/kernel/asm-offsets.c.
> > >
> > > And really, it should probably be renamed as TASK_TI_CPU, but then you
> > > have to rename all the uses too.
> > >
> > > There might be other details like that lurking.
> >
> > I'll check this out too if Ard doesn't beat me to it. Thanks for the
> > investigation and sorry for the breakage!
> >
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2a2e8202c7a16a85a881ad2b6e32ccbebdc01dda
Heh. Ard did, in fact, beat me to it. Thank you! :)
-Kees
--
Kees Cook
prev parent reply other threads:[~2021-11-05 19:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 3:15 parisc build failures in mainline kernel Guenter Roeck
2021-11-04 4:18 ` Linus Torvalds
2021-11-04 4:30 ` Guenter Roeck
2021-11-04 4:45 ` Linus Torvalds
2021-11-05 19:43 ` Kees Cook
2021-11-05 19:43 ` Ard Biesheuvel
2021-11-05 19:55 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202111051254.1AAE34273@keescook \
--to=keescook@chromium.org \
--cc=ardb@kernel.org \
--cc=deller@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox