* [PATCH 1/2] staging: qlge: Update TODO
2023-10-20 12:44 [PATCH 0/2] staging: qlge: Remove qlge Benjamin Poirier
@ 2023-10-20 12:44 ` Benjamin Poirier
2023-10-21 0:07 ` [PATCH 0/2] staging: qlge: Remove qlge Jakub Kicinski
2023-10-21 9:53 ` Greg Kroah-Hartman
2 siblings, 0 replies; 4+ messages in thread
From: Benjamin Poirier @ 2023-10-20 12:44 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Jonathan Corbet, James E.J. Bottomley, Helge Deller, Ian Kent,
Sven Joachim, Nandha Kumar Singaram, Sumitra Sharma,
Ricardo Lopes, Dan Carpenter, netdev, linux-doc, linux-kernel,
linux-parisc, linux-staging, Manish Chopra, Coiby Xu
Update TODO file to reflect the changes that have been done:
* multiple functions were renamed to have the "qlge_" prefix in commit
f8c047be5401 ("staging: qlge: use qlge_* prefix to avoid namespace
clashes with other qlogic drivers")
* a redundant memset() was removed in commit 953b94009377 ("staging: qlge:
Initialize devlink health dump framework")
* the loop boundary in ql(ge)_alloc_rx_buffers() was updated in commit
e4c911a73c89 ("staging: qlge: Remove rx_ring.type")
* pci_enable_msi() was replaced in commit 4eab532dca76 ("staging:
qlge/qlge_main.c: Replace depracated MSI API.")
* pci_dma_* were replaced in commit e955a071b9b3 ("staging: qlge: replace
deprecated apis pci_dma_*")
* the while loops were rewritten in commit 41e1bf811ace ("Staging: qlge:
Rewrite two while loops as simple for loops")
* indentation was fixed in commit 0eb79fd1e911 ("staging: qlge: cleanup
indent in qlge_main.c")
I also slipped in one new TODO item, naughty me!
Signed-off-by: Benjamin Poirier <benjamin.poirier@gmail.com>
---
drivers/staging/qlge/TODO | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/qlge/TODO b/drivers/staging/qlge/TODO
index c76394b9451b..7e277407033e 100644
--- a/drivers/staging/qlge/TODO
+++ b/drivers/staging/qlge/TODO
@@ -1,7 +1,7 @@
* commit 7c734359d350 ("qlge: Size RX buffers based on MTU.", v2.6.33-rc1)
introduced dead code in the receive routines, which should be rewritten
anyways by the admission of the author himself, see the comment above
- ql_build_rx_skb(). That function is now used exclusively to handle packets
+ qlge_build_rx_skb(). That function is now used exclusively to handle packets
that underwent header splitting but it still contains code to handle non
split cases.
* truesize accounting is incorrect (ex: a 9000B frame has skb->truesize 10280
@@ -17,17 +17,12 @@
* the flow control implementation in firmware is buggy (sends a flood of pause
frames, resets the link, device and driver buffer queues become
desynchronized), disable it by default
-* some structures are initialized redundantly (ex. memset 0 after
- alloc_etherdev())
* the driver has a habit of using runtime checks where compile time checks are
- possible (ex. ql_free_rx_buffers(), ql_alloc_rx_buffers())
+ possible (ex. qlge_free_rx_buffers())
* reorder struct members to avoid holes if it doesn't impact performance
-* avoid legacy/deprecated apis (ex. replace pci_dma_*, replace pci_enable_msi,
- use pci_iomap)
-* some "while" loops could be rewritten with simple "for", ex.
- ql_wait_reg_rdy(), ql_start_rx_ring())
+* use better-suited apis (ex. use pci_iomap() instead of ioremap())
* remove duplicate and useless comments
-* fix weird line wrapping (all over, ex. the ql_set_routing_reg() calls in
+* fix weird line wrapping (all over, ex. the qlge_set_routing_reg() calls in
qlge_set_multicast_list()).
-* fix weird indentation (all over, ex. the for loops in qlge_get_stats())
+* remove useless casts (ex. memset((void *)mac_iocb_ptr, ...))
* fix checkpatch issues
--
2.42.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 0/2] staging: qlge: Remove qlge
2023-10-20 12:44 [PATCH 0/2] staging: qlge: Remove qlge Benjamin Poirier
2023-10-20 12:44 ` [PATCH 1/2] staging: qlge: Update TODO Benjamin Poirier
@ 2023-10-21 0:07 ` Jakub Kicinski
2023-10-21 9:53 ` Greg Kroah-Hartman
2 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2023-10-21 0:07 UTC (permalink / raw)
To: Benjamin Poirier
Cc: Greg Kroah-Hartman, David S. Miller, Eric Dumazet, Paolo Abeni,
Jonathan Corbet, James E.J. Bottomley, Helge Deller, Ian Kent,
Sven Joachim, Nandha Kumar Singaram, Sumitra Sharma,
Ricardo Lopes, Dan Carpenter, netdev, linux-doc, linux-kernel,
linux-parisc, linux-staging, Manish Chopra, Coiby Xu
On Fri, 20 Oct 2023 08:44:55 -0400 Benjamin Poirier wrote:
> Remove the qlge driver from staging. The TODO file is first updated to
> reflect the current status, in case the removal is later reverted.
Acked-by: Jakub Kicinski <kuba@kernel.org>
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] staging: qlge: Remove qlge
2023-10-20 12:44 [PATCH 0/2] staging: qlge: Remove qlge Benjamin Poirier
2023-10-20 12:44 ` [PATCH 1/2] staging: qlge: Update TODO Benjamin Poirier
2023-10-21 0:07 ` [PATCH 0/2] staging: qlge: Remove qlge Jakub Kicinski
@ 2023-10-21 9:53 ` Greg Kroah-Hartman
2 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2023-10-21 9:53 UTC (permalink / raw)
To: Benjamin Poirier
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Jonathan Corbet, James E.J. Bottomley, Helge Deller, Ian Kent,
Sven Joachim, Nandha Kumar Singaram, Sumitra Sharma,
Ricardo Lopes, Dan Carpenter, netdev, linux-doc, linux-kernel,
linux-parisc, linux-staging, Manish Chopra, Coiby Xu
On Fri, Oct 20, 2023 at 08:44:55AM -0400, Benjamin Poirier wrote:
> Remove the qlge driver from staging. The TODO file is first updated to
> reflect the current status, in case the removal is later reverted.
Thanks for this, now applied!
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread