Re: [patch 05/16] frv: use generic pci_enable

Linux PARISC architecture development
 help / color / mirror / Atom feed

* Re: [patch 05/16] frv: use generic pci_enable_resources()
       [not found] ` <20080304185820.723623873@ldl.fc.hp.com>
@ 2008-03-05 14:52   ` David Howells
  2008-03-05 20:14     ` Greg KH
  0 siblings, 1 reply; 8+ messages in thread
From: David Howells @ 2008-03-05 14:52 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: linux-arch, Chris Zankel, Grant Grundler, linux-parisc,
	Matthew Wilcox, Kyle McMartin, linuxppc-dev, Paul Mackerras,
	linux-pci, linux-arm-kernel, Russell King


Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:

> Use the generic pci_enable_resources() instead of the arch-specific code.
> 
> Unlike this arch-specific code, the generic version:
>     - checks PCI_NUM_RESOURCES (11), not 6, resources
>     - skips resources that have neither IORESOURCE_IO nor IORESOURCE_MEM set
>     - skips ROM resources unless IORESOURCE_ROM_ENABLE is set
>     - checks for resource collisions with "!r->parent"
> 
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>

Acked-by: David Howells <dhowells@redhat.com>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [patch 05/16] frv: use generic pci_enable_resources()
  2008-03-05 14:52   ` [patch 05/16] frv: use generic pci_enable_resources() David Howells
@ 2008-03-05 20:14     ` Greg KH
  0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2008-03-05 20:14 UTC (permalink / raw)
  To: David Howells
  Cc: Bjorn Helgaas, Russell King, linux-arm-kernel, Kyle McMartin,
	Matthew Wilcox, Grant Grundler, linux-parisc, Paul Mackerras,
	Benjamin Herrenschmidt, linuxppc-dev, Chris Zankel, linux-pci,
	linux-arch

On Wed, Mar 05, 2008 at 02:52:46PM +0000, David Howells wrote:
> 
> Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
> 
> > Use the generic pci_enable_resources() instead of the arch-specific code.
> > 
> > Unlike this arch-specific code, the generic version:
> >     - checks PCI_NUM_RESOURCES (11), not 6, resources
> >     - skips resources that have neither IORESOURCE_IO nor IORESOURCE_MEM set
> >     - skips ROM resources unless IORESOURCE_ROM_ENABLE is set
> >     - checks for resource collisions with "!r->parent"
> > 
> > Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
> 
> Acked-by: David Howells <dhowells@redhat.com>

Added, thanks.

greg k-h

^ permalink raw reply	[flat|nested] 8+ messages in thread

[parent not found: <20080304185819.885549413@ldl.fc.hp.com>]

* Re: [patch 01/16] PCI: add generic pci_enable_resources()
       [not found] ` <20080304185819.885549413@ldl.fc.hp.com>
@ 2008-03-05 14:53   ` David Howells
  2008-03-05 20:14     ` Greg KH
  0 siblings, 1 reply; 8+ messages in thread
From: David Howells @ 2008-03-05 14:53 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: dhowells, Russell King, linux-arm-kernel, Kyle McMartin,
	Matthew Wilcox, Grant Grundler, linux-parisc, Paul Mackerras,
	Benjamin Herrenschmidt, linuxppc-dev, Chris Zankel, linux-pci,
	linux-arch


Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:

> Each architecture has its own pcibios_enable_resources() implementation.
> These differ in many minor ways that have nothing to do with actual
> architectural differences.  Follow-on patches will make most arches
> use this generic version instead.
> 
> This version is based on powerpc, which seemed most up-to-date.  The only
> functional difference from the x86 version is that this uses "!r->parent"
> to check for resource collisions instead of "!r->start && r->end".
> 
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>

Acked-by: David Howells <dhowells@redhat.com>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [patch 01/16] PCI: add generic pci_enable_resources()
  2008-03-05 14:53   ` [patch 01/16] PCI: add " David Howells
@ 2008-03-05 20:14     ` Greg KH
  0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2008-03-05 20:14 UTC (permalink / raw)
  To: David Howells
  Cc: Bjorn Helgaas, Russell King, linux-arm-kernel, Kyle McMartin,
	Matthew Wilcox, Grant Grundler, linux-parisc, Paul Mackerras,
	Benjamin Herrenschmidt, linuxppc-dev, Chris Zankel, linux-pci,
	linux-arch

On Wed, Mar 05, 2008 at 02:53:31PM +0000, David Howells wrote:
> 
> Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
> 
> > Each architecture has its own pcibios_enable_resources() implementation.
> > These differ in many minor ways that have nothing to do with actual
> > architectural differences.  Follow-on patches will make most arches
> > use this generic version instead.
> > 
> > This version is based on powerpc, which seemed most up-to-date.  The only
> > functional difference from the x86 version is that this uses "!r->parent"
> > to check for resource collisions instead of "!r->start && r->end".
> > 
> > Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
> 
> Acked-by: David Howells <dhowells@redhat.com>

added, thanks.

greg k-h

^ permalink raw reply	[flat|nested] 8+ messages in thread

[parent not found: <20080304185821.354198782@ldl.fc.hp.com>]

* Re: [patch 08/16] mn10300: use generic pci_enable_resources()
       [not found] ` <20080304185821.354198782@ldl.fc.hp.com>
@ 2008-03-05 15:13   ` David Howells
       [not found]     ` <28205.1204729990-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
  0 siblings, 1 reply; 8+ messages in thread
From: David Howells @ 2008-03-05 15:13 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: linux-arch, Chris Zankel, Grant Grundler, linux-parisc,
	Matthew Wilcox, Kyle McMartin, linuxppc-dev, Paul Mackerras,
	linux-pci, linux-arm-kernel, Russell King


Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:

> Use the generic pci_enable_resources() instead of the arch-specific code.
> 
> Unlike this arch-specific code, the generic version:
>     - checks PCI_NUM_RESOURCES (11), not 6, resources
>     - skips resources that have neither IORESOURCE_IO nor IORESOURCE_MEM set
>     - skips ROM resources unless IORESOURCE_ROM_ENABLE is set
>     - checks for resource collisions with "!r->parent"
> 
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>

Acked-by: David Howells <dhowells@redhat.com>

^ permalink raw reply	[flat|nested] 8+ messages in thread

[parent not found: <28205.1204729990-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

* Re: [patch 08/16] mn10300: use generic pci_enable_resources()
       [not found]     ` <28205.1204729990-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
@ 2008-03-05 20:15       ` Greg KH
  0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2008-03-05 20:15 UTC (permalink / raw)
  To: David Howells
  Cc: Bjorn Helgaas, Russell King,
	linux-arm-kernel-xIg/pKzrS19vn6HldHNs0ANdhmdF6hFW, Kyle McMartin,
	Matthew Wilcox, Grant Grundler,
	linux-parisc-u79uwXL29TY76Z2rM5mHXA, Paul Mackerras,
	Benjamin Herrenschmidt, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A,
	Chris Zankel, linux-pci-jyMamyUUXNJG4ohzP4jBZS1Fcj925eT/,
	linux-arch-u79uwXL29TY76Z2rM5mHXA

On Wed, Mar 05, 2008 at 03:13:10PM +0000, David Howells wrote:
> 
> Bjorn Helgaas <bjorn.helgaas-VXdhtT5mjnY@public.gmane.org> wrote:
> 
> > Use the generic pci_enable_resources() instead of the arch-specific code.
> > 
> > Unlike this arch-specific code, the generic version:
> >     - checks PCI_NUM_RESOURCES (11), not 6, resources
> >     - skips resources that have neither IORESOURCE_IO nor IORESOURCE_MEM set
> >     - skips ROM resources unless IORESOURCE_ROM_ENABLE is set
> >     - checks for resource collisions with "!r->parent"
> > 
> > Signed-off-by: Bjorn Helgaas <bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
> 
> Acked-by: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

added, thanks.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 8+ messages in thread

[parent not found: <20080304185821.554040328@ldl.fc.hp.com>]

[parent not found: <20080304185821.554040328-e+Ta4ugHZmL3oGB3hsPCZA@public.gmane.org>]

* Re: [patch 09/16] parisc: use generic pci_enable_resources()
       [not found]   ` <20080304185821.554040328-e+Ta4ugHZmL3oGB3hsPCZA@public.gmane.org>
@ 2008-03-05 16:17     ` Kyle McMartin
       [not found]       ` <20080305161709.GA3354-EK4dZfYtfFRW/gs8oUvUg/d9D2ou9A/h@public.gmane.org>
  0 siblings, 1 reply; 8+ messages in thread
From: Kyle McMartin @ 2008-03-05 16:17 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: linux-pci-jyMamyUUXNJG4ohzP4jBZS1Fcj925eT/,
	linux-arch-u79uwXL29TY76Z2rM5mHXA, Russell King, Kyle McMartin,
	Matthew Wilcox, Grant Grundler,
	linux-parisc-u79uwXL29TY76Z2rM5mHXA, Paul Mackerras,
	Benjamin Herrenschmidt, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A,
	Chris Zankel

On Tue, Mar 04, 2008 at 11:56:55AM -0700, Bjorn Helgaas wrote:
> Use the generic pci_enable_resources() instead of the arch-specific code.
> 
> Unlike this arch-specific code, the generic version:
>     - checks PCI_NUM_RESOURCES (11), not DEVICE_COUNT_RESOURCE (12), resources
>     - skips resources that have neither IORESOURCE_IO nor IORESOURCE_MEM set
>     - skips ROM resources unless IORESOURCE_ROM_ENABLE is set
>     - checks for resource collisions with "!r->parent"
> 
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
> 

Acked-by: Kyle McMartin <kyle-pfcGkIkfWfAsA/PxXw9srA@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 8+ messages in thread

[parent not found: <20080305161709.GA3354-EK4dZfYtfFRW/gs8oUvUg/d9D2ou9A/h@public.gmane.org>]

* Re: [patch 09/16] parisc: use generic pci_enable_resources()
       [not found]       ` <20080305161709.GA3354-EK4dZfYtfFRW/gs8oUvUg/d9D2ou9A/h@public.gmane.org>
@ 2008-03-05 20:09         ` Greg KH
  0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2008-03-05 20:09 UTC (permalink / raw)
  To: Kyle McMartin
  Cc: Bjorn Helgaas, linux-pci-jyMamyUUXNJG4ohzP4jBZS1Fcj925eT/,
	linux-arch-u79uwXL29TY76Z2rM5mHXA, Russell King, Kyle McMartin,
	Matthew Wilcox, Grant Grundler,
	linux-parisc-u79uwXL29TY76Z2rM5mHXA, Paul Mackerras,
	Benjamin Herrenschmidt, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A,
	Chris Zankel

On Wed, Mar 05, 2008 at 11:17:10AM -0500, Kyle McMartin wrote:
> On Tue, Mar 04, 2008 at 11:56:55AM -0700, Bjorn Helgaas wrote:
> > Use the generic pci_enable_resources() instead of the arch-specific code.
> > 
> > Unlike this arch-specific code, the generic version:
> >     - checks PCI_NUM_RESOURCES (11), not DEVICE_COUNT_RESOURCE (12), resources
> >     - skips resources that have neither IORESOURCE_IO nor IORESOURCE_MEM set
> >     - skips ROM resources unless IORESOURCE_ROM_ENABLE is set
> >     - checks for resource collisions with "!r->parent"
> > 
> > Signed-off-by: Bjorn Helgaas <bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
> > 
> 
> Acked-by: Kyle McMartin <kyle-pfcGkIkfWfAsA/PxXw9srA@public.gmane.org>

added, thanks.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2008-03-05 20:15 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20080304185646.864917286@ldl.fc.hp.com>
     [not found] ` <20080304185820.723623873@ldl.fc.hp.com>
2008-03-05 14:52   ` [patch 05/16] frv: use generic pci_enable_resources() David Howells
2008-03-05 20:14     ` Greg KH
     [not found] ` <20080304185819.885549413@ldl.fc.hp.com>
2008-03-05 14:53   ` [patch 01/16] PCI: add " David Howells
2008-03-05 20:14     ` Greg KH
     [not found] ` <20080304185821.354198782@ldl.fc.hp.com>
2008-03-05 15:13   ` [patch 08/16] mn10300: use " David Howells
     [not found]     ` <28205.1204729990-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-03-05 20:15       ` Greg KH
     [not found] ` <20080304185821.554040328@ldl.fc.hp.com>
     [not found]   ` <20080304185821.554040328-e+Ta4ugHZmL3oGB3hsPCZA@public.gmane.org>
2008-03-05 16:17     ` [patch 09/16] parisc: " Kyle McMartin
     [not found]       ` <20080305161709.GA3354-EK4dZfYtfFRW/gs8oUvUg/d9D2ou9A/h@public.gmane.org>
2008-03-05 20:09         ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox