[PATCH] parisc: sba_iommu: Remove dead DEBUG_DMB_TRAP code

[PATCH] parisc: sba_iommu: Remove dead DEBUG_DMB_TRAP code

[Muhammad Usama Anjum]

DEBUG_DMB_TRAP is unconditionally undefined, so the guarded
declarations and calls can never be built. The declared iterate_pages()
and set_data_memory_break() functions also have no definitions in the
tree; removing the #undef would therefore leave unresolved references.

Remove the unused option and its guarded code.

Signed-off-by: Muhammad Usama Anjum <usama.anjum@arm.com>
---
 drivers/parisc/sba_iommu.c | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/drivers/parisc/sba_iommu.c b/drivers/parisc/sba_iommu.c
index d9339dd508262..e0a148ab5876c 100644
--- a/drivers/parisc/sba_iommu.c
+++ b/drivers/parisc/sba_iommu.c
@@ -66,7 +66,6 @@
 #undef DEBUG_SBA_RESOURCE
 #undef ASSERT_PDIR_SANITY
 #undef DEBUG_LARGE_SG_ENTRIES
-#undef DEBUG_DMB_TRAP
 
 #ifdef DEBUG_SBA_INIT
 #define DBG_INIT(x...)	printk(x)
@@ -1695,12 +1694,6 @@ sba_common_init(struct sba_device *sba_dev)
 
 	for(i=0; i< sba_dev->num_ioc; i++) {
 		int res_size;
-#ifdef DEBUG_DMB_TRAP
-		extern void iterate_pages(unsigned long , unsigned long ,
-					  void (*)(pte_t * , unsigned long),
-					  unsigned long );
-		void set_data_memory_break(pte_t * , unsigned long);
-#endif
 		/* resource map size dictated by pdir_size */
 		res_size = sba_dev->ioc[i].pdir_size/sizeof(u64); /* entries */
 
@@ -1715,12 +1708,6 @@ sba_common_init(struct sba_device *sba_dev)
 
 		sba_dev->ioc[i].res_size = res_size;
 		sba_dev->ioc[i].res_map = (char *) __get_free_pages(GFP_KERNEL, get_order(res_size));
-
-#ifdef DEBUG_DMB_TRAP
-		iterate_pages( sba_dev->ioc[i].res_map, res_size,
-				set_data_memory_break, 0);
-#endif
-
 		if (NULL == sba_dev->ioc[i].res_map)
 		{
 			panic("%s:%s() could not allocate resource map\n",
@@ -1752,14 +1739,6 @@ sba_common_init(struct sba_device *sba_dev)
 				*p_start++ = -1;
 				
 		}
-
-#ifdef DEBUG_DMB_TRAP
-		iterate_pages( sba_dev->ioc[i].res_map, res_size,
-				set_data_memory_break, 0);
-		iterate_pages( sba_dev->ioc[i].pdir_base, sba_dev->ioc[i].pdir_size,
-				set_data_memory_break, 0);
-#endif
-
 		DBG_INIT("%s() %d res_map %x %p\n",
 			__func__, i, res_size, sba_dev->ioc[i].res_map);
 	}
-- 
2.47.3

Re: [PATCH] parisc: sba_iommu: Remove dead DEBUG_DMB_TRAP code

[Helge Deller]

On 7/30/26 11:45, Muhammad Usama Anjum wrote:
> DEBUG_DMB_TRAP is unconditionally undefined, so the guarded
> declarations and calls can never be built. The declared iterate_pages()
> and set_data_memory_break() functions also have no definitions in the
> tree; removing the #undef would therefore leave unresolved references.
> 
> Remove the unused option and its guarded code.
> 
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@arm.com>
> ---
>   drivers/parisc/sba_iommu.c | 21 ---------------------
>   1 file changed, 21 deletions(-)
applied.
Thanks!
Helge