Re: [PATCH] parisc: fix serial ports on C8000 workstation

[Rolf Eike Beer <eike-kernel@sf-tec.de>]

[-- Attachment #1: Type: text/plain, Size: 1644 bytes --]

Helge Deller wrote:
> From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> 
> The C8000 workstation (64 bit kernel only) has a somewhat different
> serial port configuration that other models.
> Thonmas Bogendoerfers sent a patch to fix this in September 2010, which
> was now minimally modified by me.

Cool, that explains why it doesn't work for me. And it saves me the time to 
debug what _I_ did wrong ;)

> diff --git a/drivers/tty/serial/8250/8250_gsc.c
> b/drivers/tty/serial/8250/8250_gsc.c index 097dff9..bb91b47 100644
> --- a/drivers/tty/serial/8250/8250_gsc.c
> +++ b/drivers/tty/serial/8250/8250_gsc.c
> @@ -30,6 +30,12 @@ static int __init serial_init_chip(struct parisc_device
> *dev) unsigned long address;
>  	int err;
> 
> +#ifdef CONFIG_64BIT
> +	extern int iosapic_serial_irq(int cellnum);
> +	if (!dev->irq && (dev->id.sversion == 0xad))
> +		dev->irq = iosapic_serial_irq(dev->mod_index-1);
> +#endif
> +

Forward declaration in the middle of a function. Is this permitted? By 
standard and by coding style? Looks strange to me.

>  	if (!dev->irq) {
>  		/* We find some unattached serial ports by walking native
>  		 * busses.  These should be silently ignored.  Otherwise,
> @@ -51,7 +57,8 @@ static int __init serial_init_chip(struct parisc_device
> *dev) memset(&uart, 0, sizeof(uart));
>  	uart.port.iotype	= UPIO_MEM;
>  	/* 7.272727MHz on Lasi.  Assumed the same for Dino, Wax and Timi. */
> -	uart.port.uartclk	= 7272727;
> +	uart.port.uartclk	= (dev->id.sversion != 0xad) ?
> +					7272727 : 1843200;

If there is a nice comment explaining 72 another nice comment for the other 
number should be added.

Eike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]