From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Helge Deller <deller@gmx.de>, <linux-parisc@vger.kernel.org>,
James Bottomley <James.Bottomley@hansenpartnership.com>
Subject: Re: Re: [PATCH] parisc: fix serial ports on C8000 workstation
Date: Mon, 10 Jun 2013 12:43:36 +0200 [thread overview]
Message-ID: <ed2cc2a42ebd03a470c471a2f8a71a25@sf-mail.de> (raw)
In-Reply-To: <20130610100026.GA23862@alpha.franken.de>
Am 10.06.2013 12:00, schrieb Thomas Bogendoerfer:
> On Mon, Jun 10, 2013 at 10:27:09AM +0200, Helge Deller wrote:
>> Maybe you want to clean up the other parts, e.g. impmi or pci_mmap?
>
> ipmi is already cleaned up, but I didn't get any response from the
> maintainer.
>
> http://www.spinics.net/lists/linux-parisc/msg03191.html
parisc_registered should be a bool, and you don't reset it on
unregister_parisc_driver. If this can be compiled as module you get bad
effects (i.e. OOPS, crash ) on repeated modprobe/rmmod.
> info->irq = 0; /* no interrup */
There is a 't' missing at the end.
I would say resend the patch, it probably got lost.
Eike
prev parent reply other threads:[~2013-06-10 10:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-09 21:00 [PATCH] parisc: fix serial ports on C8000 workstation Helge Deller
2013-06-09 21:49 ` Rolf Eike Beer
2013-06-09 22:21 ` John David Anglin
2013-06-10 8:27 ` Aw: " Helge Deller
2013-06-10 10:00 ` Thomas Bogendoerfer
2013-06-10 10:43 ` Rolf Eike Beer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed2cc2a42ebd03a470c471a2f8a71a25@sf-mail.de \
--to=eike-kernel@sf-tec.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=deller@gmx.de \
--cc=linux-parisc@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox