[parisc-linux] __LP64__ / CONFIG_64BIT?

[parisc-linux] __LP64__ / CONFIG_64BIT?

[Joel Soete]

Hello *,

Could we move all #ifdef __LP64__ to CONFIG_64BIT?

TIA,
	Joel
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

Re: [parisc-linux] __LP64__ / CONFIG_64BIT?

[Kyle McMartin]

On Sun, Jan 15, 2006 at 07:18:16PM +0000, Joel Soete wrote:
> Hello *,
> 
> Could we move all #ifdef __LP64__ to CONFIG_64BIT?
>

Er, why? One of them is shorter to write, and makes the
same amount of sense... I have no particularly preference at any
rate. In fact, using __LP64__ might be preferable, as CONFIG_64BIT
requires us including <linux/config.h> which means any change
to the config will cause this file to be rebuilt whether or not
it is actually required. Then again, it's entirely possible
my understanding of this config crap is antiquated.

Cheers,
	Kyle 
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

Re: [parisc-linux] __LP64__ / CONFIG_64BIT?

[Matthew Wilcox]

On Mon, Jan 16, 2006 at 11:40:54AM -0500, Kyle McMartin wrote:
> Er, why? One of them is shorter to write, and makes the
> same amount of sense... I have no particularly preference at any
> rate. In fact, using __LP64__ might be preferable, as CONFIG_64BIT
> requires us including <linux/config.h> which means any change
> to the config will cause this file to be rebuilt whether or not
> it is actually required. Then again, it's entirely possible
> my understanding of this config crap is antiquated.

Doubly antiquated, I'm afraid.  Most recently, changes to the build
system mean that including <linux/config.h> is a no-op.  It's
automatically included for the files that need it.

The earlier antiquation happened many, many years ago, and it was
that the dependency writer (back in the days of 'make dep') treated
<linux/config.h> specially.  It scanned the file looking for CONFIG_*
symbols and added dependencies on the autobuilt include/config/ directory
(one file per config symbol).

I don't think we need to change from __LP64__ to CONFIG_64BIT overnight.
I think CONFIG_64IT has meaning to people from a non-HP environment, so
has slight clarity advantages.  If you're touching some code that uses
__LP64__, by all means do the conversion to CONFIG_64BIT, but don't do
it unnecessarily.
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

Re: [parisc-linux] __LP64__ / CONFIG_64BIT?

[Kyle McMartin]

On Mon, Jan 16, 2006 at 09:54:50AM -0700, Matthew Wilcox wrote:
> Doubly antiquated, I'm afraid.  Most recently, changes to the build
> system mean that including <linux/config.h> is a no-op.  It's
> automatically included for the files that need it.
> 
> The earlier antiquation happened many, many years ago, and it was
> that the dependency writer (back in the days of 'make dep') treated
> <linux/config.h> specially.  It scanned the file looking for CONFIG_*
> symbols and added dependencies on the autobuilt include/config/ directory
> (one file per config symbol).
>

Ok.
 
> I don't think we need to change from __LP64__ to CONFIG_64BIT overnight.
> I think CONFIG_64IT has meaning to people from a non-HP environment, so
> has slight clarity advantages.  If you're touching some code that uses
> __LP64__, by all means do the conversion to CONFIG_64BIT, but don't do
> it unnecessarily.
> 

Fair enough.
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux