[parisc-linux] [PATCH] alpha/parisc: Removing config variable DEBUG_RWLOCK

[parisc-linux] [PATCH] alpha/parisc: Removing config variable DEBUG_RWLOCK

[Jiri Olsa]

Removing config variable DEBUG_RWLOCK, since it is not used

Signed-off-by: Jiri Olsa <olsajiri@gmail.com>
---
 arch/alpha/Kconfig.debug           |    9 ---------
 arch/alpha/defconfig               |    1 -
 arch/parisc/Kconfig.debug          |    9 ---------
 arch/parisc/configs/a500_defconfig |    1 -
 4 files changed, 0 insertions(+), 20 deletions(-)

diff --git a/arch/alpha/Kconfig.debug b/arch/alpha/Kconfig.debug
index f45f28c..3f6265f 100644
--- a/arch/alpha/Kconfig.debug
+++ b/arch/alpha/Kconfig.debug
@@ -7,15 +7,6 @@ config EARLY_PRINTK
 	depends on ALPHA_GENERIC || ALPHA_SRM
 	default y
 
-config DEBUG_RWLOCK
-	bool "Read-write spinlock debugging"
-	depends on DEBUG_KERNEL
-	help
-	  If you say Y here then read-write lock processing will count how many
-	  times it has tried to get the lock and issue an error message after
-	  too many attempts.  If you suspect a rwlock problem or a kernel
-	  hacker asks for this option then say Y.  Otherwise say N.
-
 config ALPHA_LEGACY_START_ADDRESS
 	bool "Legacy kernel start address"
 	depends on ALPHA_GENERIC
diff --git a/arch/alpha/defconfig b/arch/alpha/defconfig
index 6da9c3d..e43f68f 100644
--- a/arch/alpha/defconfig
+++ b/arch/alpha/defconfig
@@ -882,7 +882,6 @@ CONFIG_MAGIC_SYSRQ=y
 # CONFIG_DEBUG_SPINLOCK is not set
 CONFIG_DEBUG_INFO=y
 CONFIG_EARLY_PRINTK=y
-# CONFIG_DEBUG_RWLOCK is not set
 # CONFIG_DEBUG_SEMAPHORE is not set
 CONFIG_ALPHA_LEGACY_START_ADDRESS=y
 CONFIG_MATHEMU=y
diff --git a/arch/parisc/Kconfig.debug b/arch/parisc/Kconfig.debug
index 9166bd1..bc989e5 100644
--- a/arch/parisc/Kconfig.debug
+++ b/arch/parisc/Kconfig.debug
@@ -2,15 +2,6 @@ menu "Kernel hacking"
 
 source "lib/Kconfig.debug"
 
-config DEBUG_RWLOCK
-        bool "Read-write spinlock debugging"
-        depends on DEBUG_KERNEL && SMP
-        help
-          If you say Y here then read-write lock processing will count how many
-          times it has tried to get the lock and issue an error message after
-          too many attempts.  If you suspect a rwlock problem or a kernel
-          hacker asks for this option then say Y.  Otherwise say N.

Re: [parisc-linux] [PATCH] alpha/parisc: Removing config variable DEBUG_RWLOCK

[Grant Grundler]

On Thu, Nov 15, 2007 at 09:42:05AM +0100, Jiri Olsa wrote:
> Removing config variable DEBUG_RWLOCK, since it is not used
> 
> Signed-off-by: Jiri Olsa <olsajiri@gmail.com>

For the arch/parisc bit:
  Acked-by: Grant Grundler <grundler@parisc-linux.org>

thanks,
grant

> ---
>  arch/alpha/Kconfig.debug           |    9 ---------
>  arch/alpha/defconfig               |    1 -
>  arch/parisc/Kconfig.debug          |    9 ---------
>  arch/parisc/configs/a500_defconfig |    1 -
>  4 files changed, 0 insertions(+), 20 deletions(-)
> 
> diff --git a/arch/alpha/Kconfig.debug b/arch/alpha/Kconfig.debug
> index f45f28c..3f6265f 100644
> --- a/arch/alpha/Kconfig.debug
> +++ b/arch/alpha/Kconfig.debug
> @@ -7,15 +7,6 @@ config EARLY_PRINTK
>  	depends on ALPHA_GENERIC || ALPHA_SRM
>  	default y
>  
> -config DEBUG_RWLOCK
> -	bool "Read-write spinlock debugging"
> -	depends on DEBUG_KERNEL
> -	help
> -	  If you say Y here then read-write lock processing will count how many
> -	  times it has tried to get the lock and issue an error message after
> -	  too many attempts.  If you suspect a rwlock problem or a kernel
> -	  hacker asks for this option then say Y.  Otherwise say N.
> -
>  config ALPHA_LEGACY_START_ADDRESS
>  	bool "Legacy kernel start address"
>  	depends on ALPHA_GENERIC
> diff --git a/arch/alpha/defconfig b/arch/alpha/defconfig
> index 6da9c3d..e43f68f 100644
> --- a/arch/alpha/defconfig
> +++ b/arch/alpha/defconfig
> @@ -882,7 +882,6 @@ CONFIG_MAGIC_SYSRQ=y
>  # CONFIG_DEBUG_SPINLOCK is not set
>  CONFIG_DEBUG_INFO=y
>  CONFIG_EARLY_PRINTK=y
> -# CONFIG_DEBUG_RWLOCK is not set
>  # CONFIG_DEBUG_SEMAPHORE is not set
>  CONFIG_ALPHA_LEGACY_START_ADDRESS=y
>  CONFIG_MATHEMU=y
> diff --git a/arch/parisc/Kconfig.debug b/arch/parisc/Kconfig.debug
> index 9166bd1..bc989e5 100644
> --- a/arch/parisc/Kconfig.debug
> +++ b/arch/parisc/Kconfig.debug
> @@ -2,15 +2,6 @@ menu "Kernel hacking"
>  
>  source "lib/Kconfig.debug"
>  
> -config DEBUG_RWLOCK
> -        bool "Read-write spinlock debugging"
> -        depends on DEBUG_KERNEL && SMP
> -        help
> -          If you say Y here then read-write lock processing will count how many
> -          times it has tried to get the lock and issue an error message after
> -          too many attempts.  If you suspect a rwlock problem or a kernel
> -          hacker asks for this option then say Y.  Otherwise say N.
> -
>  config DEBUG_RODATA
>         bool "Write protect kernel read-only data structures"
>         depends on DEBUG_KERNEL
> diff --git a/arch/parisc/configs/a500_defconfig b/arch/parisc/configs/a500_defconfig
> index ea07121..ddacc72 100644
> --- a/arch/parisc/configs/a500_defconfig
> +++ b/arch/parisc/configs/a500_defconfig
> @@ -1050,7 +1050,6 @@ CONFIG_SCHED_DEBUG=y
>  CONFIG_FORCED_INLINING=y
>  # CONFIG_RCU_TORTURE_TEST is not set
>  # CONFIG_FAULT_INJECTION is not set
> -# CONFIG_DEBUG_RWLOCK is not set
>  # CONFIG_DEBUG_RODATA is not set
>  
>  #
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

Re: [parisc-linux] [PATCH] alpha/parisc: Removing config variable DEBUG_RWLOCK

[Robert P. J. Day]

On Thu, 15 Nov 2007, Grant Grundler wrote:

> On Thu, Nov 15, 2007 at 09:42:05AM +0100, Jiri Olsa wrote:
> > Removing config variable DEBUG_RWLOCK, since it is not used

... snip ...

> > diff --git a/arch/parisc/configs/a500_defconfig b/arch/parisc/configs/a500_defconfig
> > index ea07121..ddacc72 100644
> > --- a/arch/parisc/configs/a500_defconfig
> > +++ b/arch/parisc/configs/a500_defconfig
> > @@ -1050,7 +1050,6 @@ CONFIG_SCHED_DEBUG=y
> >  CONFIG_FORCED_INLINING=y
> >  # CONFIG_RCU_TORTURE_TEST is not set
> >  # CONFIG_FAULT_INJECTION is not set
> > -# CONFIG_DEBUG_RWLOCK is not set
> >  # CONFIG_DEBUG_RODATA is not set

IIRC, you typically don't bother fixing up the defconfig files --
those will be regenerated eventually.

rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

Re: [parisc-linux] [PATCH] alpha/parisc: Removing config variable DEBUG_RWLOCK

[Jiri Olsa]

Robert P. J. Day wrote:
> On Thu, 15 Nov 2007, Grant Grundler wrote:
> 
>> On Thu, Nov 15, 2007 at 09:42:05AM +0100, Jiri Olsa wrote:
>>> Removing config variable DEBUG_RWLOCK, since it is not used
> 
> ... snip ...
> 
>>> diff --git a/arch/parisc/configs/a500_defconfig b/arch/parisc/configs/a500_defconfig
>>> index ea07121..ddacc72 100644
>>> --- a/arch/parisc/configs/a500_defconfig
>>> +++ b/arch/parisc/configs/a500_defconfig
>>> @@ -1050,7 +1050,6 @@ CONFIG_SCHED_DEBUG=y
>>>  CONFIG_FORCED_INLINING=y
>>>  # CONFIG_RCU_TORTURE_TEST is not set
>>>  # CONFIG_FAULT_INJECTION is not set
>>> -# CONFIG_DEBUG_RWLOCK is not set
>>>  # CONFIG_DEBUG_RODATA is not set
> 
> IIRC, you typically don't bother fixing up the defconfig files --
> those will be regenerated eventually.

I think they are part of repository... I'll check

> 
> rday
> --
> ========================================================================
> Robert P. J. Day
> Linux Consulting, Training and Annoying Kernel Pedantry
> Waterloo, Ontario, CANADA
> 
> http://crashcourse.ca
> ========================================================================
> 

_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

Re: [parisc-linux] [PATCH] alpha/parisc: Removing config variable DEBUG_RWLOCK

[Robert P. J. Day]

On Fri, 16 Nov 2007, Jiri Olsa wrote:

> Robert P. J. Day wrote:

> > IIRC, you typically don't bother fixing up the defconfig files --
> > those will be regenerated eventually.
>
> I think they are part of repository... I'll check

yes, they're part of the repository but, as it was once explained to
me, they're autogenerated on a regular basis so, once there's no
remaining references to a Kconfig variable, the corresponding entries
in the defconfig files should eventually go away automatically.  ergo,
don't spend any time trying to clean them up.

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

Re: [parisc-linux] [PATCH] alpha/parisc: Removing config variable DEBUG_RWLOCK

[Grant Grundler]

On Thu, Nov 15, 2007 at 02:54:45PM -0500, Robert P. J. Day wrote:
...
> > > -# CONFIG_DEBUG_RWLOCK is not set
> > >  # CONFIG_DEBUG_RODATA is not set
> 
> IIRC, you typically don't bother fixing up the defconfig files --
> those will be regenerated eventually.

It's not automatic though. So I don't mind the update.

thanks,
grant
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux