Linux PARISC architecture development
 help / color / mirror / Atom feed
* [PATCH] parisc: fix dev_printk() compile warnings for accessing a device struct
@ 2009-01-13 20:14 Helge Deller
  2009-01-13 20:26 ` Kyle McMartin
  0 siblings, 1 reply; 2+ messages in thread
From: Helge Deller @ 2009-01-13 20:14 UTC (permalink / raw)
  To: Kyle McMartin, linux-parisc

Fix compile warnings:
drivers/scsi/zalon.c: In function `zalon_probe':
drivers/scsi/zalon.c:140: warning: passing arg 1 of `dev_driver_string' from incompatible pointer type
drivers/scsi/zalon.c:140: warning: passing arg 1 of `dev_name' from incompatible pointer type

Signed-off-by: Helge Deller <deller@gmx.de>

diff --git a/drivers/scsi/lasi700.c b/drivers/scsi/lasi700.c
index 4a4e695..f23c4ca 100644
--- a/drivers/scsi/lasi700.c
+++ b/drivers/scsi/lasi700.c
@@ -103,7 +103,7 @@ lasi700_probe(struct parisc_device *dev)
 
 	hostdata = kzalloc(sizeof(*hostdata), GFP_KERNEL);
 	if (!hostdata) {
-		dev_printk(KERN_ERR, dev, "Failed to allocate host data\n");
+		dev_printk(KERN_ERR, &dev->dev, "Failed to allocate host data\n");
 		return -ENOMEM;
 	}
 
diff --git a/drivers/scsi/zalon.c b/drivers/scsi/zalon.c
index a8d61a6..97f3158 100644
--- a/drivers/scsi/zalon.c
+++ b/drivers/scsi/zalon.c
@@ -137,7 +137,7 @@ zalon_probe(struct parisc_device *dev)
 		goto fail;
 
 	if (request_irq(dev->irq, ncr53c8xx_intr, IRQF_SHARED, "zalon", host)) {
-	  dev_printk(KERN_ERR, dev, "irq problem with %d, detaching\n ",
+	  dev_printk(KERN_ERR, &dev->dev, "irq problem with %d, detaching\n ",
 		     dev->irq);
 		goto fail;
 	}

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] parisc: fix dev_printk() compile warnings for accessing a device struct
  2009-01-13 20:14 [PATCH] parisc: fix dev_printk() compile warnings for accessing a device struct Helge Deller
@ 2009-01-13 20:26 ` Kyle McMartin
  0 siblings, 0 replies; 2+ messages in thread
From: Kyle McMartin @ 2009-01-13 20:26 UTC (permalink / raw)
  To: Helge Deller; +Cc: Kyle McMartin, linux-parisc

On Tue, Jan 13, 2009 at 09:14:51PM +0100, Helge Deller wrote:
> Fix compile warnings:
> drivers/scsi/zalon.c: In function `zalon_probe':
> drivers/scsi/zalon.c:140: warning: passing arg 1 of `dev_driver_string' from incompatible pointer type
> drivers/scsi/zalon.c:140: warning: passing arg 1 of `dev_name' from incompatible pointer type
> 
> Signed-off-by: Helge Deller <deller@gmx.de>
> 
> diff --git a/drivers/scsi/lasi700.c b/drivers/scsi/lasi700.c
> index 4a4e695..f23c4ca 100644
> --- a/drivers/scsi/lasi700.c
> +++ b/drivers/scsi/lasi700.c
> @@ -103,7 +103,7 @@ lasi700_probe(struct parisc_device *dev)
>  
>  	hostdata = kzalloc(sizeof(*hostdata), GFP_KERNEL);
>  	if (!hostdata) {
> -		dev_printk(KERN_ERR, dev, "Failed to allocate host data\n");
> +		dev_printk(KERN_ERR, &dev->dev, "Failed to allocate host data\n");

Huh, I thought there was a pretty macro thingy that casted to the
embedded struct device. Oh well.

applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-01-13 20:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-13 20:14 [PATCH] parisc: fix dev_printk() compile warnings for accessing a device struct Helge Deller
2009-01-13 20:26 ` Kyle McMartin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox