* [PATCH 05/10] parisc: use RCU to find network device
[not found] <20091110175446.280423729@vyatta.com>
@ 2009-11-10 17:54 ` Stephen Hemminger
2009-11-10 18:26 ` Eric Dumazet
2009-11-11 6:48 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Hemminger @ 2009-11-10 17:54 UTC (permalink / raw)
To: David Miller, Kyle McMartin, Helge Deller, Alexander Beregalov
Cc: netdev, linux-parisc
Another place where RCU can be used instead of read_lock(&dev_base_lock)
This is by inspection, don't have platform or cross-build environment
to validate.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/parisc/led.c 2009-11-09 22:19:07.223480872 -0800
+++ b/drivers/parisc/led.c 2009-11-10 09:28:38.279438787 -0800
@@ -354,9 +354,8 @@ static __inline__ int led_get_net_activi
/* we are running as a workqueue task, so locking dev_base
* for reading should be OK */
- read_lock(&dev_base_lock);
rcu_read_lock();
- for_each_netdev(&init_net, dev) {
+ for_each_netdev_rcu(&init_net, dev) {
const struct net_device_stats *stats;
struct in_device *in_dev = __in_dev_get_rcu(dev);
if (!in_dev || !in_dev->ifa_list)
@@ -368,7 +367,6 @@ static __inline__ int led_get_net_activi
tx_total += stats->tx_packets;
}
rcu_read_unlock();
- read_unlock(&dev_base_lock);
retval = 0;
--
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 05/10] parisc: use RCU to find network device
2009-11-10 17:54 ` [PATCH 05/10] parisc: use RCU to find network device Stephen Hemminger
@ 2009-11-10 18:26 ` Eric Dumazet
2009-11-11 6:48 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2009-11-10 18:26 UTC (permalink / raw)
To: Stephen Hemminger
Cc: David Miller, Kyle McMartin, Helge Deller, Alexander Beregalov,
netdev, linux-parisc
Stephen Hemminger a =E9crit :
> Another place where RCU can be used instead of read_lock(&dev_base_lo=
ck)
> This is by inspection, don't have platform or cross-build environment
> to validate.
>=20
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>=20
Duplicate of previously posted patch...
http://article.gmane.org/gmane.linux.network/143072
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 05/10] parisc: use RCU to find network device
2009-11-10 17:54 ` [PATCH 05/10] parisc: use RCU to find network device Stephen Hemminger
2009-11-10 18:26 ` Eric Dumazet
@ 2009-11-11 6:48 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2009-11-11 6:48 UTC (permalink / raw)
To: shemminger; +Cc: kyle, deller, a.beregalov, netdev, linux-parisc
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 10 Nov 2009 09:54:51 -0800
> Another place where RCU can be used instead of read_lock(&dev_base_lock)
> This is by inspection, don't have platform or cross-build environment
> to validate.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-11-11 6:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20091110175446.280423729@vyatta.com>
2009-11-10 17:54 ` [PATCH 05/10] parisc: use RCU to find network device Stephen Hemminger
2009-11-10 18:26 ` Eric Dumazet
2009-11-11 6:48 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox