From: Helge Deller <deller@gmx.de>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: linux-parisc@vger.kernel.org,
James Bottomley <James.Bottomley@hansenpartnership.com>
Subject: Re: parisc: fix compile warnings triggered by atomic_sub(sizeof(),v)
Date: Thu, 28 Feb 2013 00:41:17 +0100 [thread overview]
Message-ID: <512E999D.7000300@gmx.de> (raw)
In-Reply-To: <5949791.xCBY7uv0Ms@donald.sf-tec.de>
On 02/28/2013 12:09 AM, Rolf Eike Beer wrote:
> Helge Deller wrote:
>
>> atomic_sub() is defined as
>> and if VAL is of type unsigned int (as returned by sizeof()), negating
>> this value will overflow. Fix this by type-casting VAL to int type:
>
> Something in the first line of the message seems missing.
Oops...
This line:
#define atomic_sub(VAL,v) ((void)(__atomic_add_return(-(VAL),(v))))
is missing.
It was probably ignored by git am or was eaten by vi due to the "#" :-(
I'll fix that.
Thanks!
Helge
next prev parent reply other threads:[~2013-02-27 23:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 22:11 upcoming patches for 3.9 Helge Deller
2013-02-27 22:13 ` parisc: select ARCH_WANT_FRAME_POINTERS Helge Deller
2013-02-27 22:15 ` parisc: fix compile warnings triggered by atomic_sub(sizeof(),v) Helge Deller
2013-02-27 23:09 ` Rolf Eike Beer
2013-02-27 23:41 ` Helge Deller [this message]
2013-02-27 22:17 ` parisc: switch to compat_functions of io_setup, io_getevents and io_submit Helge Deller
2013-02-27 22:19 ` parisc: remove unused variable 'compat_val' Helge Deller
2013-02-27 22:21 ` parisc: avoid unitialized variable warning in pa_memcpy() Helge Deller
2013-02-27 22:22 ` parisc: check return value of down_interruptible() in hp_sdc_rtc.c Helge Deller
2013-03-02 19:40 ` parisc: fix redefinition of SET_PERSONALITY Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512E999D.7000300@gmx.de \
--to=deller@gmx.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=eike-kernel@sf-tec.de \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox