From: Helge Deller <deller@gmx.de>
To: linux-parisc@vger.kernel.org,
James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: parisc: fix compile warnings triggered by atomic_sub(sizeof(),v)
Date: Wed, 27 Feb 2013 23:15:52 +0100 [thread overview]
Message-ID: <20130227221552.GA2817@p100.box> (raw)
In-Reply-To: <20130227221137.GA2806@p100.box>
commit 4e5a5143e77add104aeee9cd6a92a2f89ab6edd6
Author: Helge Deller <deller@gmx.de>
Date: Wed Feb 27 00:14:56 2013 +0100
parisc: fix compile warnings triggered by atomic_sub(sizeof(),v)
This fixes compile warnings like this one:
net/ipv4/igmp.c: In function =E2=80=98ip_mc_leave_group=E2=80=99:
net/ipv4/igmp.c:1898:3: warning: overflow in implicit constant conversi=
on [-Woverflow]
atomic_sub() is defined as
and if VAL is of type unsigned int (as returned by sizeof()), negating
this value will overflow. Fix this by type-casting VAL to int type:
Signed-off-by: Helge Deller <deller@gmx.de>
diff --git a/arch/parisc/include/asm/atomic.h b/arch/parisc/include/asm=
/atomic.h
index af9cf30..f38e198 100644
--- a/arch/parisc/include/asm/atomic.h
+++ b/arch/parisc/include/asm/atomic.h
@@ -115,8 +115,8 @@ static __inline__ int __atomic_add_unless(atomic_t =
*v, int a, int u)
}
=20
=20
-#define atomic_add(i,v) ((void)(__atomic_add_return( (i),(v))))
-#define atomic_sub(i,v) ((void)(__atomic_add_return(-(i),(v))))
+#define atomic_add(i,v) ((void)(__atomic_add_return( (i),(v))))
+#define atomic_sub(i,v) ((void)(__atomic_add_return(-((int) (i)),(v)))=
)
#define atomic_inc(v) ((void)(__atomic_add_return( 1,(v))))
#define atomic_dec(v) ((void)(__atomic_add_return( -1,(v))))
=20
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc"=
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-02-27 22:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 22:11 upcoming patches for 3.9 Helge Deller
2013-02-27 22:13 ` parisc: select ARCH_WANT_FRAME_POINTERS Helge Deller
2013-02-27 22:15 ` Helge Deller [this message]
2013-02-27 23:09 ` parisc: fix compile warnings triggered by atomic_sub(sizeof(),v) Rolf Eike Beer
2013-02-27 23:41 ` Helge Deller
2013-02-27 22:17 ` parisc: switch to compat_functions of io_setup, io_getevents and io_submit Helge Deller
2013-02-27 22:19 ` parisc: remove unused variable 'compat_val' Helge Deller
2013-02-27 22:21 ` parisc: avoid unitialized variable warning in pa_memcpy() Helge Deller
2013-02-27 22:22 ` parisc: check return value of down_interruptible() in hp_sdc_rtc.c Helge Deller
2013-03-02 19:40 ` parisc: fix redefinition of SET_PERSONALITY Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130227221552.GA2817@p100.box \
--to=deller@gmx.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox