upcoming patches for 3.9

upcoming patches for 3.9

[Helge Deller]

the following patches are queued in the "fixes-for-3.9" branch of my git tree at 
git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git

Helge

parisc: select ARCH_WANT_FRAME_POINTERS

[Helge Deller]

commit 31a54684da3c14384168889035c54d5cb3c6d32a
Author: Helge Deller <deller@gmx.de>
Date:   Wed Feb 27 00:37:12 2013 +0100

Avoid the following warning when configuring the kernel for parisc:
warning: (LOCKDEP && FAULT_INJECTION_STACKTRACE_FILTER && LATENCYTOP && KMEMCHECK) selects FRAME_POINTER \
which has unmet direct dependencies (DEBUG_KERNEL && (CRIS || M68K || FRV || UML || AVR32 || SUPERH ||  \
BLACKFIN || MN10300) || ARCH_WANT_FRAME_POINTERS)

Signed-off-by: Helge Deller <deller@gmx.de>

diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig
index 7f9b3c5..313cce5 100644
--- a/arch/parisc/Kconfig
+++ b/arch/parisc/Kconfig
@@ -5,6 +5,7 @@ config PARISC
 	select HAVE_FUNCTION_TRACER if 64BIT
 	select HAVE_FUNCTION_GRAPH_TRACER if 64BIT
 	select HAVE_FUNCTION_TRACE_MCOUNT_TEST if 64BIT
+	select ARCH_WANT_FRAME_POINTERS
 	select RTC_CLASS
 	select RTC_DRV_GENERIC
 	select INIT_ALL_POSSIBLE

parisc: fix compile warnings triggered by atomic_sub(sizeof(),v)

[Helge Deller]

commit 4e5a5143e77add104aeee9cd6a92a2f89ab6edd6
Author: Helge Deller <deller@gmx.de>
Date:   Wed Feb 27 00:14:56 2013 +0100

parisc: fix compile warnings triggered by atomic_sub(sizeof(),v)

This fixes compile warnings like this one:
net/ipv4/igmp.c: In function =E2=80=98ip_mc_leave_group=E2=80=99:
net/ipv4/igmp.c:1898:3: warning: overflow in implicit constant conversi=
on [-Woverflow]

atomic_sub() is defined as
and if VAL is of type unsigned int (as returned by sizeof()), negating
this value will overflow. Fix this by type-casting VAL to int type:

Signed-off-by: Helge Deller <deller@gmx.de>

diff --git a/arch/parisc/include/asm/atomic.h b/arch/parisc/include/asm=
/atomic.h
index af9cf30..f38e198 100644
--- a/arch/parisc/include/asm/atomic.h
+++ b/arch/parisc/include/asm/atomic.h
@@ -115,8 +115,8 @@ static __inline__ int __atomic_add_unless(atomic_t =
*v, int a, int u)
 }
=20
=20
-#define atomic_add(i,v)	((void)(__atomic_add_return( (i),(v))))
-#define atomic_sub(i,v)	((void)(__atomic_add_return(-(i),(v))))
+#define atomic_add(i,v)	((void)(__atomic_add_return(        (i),(v))))
+#define atomic_sub(i,v)	((void)(__atomic_add_return(-((int) (i)),(v)))=
)
 #define atomic_inc(v)	((void)(__atomic_add_return(   1,(v))))
 #define atomic_dec(v)	((void)(__atomic_add_return(  -1,(v))))
=20
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc"=
 in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

parisc: switch to compat_functions of io_setup, io_getevents and io_submit

[Helge Deller]

commit c58c540c25a4ae98e021876cb32afb7794428267
Author: Helge Deller <deller@gmx.de>
Date:   Wed Feb 27 00:32:10 2013 +0100

parisc: switch to compat_functions of io_setup, io_getevents and io_submit

Signed-off-by: Helge Deller <deller@gmx.de>

diff --git a/arch/parisc/kernel/syscall_table.S b/arch/parisc/kernel/syscall_table.S
index fc9cab1..a410b1b 100644
--- a/arch/parisc/kernel/syscall_table.S
+++ b/arch/parisc/kernel/syscall_table.S
@@ -310,10 +310,10 @@
 	ENTRY_COMP(sched_getaffinity)
 	ENTRY_SAME(ni_syscall)	/* set_thread_area */
 	ENTRY_SAME(ni_syscall)	/* get_thread_area */
-	ENTRY_SAME(io_setup)		/* 215 */
+	ENTRY_COMP(io_setup)		/* 215 */
 	ENTRY_SAME(io_destroy)
-	ENTRY_SAME(io_getevents)
-	ENTRY_SAME(io_submit)
+	ENTRY_COMP(io_getevents)
+	ENTRY_COMP(io_submit)
 	ENTRY_SAME(io_cancel)
 	ENTRY_SAME(alloc_hugepages)	/* 220 */
 	ENTRY_SAME(free_hugepages)

parisc: remove unused variable 'compat_val'

[Helge Deller]

commit db0c2fcccf9ea3dc30f6e3b910bca7f819fb3a21
Author: Helge Deller <deller@gmx.de>
Date:   Wed Feb 27 00:02:31 2013 +0100

parisc: remove unused variable 'compat_val'

clean up after commit 6e26aab98ce8a818fb1ec47f8f727a8480a9011b
(switch to generic sigaltstack)

Signed-off-by: Helge Deller <deller@gmx.de>

diff --git a/arch/parisc/kernel/signal.c b/arch/parisc/kernel/signal.c
index 98e9e71..940188d 100644
--- a/arch/parisc/kernel/signal.c
+++ b/arch/parisc/kernel/signal.c
@@ -242,7 +242,6 @@ setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
 	unsigned long haddr, sigframe_size;
 	int err = 0;
 #ifdef CONFIG_64BIT
-	compat_int_t compat_val;
 	struct compat_rt_sigframe __user * compat_frame;
 	compat_sigset_t compat_set;
 #endif

parisc: avoid unitialized variable warning in pa_memcpy()

[Helge Deller]

commit eed0220c5b2f33e4da2e9ba207c798c1bdebe500
Author: Helge Deller <deller@gmx.de>
Date:   Wed Feb 27 00:06:48 2013 +0100

parisc: avoid unitialized variable warning in pa_memcpy()

Avoid this warning, while still prevent gcc from optimizing away the ex=
ception code:
arch/parisc/lib/memcpy.c: In function =E2=80=98pa_memcpy=E2=80=99:
arch/parisc/lib/memcpy.c:256:2: warning: =E2=80=98dummy=E2=80=99 may be=
 used uninitialized in this function [-Wuninitialized]

Signed-off-by: Helge Deller <deller@gmx.de>

diff --git a/arch/parisc/lib/memcpy.c b/arch/parisc/lib/memcpy.c
index 1dbca5c..a49cc81 100644
--- a/arch/parisc/lib/memcpy.c
+++ b/arch/parisc/lib/memcpy.c
@@ -68,7 +68,7 @@
 DECLARE_PER_CPU(struct exception_data, exception_data);
=20
 #define preserve_branch(label)	do {					\
-	volatile int dummy;						\
+	volatile int dummy =3D 0;						\
 	/* The following branch is never taken, it's just here to  */	\
 	/* prevent gcc from optimizing away our exception code. */ 	\
 	if (unlikely(dummy !=3D dummy))					\
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc"=
 in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

parisc: check return value of down_interruptible() in hp_sdc_rtc.c

[Helge Deller]

commit 42dfe13d133f945b49377c29b8c828205b231b4c
Author: Helge Deller <deller@gmx.de>
Date:   Wed Feb 27 22:46:56 2013 +0100

parisc: check return value of down_interruptible() in hp_sdc_rtc.c

additionally comment out unused code (which may be used later)

Signed-off-by: Helge Deller <deller@gmx.de>

diff --git a/drivers/input/misc/hp_sdc_rtc.c b/drivers/input/misc/hp_sdc_rtc.c
index 0b4f542..2e3334b 100644
--- a/drivers/input/misc/hp_sdc_rtc.c
+++ b/drivers/input/misc/hp_sdc_rtc.c
@@ -109,7 +109,9 @@ static int hp_sdc_rtc_do_read_bbrtc (struct rtc_time *rtctm)
 	
 	if (hp_sdc_enqueue_transaction(&t)) return -1;
 	
-	down_interruptible(&tsem);  /* Put ourselves to sleep for results. */
+	/* Put ourselves to sleep for results. */
+	if (WARN_ON(down_interruptible(&tsem)))
+		return -1;
 	
 	/* Check for nonpresence of BBRTC */
 	if (!((tseq[83] | tseq[90] | tseq[69] | tseq[76] |
@@ -176,11 +178,16 @@ static int64_t hp_sdc_rtc_read_i8042timer (uint8_t loadcmd, int numreg)
 	t.seq =			tseq;
 	t.act.semaphore =	&i8042tregs;
 
-	down_interruptible(&i8042tregs);  /* Sleep if output regs in use. */
+	/* Sleep if output regs in use. */
+	if (WARN_ON(down_interruptible(&i8042tregs)))
+		return -1;
 
 	if (hp_sdc_enqueue_transaction(&t)) return -1;
 	
-	down_interruptible(&i8042tregs);  /* Sleep until results come back. */
+	/* Sleep until results come back. */
+	if (WARN_ON(down_interruptible(&i8042tregs)))
+		return -1;
+
 	up(&i8042tregs);
 
 	return (tseq[5] | 
@@ -276,6 +283,7 @@ static inline int hp_sdc_rtc_read_ct(struct timeval *res) {
 }
 
 
+#if 0 /* not used yet */
 /* Set the i8042 real-time clock */
 static int hp_sdc_rtc_set_rt (struct timeval *setto)
 {
@@ -386,6 +394,7 @@ static int hp_sdc_rtc_set_i8042timer (struct timeval *setto, uint8_t setcmd)
 	}
 	return 0;
 }
+#endif
 
 static ssize_t hp_sdc_rtc_read(struct file *file, char __user *buf,
 			       size_t count, loff_t *ppos) {

Re: parisc: fix compile warnings triggered by atomic_sub(sizeof(),v)

[Rolf Eike Beer]

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

Helge Deller wrote:

> atomic_sub() is defined as
> and if VAL is of type unsigned int (as returned by sizeof()), negating
> this value will overflow. Fix this by type-casting VAL to int type:

Something in the first line of the message seems missing.

Eike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: parisc: fix compile warnings triggered by atomic_sub(sizeof(),v)

[Helge Deller]

On 02/28/2013 12:09 AM, Rolf Eike Beer wrote:
> Helge Deller wrote:
> 
>> atomic_sub() is defined as
>> and if VAL is of type unsigned int (as returned by sizeof()), negating
>> this value will overflow. Fix this by type-casting VAL to int type:
> 
> Something in the first line of the message seems missing.

Oops...
This line:
#define atomic_sub(VAL,v)        ((void)(__atomic_add_return(-(VAL),(v))))
is missing.
It was probably ignored by git am or was eaten by vi due to the "#" :-(

I'll fix that.

Thanks!
Helge 

parisc: fix redefinition of SET_PERSONALITY

[Helge Deller]

commit cf8e18ea2f8be26e8f9e44ed677d25f558ca301a
Author: Helge Deller <deller@gmx.de>
Date:   Sat Mar 2 20:15:28 2013 +0100

commit e72837e3e7bae3f182c4ac63c9424e86f1158dd0 introduced
a default SET_PERSONALITY() in include/linux/elf.h.
This breaks with our own SET_PERSONALITY define for
32bit userspace on 64bit kernel.

Signed-off-by: Helge Deller <deller@gmx.de>

diff --git a/arch/parisc/kernel/binfmt_elf32.c b/arch/parisc/kernel/binfmt_elf32.c
index f61692d..00dc66f 100644
--- a/arch/parisc/kernel/binfmt_elf32.c
+++ b/arch/parisc/kernel/binfmt_elf32.c
@@ -85,6 +85,7 @@ struct elf_prpsinfo32
  * could set a processor dependent flag in the thread_struct.
  */
 
+#undef SET_PERSONALITY
 #define SET_PERSONALITY(ex) \
 	set_thread_flag(TIF_32BIT); \
 	current->thread.map_base = DEFAULT_MAP_BASE32; \