public inbox for linux-parisc@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 17/25] parisc: Add 32 bit time_t and clock_t
       [not found] <1399971456-3941-1-git-send-email-lftan@altera.com>
@ 2014-05-13  9:06 ` Ley Foon Tan
  2014-05-13 20:17   ` Helge Deller
  0 siblings, 1 reply; 4+ messages in thread
From: Ley Foon Tan @ 2014-05-13  9:06 UTC (permalink / raw)
  To: linux-arch, linux-kernel
  Cc: Ley Foon Tan, lftan.linux, cltang, James E.J. Bottomley,
	Helge Deller, linux-parisc

Override time_t and clock_t in include/uapi/asm-generic.

Signed-off-by: Ley Foon Tan <lftan@altera.com>
---
 arch/parisc/include/uapi/asm/posix_types.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/parisc/include/uapi/asm/posix_types.h b/arch/parisc/include/uapi/asm/posix_types.h
index b934425..21fcf1c 100644
--- a/arch/parisc/include/uapi/asm/posix_types.h
+++ b/arch/parisc/include/uapi/asm/posix_types.h
@@ -19,6 +19,14 @@ typedef int			__kernel_suseconds_t;
 typedef long long		__kernel_off64_t;
 typedef unsigned long long	__kernel_ino64_t;
 
+#ifndef CONFIG_64BIT
+typedef long	__kernel_time_t;
+#define __kernel_time_t __kernel_time_t
+
+typedef long	__kernel_clock_t;
+#define __kernel_clock_t __kernel_clock_t
+#endif
+
 #include <asm-generic/posix_types.h>
 
 #endif
-- 
1.8.2.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 17/25] parisc: Add 32 bit time_t and clock_t
  2014-05-13  9:06 ` [PATCH 17/25] parisc: Add 32 bit time_t and clock_t Ley Foon Tan
@ 2014-05-13 20:17   ` Helge Deller
  2014-05-14  1:57     ` Ley Foon Tan
  2014-05-15  0:34     ` H. Peter Anvin
  0 siblings, 2 replies; 4+ messages in thread
From: Helge Deller @ 2014-05-13 20:17 UTC (permalink / raw)
  To: Ley Foon Tan, linux-arch, linux-kernel
  Cc: lftan.linux, cltang, James E.J. Bottomley, linux-parisc

Hi Ley,

On 05/13/2014 11:06 AM, Ley Foon Tan wrote:
> Override time_t and clock_t in include/uapi/asm-generic.
> 
> Signed-off-by: Ley Foon Tan <lftan@altera.com>
> ---
>  arch/parisc/include/uapi/asm/posix_types.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/parisc/include/uapi/asm/posix_types.h b/arch/parisc/include/uapi/asm/posix_types.h
> index b934425..21fcf1c 100644
> --- a/arch/parisc/include/uapi/asm/posix_types.h
> +++ b/arch/parisc/include/uapi/asm/posix_types.h
> @@ -19,6 +19,14 @@ typedef int			__kernel_suseconds_t;
>  typedef long long		__kernel_off64_t;
>  typedef unsigned long long	__kernel_ino64_t;
>  
> +#ifndef CONFIG_64BIT

We can't use CONFIG_64BIT for a userspace header file. Please use 
#if !defined(__LP64__)
instead.
But even then I'm not sure if it's all correct...

Helge 

> +typedef long	__kernel_time_t;
> +#define __kernel_time_t __kernel_time_t
> +
> +typedef long	__kernel_clock_t;
> +#define __kernel_clock_t __kernel_clock_t
> +#endif
> +
>  #include <asm-generic/posix_types.h>
>  
>  #endif
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 17/25] parisc: Add 32 bit time_t and clock_t
  2014-05-13 20:17   ` Helge Deller
@ 2014-05-14  1:57     ` Ley Foon Tan
  2014-05-15  0:34     ` H. Peter Anvin
  1 sibling, 0 replies; 4+ messages in thread
From: Ley Foon Tan @ 2014-05-14  1:57 UTC (permalink / raw)
  To: Helge Deller
  Cc: Linux-Arch, linux-kernel@vger.kernel.org, Chung-Lin Tang,
	James E.J. Bottomley, linux-parisc

On Wed, May 14, 2014 at 4:17 AM, Helge Deller <deller@gmx.de> wrote:
> Hi Ley,
>
> On 05/13/2014 11:06 AM, Ley Foon Tan wrote:
>> Override time_t and clock_t in include/uapi/asm-generic.
>>
>> Signed-off-by: Ley Foon Tan <lftan@altera.com>
>> ---
>>  arch/parisc/include/uapi/asm/posix_types.h | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/parisc/include/uapi/asm/posix_types.h b/arch/parisc/include/uapi/asm/posix_types.h
>> index b934425..21fcf1c 100644
>> --- a/arch/parisc/include/uapi/asm/posix_types.h
>> +++ b/arch/parisc/include/uapi/asm/posix_types.h
>> @@ -19,6 +19,14 @@ typedef int                        __kernel_suseconds_t;
>>  typedef long long            __kernel_off64_t;
>>  typedef unsigned long long   __kernel_ino64_t;
>>
>> +#ifndef CONFIG_64BIT
>
> We can't use CONFIG_64BIT for a userspace header file. Please use
> #if !defined(__LP64__)
> instead.
> But even then I'm not sure if it's all correct...
Okay, will change to this. Maybe can try compile and boot with this change.

Thanks.
Regards
Ley Foon

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 17/25] parisc: Add 32 bit time_t and clock_t
  2014-05-13 20:17   ` Helge Deller
  2014-05-14  1:57     ` Ley Foon Tan
@ 2014-05-15  0:34     ` H. Peter Anvin
  1 sibling, 0 replies; 4+ messages in thread
From: H. Peter Anvin @ 2014-05-15  0:34 UTC (permalink / raw)
  To: Helge Deller, Ley Foon Tan, linux-arch, linux-kernel
  Cc: lftan.linux, cltang, James E.J. Bottomley, linux-parisc

On 05/13/2014 01:17 PM, Helge Deller wrote:
> 
> We can't use CONFIG_64BIT for a userspace header file. Please use 
> #if !defined(__LP64__)
> instead.
> But even then I'm not sure if it's all correct...
> 

__u64 (or __s64) works fine in that case.

	-hpa

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-05-15  0:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1399971456-3941-1-git-send-email-lftan@altera.com>
2014-05-13  9:06 ` [PATCH 17/25] parisc: Add 32 bit time_t and clock_t Ley Foon Tan
2014-05-13 20:17   ` Helge Deller
2014-05-14  1:57     ` Ley Foon Tan
2014-05-15  0:34     ` H. Peter Anvin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox