[PATCH 01/66] arch/parisc/include/asm/percpu.h: Checkpatch cleanup

[PATCH 01/66] arch/parisc/include/asm/percpu.h: Checkpatch cleanup

[Andrea Gelmini]

arch/parisc/include/asm/percpu.h:6: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 arch/parisc/include/asm/percpu.h |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/parisc/include/asm/percpu.h b/arch/parisc/include/asm/percpu.h
index a0dcd19..fb92561 100644
--- a/arch/parisc/include/asm/percpu.h
+++ b/arch/parisc/include/asm/percpu.h
@@ -3,5 +3,4 @@
 
 #include <asm-generic/percpu.h>
 
-#endif 
-
+#endif
-- 
1.7.0.90.g251a4

[PATCH 19/66] arch/parisc/include/asm/current.h: Checkpatch cleanup

[Andrea Gelmini]

arch/parisc/include/asm/current.h:8: ERROR: "foo * bar" should be "foo *bar"
arch/parisc/include/asm/current.h:12: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 arch/parisc/include/asm/current.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/parisc/include/asm/current.h b/arch/parisc/include/asm/current.h
index 0fb9338..4cbf4ad 100644
--- a/arch/parisc/include/asm/current.h
+++ b/arch/parisc/include/asm/current.h
@@ -5,11 +5,11 @@
 
 struct task_struct;
 
-static inline struct task_struct * get_current(void)
+static inline struct task_struct *get_current(void)
 {
 	return current_thread_info()->task;
 }
- 
+
 #define current get_current()
 
 #endif /* !(_PARISC_CURRENT_H) */
-- 
1.7.0.90.g251a4

[PATCH 32/66] arch/parisc/include/asm/parport.h: Checkpatch cleanup

[Andrea Gelmini]

arch/parisc/include/asm/parport.h:1: ERROR: trailing whitespace
arch/parisc/include/asm/parport.h:11: WARNING: space prohibited between function name and open parenthesis '('

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 arch/parisc/include/asm/parport.h |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/parisc/include/asm/parport.h b/arch/parisc/include/asm/parport.h
index 00d9cc3..5cbf98b 100644
--- a/arch/parisc/include/asm/parport.h
+++ b/arch/parisc/include/asm/parport.h
@@ -1,4 +1,4 @@
-/* 
+/*
  *
  * parport.h: ia32-compatible parport initialisation
  *
@@ -8,8 +8,7 @@
 #define _ASM_PARPORT_H 1
 
 
-static int __devinit parport_pc_find_nonpci_ports (int autoirq, int autodma)
-{
+static int __devinit parport_pc_find_nonpci_ports (int autoirq, int autodma) {
 	/* nothing ! */
 	return 0;
 }
-- 
1.7.0.90.g251a4

Re: [PATCH 32/66] arch/parisc/include/asm/parport.h: Checkpatch cleanup

[Thibaut VARENE]

On Sat, Feb 27, 2010 at 5:51 PM, Andrea Gelmini
<andrea.gelmini@gelma.net> wrote:
> arch/parisc/include/asm/parport.h:1: ERROR: trailing whitespace
> arch/parisc/include/asm/parport.h:11: WARNING: space prohibited betwe=
en function name and open parenthesis '('
>
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
> ---
> =C2=A0arch/parisc/include/asm/parport.h | =C2=A0 =C2=A05 ++---
> =C2=A01 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/parisc/include/asm/parport.h b/arch/parisc/include/=
asm/parport.h
> index 00d9cc3..5cbf98b 100644
> --- a/arch/parisc/include/asm/parport.h
> +++ b/arch/parisc/include/asm/parport.h

> @@ -8,8 +8,7 @@
> =C2=A0#define _ASM_PARPORT_H 1
>
>
> -static int __devinit parport_pc_find_nonpci_ports (int autoirq, int =
autodma)
> -{
> +static int __devinit parport_pc_find_nonpci_ports (int autoirq, int =
autodma) {

This looks very much in contradiction with CodingStyle, since
parport_pc_find_nonpci_ports() is a function, and it's not a fix for
the quoted "WARNING". I'm guessing this wasn't intended the way it is.

HTH

T-Bone

--=20
Thibaut VARENE
http://www.parisc-linux.org/~varenet/

Re: [PATCH 32/66] arch/parisc/include/asm/parport.h: Checkpatch cleanup

[Andrea Gelmini]

2010/2/27 Thibaut VARENE <T-Bone@parisc-linux.org>:

Hi Thubaut,
   thanks a lot for you answer.

> This looks very much in contradiction with CodingStyle, since
> parport_pc_find_nonpci_ports() is a function, and it's not a fix for
> the quoted "WARNING". I'm guessing this wasn't intended the way it is.

My fault. I'll look at checkpatch.pl regexp to resolve false positive
(I've found a few other regressions).

Thanks again,
Andrea