From: John David Anglin <dave.anglin@bell.net>
To: Carlos O'Donell <carlos@systemhalted.org>,
Guy Martin <gmsoft@tuxicoman.be>
Cc: linux-parisc <linux-parisc@vger.kernel.org>
Subject: Re: [PATCH] Make EWOULDBLOCK be equal to EAGAIN on parisc.
Date: Thu, 16 Jan 2014 15:49:03 -0500 [thread overview]
Message-ID: <BLU0-SMTP89CC166E31998D28320EA697B90@phx.gbl> (raw)
In-Reply-To: <CAE2sS1gmD21qT=UPJEt9VfAnE=e-k=qwkQM0nUO0viMaJSm3ng@mail.gmail.com>
On 1/16/2014 3:02 PM, Carlos O'Donell wrote:
> On Thu, Jan 16, 2014 at 11:17 AM, Guy Martin <gmsoft@tuxicoman.be> wrote:
>> On Linux, only parisc uses a different value for EWOULDBLOCK which
>> causes a lot of troubles for applications not checking for both values.
>> Since the hpux compat is long dead, make EWOULDBLOCK behave the same as
>> all other architectures.
>>
>> Signed-off-by: Guy Martin <gmsoft@tuxicoman.be>
>> ---
>> arch/parisc/include/uapi/asm/errno.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/parisc/include/uapi/asm/errno.h
>> b/arch/parisc/include/uapi/asm/errno.h
>> index f3a8aa5..c0ae625 100644
>> --- a/arch/parisc/include/uapi/asm/errno.h
>> +++ b/arch/parisc/include/uapi/asm/errno.h
>> @@ -106,7 +106,7 @@
>>
>> #define EALREADY 244 /* Operation already in progress */
>> #define EINPROGRESS 245 /* Operation now in progress */
>> -#define EWOULDBLOCK 246 /* Operation would block (Linux
>> returns EAGAIN) */
>> +#define EWOULDBLOCK EAGAIN /* Operation would block (Not HPUX
>> compliant) */
>> #define ENOTEMPTY 247 /* Directory not empty */
>> #define ENAMETOOLONG 248 /* File name too long */
>> #define ELOOP 249 /* Too many symbolic links
>> encountered */
> This is an ABI break.
>
> You can't do this without rebuilding userspace.
>
> You need debian an gentoo onboard to do this ABI break.
This would take about a month on Debian, so I'm against. Various bits
of kernel code traditionally
return EWOULDBLOCK, so any application code that just checks EWOULDBLOCK
would fail.
Dave
--
John David Anglin dave.anglin@bell.net
next prev parent reply other threads:[~2014-01-16 20:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 16:17 [PATCH] Make EWOULDBLOCK be equal to EAGAIN on parisc Guy Martin
2014-01-16 20:02 ` Carlos O'Donell
2014-01-16 20:49 ` John David Anglin [this message]
2014-01-16 21:05 ` Carlos O'Donell
2014-01-16 21:15 ` Helge Deller
2014-01-16 22:43 ` Mike Frysinger
2014-01-17 8:55 ` Guy Martin
2014-01-17 14:01 ` John David Anglin
2014-01-17 14:08 ` Carlos O'Donell
2014-01-17 15:11 ` Guy Martin
2014-01-17 22:27 ` Helge Deller
2014-01-31 16:53 ` Helge Deller
2014-01-31 17:24 ` Carlos O'Donell
2014-01-31 23:16 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BLU0-SMTP89CC166E31998D28320EA697B90@phx.gbl \
--to=dave.anglin@bell.net \
--cc=carlos@systemhalted.org \
--cc=gmsoft@tuxicoman.be \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox