Linux PARISC architecture development
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@ldl.fc.hp.com>
To: parisc-linux@parisc-linux.org
Subject: [parisc-linux] Keyboard cleanup
Date: Wed, 21 Mar 2001 22:17:43 -0700	[thread overview]
Message-ID: <E14fxTj-00036B-00@chrysl> (raw)

we're getting a big pile of warnings:

hp_keyb.c:282: warning: (near initialization for `high_keys')

and it seems to be because the array we're initialising is of size 0
(128 - SC_LIM).  the following patch seems to DTRT, but i would appreciate
someone who has a (non-HIL) keyboard testing it and confirming it works.

Index: drivers/char/hp_keyb.c
===================================================================
RCS file: /home/cvs/parisc/linux/drivers/char/hp_keyb.c,v
retrieving revision 1.3
diff -u -p -r1.3 hp_keyb.c
--- hp_keyb.c	2000/11/16 20:37:43	1.3
+++ hp_keyb.c	2001/03/22 05:10:35
@@ -246,7 +246,7 @@ unsigned char hp_ps2kbd_sysrq_xlate[128]
  * they needed not before. It does not matter that there are duplicates, as
  * long as no duplication occurs for any single keyboard.
  */
-#define SC_LIM 128
+#define SC_LIM 59
 
 #define FOCUS_PF1 85           /* actual code! */
 #define FOCUS_PF2 89

             reply	other threads:[~2001-03-22  5:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-03-22  5:17 Matthew Wilcox [this message]
2001-03-25 23:33 ` [parisc-linux] Keyboard cleanup Matthew Wilcox
2001-03-26  0:46   ` Ryan Bradetich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E14fxTj-00036B-00@chrysl \
    --to=willy@ldl.fc.hp.com \
    --cc=parisc-linux@parisc-linux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox