* [parisc-linux] Keyboard cleanup
@ 2001-03-22 5:17 Matthew Wilcox
2001-03-25 23:33 ` Matthew Wilcox
0 siblings, 1 reply; 3+ messages in thread
From: Matthew Wilcox @ 2001-03-22 5:17 UTC (permalink / raw)
To: parisc-linux
we're getting a big pile of warnings:
hp_keyb.c:282: warning: (near initialization for `high_keys')
and it seems to be because the array we're initialising is of size 0
(128 - SC_LIM). the following patch seems to DTRT, but i would appreciate
someone who has a (non-HIL) keyboard testing it and confirming it works.
Index: drivers/char/hp_keyb.c
===================================================================
RCS file: /home/cvs/parisc/linux/drivers/char/hp_keyb.c,v
retrieving revision 1.3
diff -u -p -r1.3 hp_keyb.c
--- hp_keyb.c 2000/11/16 20:37:43 1.3
+++ hp_keyb.c 2001/03/22 05:10:35
@@ -246,7 +246,7 @@ unsigned char hp_ps2kbd_sysrq_xlate[128]
* they needed not before. It does not matter that there are duplicates, as
* long as no duplication occurs for any single keyboard.
*/
-#define SC_LIM 128
+#define SC_LIM 59
#define FOCUS_PF1 85 /* actual code! */
#define FOCUS_PF2 89
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [parisc-linux] Keyboard cleanup
2001-03-22 5:17 [parisc-linux] Keyboard cleanup Matthew Wilcox
@ 2001-03-25 23:33 ` Matthew Wilcox
2001-03-26 0:46 ` Ryan Bradetich
0 siblings, 1 reply; 3+ messages in thread
From: Matthew Wilcox @ 2001-03-25 23:33 UTC (permalink / raw)
To: Matthew Wilcox; +Cc: parisc-linux
On Wed, Mar 21, 2001 at 10:17:43PM -0700, Matthew Wilcox wrote:
> and it seems to be because the array we're initialising is of size 0
> (128 - SC_LIM). the following patch seems to DTRT, but i would appreciate
> someone who has a (non-HIL) keyboard testing it and confirming it works.
If no-one comes back to me by next weekend and says `no it doesn't work',
i'm going to commit this anyway and be unsympathetic if it has broken.
--
Revolutions do not require corporate support.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [parisc-linux] Keyboard cleanup
2001-03-25 23:33 ` Matthew Wilcox
@ 2001-03-26 0:46 ` Ryan Bradetich
0 siblings, 0 replies; 3+ messages in thread
From: Ryan Bradetich @ 2001-03-26 0:46 UTC (permalink / raw)
To: Matthew Wilcox; +Cc: parisc-linux
This patch worked fine for me on my 712/80 with a ps2 keyboard.
- Ryan
On Mon, Mar 26, 2001 at 12:33:12AM +0100, Matthew Wilcox wrote:
> On Wed, Mar 21, 2001 at 10:17:43PM -0700, Matthew Wilcox wrote:
> > and it seems to be because the array we're initialising is of size 0
> > (128 - SC_LIM). the following patch seems to DTRT, but i would appreciate
> > someone who has a (non-HIL) keyboard testing it and confirming it works.
>
> If no-one comes back to me by next weekend and says `no it doesn't work',
> i'm going to commit this anyway and be unsympathetic if it has broken.
>
> --
> Revolutions do not require corporate support.
>
>
> _______________________________________________
> parisc-linux mailing list
> parisc-linux@lists.parisc-linux.org
> http://lists.parisc-linux.org/cgi-bin/mailman/listinfo/parisc-linux
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2001-03-26 0:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-03-22 5:17 [parisc-linux] Keyboard cleanup Matthew Wilcox
2001-03-25 23:33 ` Matthew Wilcox
2001-03-26 0:46 ` Ryan Bradetich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox