* [PATCH] parisc: Fix set_fixmap() on PA1.x CPUs
@ 2021-10-31 20:58 Helge Deller
0 siblings, 0 replies; only message in thread
From: Helge Deller @ 2021-10-31 20:58 UTC (permalink / raw)
To: linux-parisc, James Bottomley, John David Anglin; +Cc: Sven Schnelle
Fix a kernel crash which happens on PA1.x CPUs while initializing the
FTRACE/KPROBE breakpoints. The PTE table entries for the fixmap area
were not created correctly.
Signed-off-by: Helge Deller <deller@gmx.de>
Fixes: ccfbc68d41c2 ("parisc: add set_fixmap()/clear_fixmap()")
Cc: stable@vger.kernel.org # v5.2+
diff --git a/arch/parisc/mm/fixmap.c b/arch/parisc/mm/fixmap.c
index 24426a7e1a5e..cc15d737fda6 100644
--- a/arch/parisc/mm/fixmap.c
+++ b/arch/parisc/mm/fixmap.c
@@ -20,12 +20,9 @@ void notrace set_fixmap(enum fixed_addresses idx, phys_addr_t phys)
pte_t *pte;
if (pmd_none(*pmd))
- pmd = pmd_alloc(NULL, pud, vaddr);
-
- pte = pte_offset_kernel(pmd, vaddr);
- if (pte_none(*pte))
pte = pte_alloc_kernel(pmd, vaddr);
+ pte = pte_offset_kernel(pmd, vaddr);
set_pte_at(&init_mm, vaddr, pte, __mk_pte(phys, PAGE_KERNEL_RWX));
flush_tlb_kernel_range(vaddr, vaddr + PAGE_SIZE);
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-10-31 20:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-31 20:58 [PATCH] parisc: Fix set_fixmap() on PA1.x CPUs Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox