public inbox for linux-parisc@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] parisc: Fix /proc/cpuinfo output for lscpu
@ 2023-08-18 20:35 Helge Deller
  0 siblings, 0 replies; only message in thread
From: Helge Deller @ 2023-08-18 20:35 UTC (permalink / raw)
  To: linux-parisc

The lscpu command is broken since commit cab56b51ec0e ("parisc: Fix
device names in /proc/iomem") added the PA pathname to all PA
devices, includig the CPUs.

lscpu parses /proc/cpuinfo and now believes it found different CPU
types since every CPU is listed with an unique identifier (PA
pathname).

Fix this problem by simply dropping the PA pathname when listing the
CPUs in /proc/cpuinfo. There is no need to show the pathname in this
procfs file.

Fixes: cab56b51ec0e ("parisc: Fix device names in /proc/iomem")
Signed-off-by: Helge Deller <deller@gmx.de>
Cc: <stable@vger.kernel.org> # v4.9+

---

diff --git a/arch/parisc/kernel/processor.c b/arch/parisc/kernel/processor.c
index 762289b9984e..8511594352ef 100644
--- a/arch/parisc/kernel/processor.c
+++ b/arch/parisc/kernel/processor.c
@@ -378,7 +378,9 @@ int
 show_cpuinfo (struct seq_file *m, void *v)
 {
 	unsigned long cpu;
+	char cpu_name[60];
 
+	cpu_name[0] = 0;
 	for_each_online_cpu(cpu) {
 		const struct cpuinfo_parisc *cpuinfo = &per_cpu(cpu_data, cpu);
 #ifdef CONFIG_SMP
@@ -424,10 +426,22 @@ show_cpuinfo (struct seq_file *m, void *v)
 		}
 		seq_printf(m, " (0x%02lx)\n", boot_cpu_data.pdc.capabilities);
 
+		/* strip bus path from CPU name to not confuse lscpu */
+		if (cpu_name[0] == 0) {
+			char *p;
+
+			if (cpuinfo->dev)
+				strlcpy(cpu_name, cpuinfo->dev->name,
+					sizeof(cpu_name));
+			else
+				strcpy(cpu_name, "Unknown");
+			p = strrchr(cpu_name, '[');
+			if (p)
+				*(--p) = 0;
+		}
 		seq_printf(m, "model\t\t: %s - %s\n",
 				 boot_cpu_data.pdc.sys_model_name,
-				 cpuinfo->dev ?
-				 cpuinfo->dev->name : "Unknown");
+				 cpu_name);
 
 		seq_printf(m, "hversion\t: 0x%08x\n"
 			        "sversion\t: 0x%08x\n",

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2023-08-18 20:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-18 20:35 [PATCH] parisc: Fix /proc/cpuinfo output for lscpu Helge Deller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox