[PATCH] parisc: Fix warning at drivers/pci/msi/msi.h:121

[PATCH] parisc: Fix warning at drivers/pci/msi/msi.h:121

[John David Anglin]

[-- Attachment #1: Type: text/plain, Size: 1370 bytes --]

Fix warning at drivers/pci/msi/msi.h:121.

Recently, I added a PCI to PCIe bridge adaptor and a PCIe NVME card
to my rp3440. Then, I noticed this warning at boot:

[   25.101978] WARNING: CPU: 0 PID: 10 at drivers/pci/msi/msi.h:121 pci_msi_setup_msi_irqs+0x68/0x90
[   25.104286] Modules linked in: nvme sr_mod(+) scsi_transport_sas nvme_core cdrom sd_mod t10_pi ata_generic uas usb_storage crc64_rocksoft pata_cmd64x sym53c8xx crc64 ohci_pci libata crc_t10dif ohci_hcd scsi_transport_spi ehci_pci crct10dif_generic ehci_hcd scsi_mod crct10dif_common tg3 usbcore libphy scsi_common usb_common
[   25.129353] CPU: 0 PID: 10 Comm: kworker/u32:0 Not tainted 6.9.7-parisc64 #1  Debian 6.9.7-1
[   25.129488] Hardware name: 9000/800/rp3440
[   25.169265] Workqueue: async async_run_entry_fn

We need to select PCI_MSI_ARCH_FALLBACKS when PCI_MSI is selected.

Signed-off-by: John David Anglin <dave.anglin@bell.net>
---

diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig
index dc9b902de8ea..9656e956ed13 100644
--- a/arch/parisc/Kconfig
+++ b/arch/parisc/Kconfig
@@ -86,6 +86,7 @@ config PARISC
 	select HAVE_SOFTIRQ_ON_OWN_STACK if IRQSTACKS
 	select TRACE_IRQFLAGS_SUPPORT
 	select HAVE_FUNCTION_DESCRIPTORS if 64BIT
+	select PCI_MSI_ARCH_FALLBACKS if PCI_MSI
 
 	help
 	  The PA-RISC microprocessor is designed by Hewlett-Packard and used

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] parisc: Fix warning at drivers/pci/msi/msi.h:121

[Helge Deller]

On 7/1/24 15:42, John David Anglin wrote:
> Fix warning at drivers/pci/msi/msi.h:121.
>
> Recently, I added a PCI to PCIe bridge adaptor and a PCIe NVME card
> to my rp3440. Then, I noticed this warning at boot:
>
> [   25.101978] WARNING: CPU: 0 PID: 10 at drivers/pci/msi/msi.h:121 pci_msi_setup_msi_irqs+0x68/0x90
> [   25.104286] Modules linked in: nvme sr_mod(+) scsi_transport_sas nvme_core cdrom sd_mod t10_pi ata_generic uas usb_storage crc64_rocksoft pata_cmd64x sym53c8xx crc64 ohci_pci libata crc_t10dif ohci_hcd scsi_transport_spi ehci_pci crct10dif_generic ehci_hcd scsi_mod crct10dif_common tg3 usbcore libphy scsi_common usb_common
> [   25.129353] CPU: 0 PID: 10 Comm: kworker/u32:0 Not tainted 6.9.7-parisc64 #1  Debian 6.9.7-1
> [   25.129488] Hardware name: 9000/800/rp3440
> [   25.169265] Workqueue: async async_run_entry_fn
>
> We need to select PCI_MSI_ARCH_FALLBACKS when PCI_MSI is selected.
>
> Signed-off-by: John David Anglin <dave.anglin@bell.net>

applied.

Thanks!
Helge


> ---
>
> diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig
> index dc9b902de8ea..9656e956ed13 100644
> --- a/arch/parisc/Kconfig
> +++ b/arch/parisc/Kconfig
> @@ -86,6 +86,7 @@ config PARISC
>   	select HAVE_SOFTIRQ_ON_OWN_STACK if IRQSTACKS
>   	select TRACE_IRQFLAGS_SUPPORT
>   	select HAVE_FUNCTION_DESCRIPTORS if 64BIT
> +	select PCI_MSI_ARCH_FALLBACKS if PCI_MSI
>
>   	help
>   	  The PA-RISC microprocessor is designed by Hewlett-Packard and used