[PATCH] parisc: eisa: Fix infinite loop when parsing invalid IRQ value

[PATCH] parisc: eisa: Fix infinite loop when parsing invalid IRQ value

[Pei Xiao]

When an invalid value is passed via the "eisa_irq_edge=" kernel
command line parameter (e.g. "eisa_irq_edge=16,5"), eisa_irq_setup()
prints an error message and continues without advancing the current
position.  As a result the same invalid value is parsed again and
again, causing an infinite loop while the kernel boots.

Advance to the next comma-separated entry, or stop parsing when there
is no next entry, before continuing so that the remaining entries are
processed normally.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
---
 drivers/parisc/eisa.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/parisc/eisa.c b/drivers/parisc/eisa.c
index 9eab974e6baf..b5b5413bfd1e 100644
--- a/drivers/parisc/eisa.c
+++ b/drivers/parisc/eisa.c
@@ -442,6 +442,11 @@ static int __init eisa_irq_setup(char *str)
 		val = (int) simple_strtoul(cur, &pe, 0);
 		if (val > 15 || val < 0) {
 			printk(KERN_ERR "eisa: EISA irq value are 0-15\n");
+			cur = strchr(cur, ',');
+			if (cur)
+				cur++;
+			else
+				break;
 			continue;
 		}
 		if (val == 2) {
-- 
2.25.1

Re: [PATCH] parisc: eisa: Fix infinite loop when parsing invalid IRQ value

[Helge Deller]

On 8/17/26 05:29, Pei Xiao wrote:
> When an invalid value is passed via the "eisa_irq_edge=" kernel
> command line parameter (e.g. "eisa_irq_edge=16,5"), eisa_irq_setup()
> prints an error message and continues without advancing the current
> position.  As a result the same invalid value is parsed again and
> again, causing an infinite loop while the kernel boots.
> 
> Advance to the next comma-separated entry, or stop parsing when there
> is no next entry, before continuing so that the remaining entries are
> processed normally.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
> ---
>   drivers/parisc/eisa.c | 5 +++++
>   1 file changed, 5 insertions(+)
applied.

Thanks!
Helge