Linux PARISC architecture development
 help / color / mirror / Atom feed
* [PATCH] PARISC: Replace deprecated SPIN_LOCK_UNLOCKED macro in semaphore.h.
@ 2008-03-15 13:31 Robert P. J. Day
  0 siblings, 0 replies; 2+ messages in thread
From: Robert P. J. Day @ 2008-03-15 13:31 UTC (permalink / raw)
  To: linux-parisc


Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

  does this make sense?

diff --git a/include/asm-parisc/semaphore.h
b/include/asm-parisc/semaphore.h
index a16271c..3d5ee7a 100644
--- a/include/asm-parisc/semaphore.h
+++ b/include/asm-parisc/semaphore.h
@@ -44,7 +44,7 @@ struct semaphore {

 #define __SEMAPHORE_INITIALIZER(name, n)				\
 {									\
-	.sentry		= SPIN_LOCK_UNLOCKED,				\
+	.sentry		= __SPIN_LOCK_UNLOCKED(name),			\
 	.count		= n,						\
 	.wait		= __WAIT_QUEUE_HEAD_INITIALIZER((name).wait)	\
 }
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================

^ permalink raw reply related	[flat|nested] 2+ messages in thread
* [PATCH] PARISC: Replace deprecated SPIN_LOCK_UNLOCKED macro in semaphore.h.
@ 2008-03-15 13:41 Robert P. J. Day
  0 siblings, 0 replies; 2+ messages in thread
From: Robert P. J. Day @ 2008-03-15 13:41 UTC (permalink / raw)
  To: linux-parisc


Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

  whoops, ignore that earlier patch.  the actual standard is to
incorporate the structure member in the lock name, thusly:

diff --git a/include/asm-parisc/semaphore.h b/include/asm-parisc/semaphore.h
index a16271c..e4eba1e 100644
--- a/include/asm-parisc/semaphore.h
+++ b/include/asm-parisc/semaphore.h
@@ -44,7 +44,7 @@ struct semaphore {

 #define __SEMAPHORE_INITIALIZER(name, n)				\
 {									\
-	.sentry		= SPIN_LOCK_UNLOCKED,				\
+	.sentry		= __SPIN_LOCK_UNLOCKED((name).sentry),		\
 	.count		= n,						\
 	.wait		= __WAIT_QUEUE_HEAD_INITIALIZER((name).wait)	\
 }
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-03-15 13:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-15 13:31 [PATCH] PARISC: Replace deprecated SPIN_LOCK_UNLOCKED macro in semaphore.h Robert P. J. Day
  -- strict thread matches above, loose matches on Subject: below --
2008-03-15 13:41 Robert P. J. Day

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox