* [PATCH 1/9] Add a missing include for linux/rtc.h
2009-01-15 23:46 [PATCH 0/9] rtc-parisc cleanup dann frazier
@ 2009-01-15 23:46 ` dann frazier
2009-01-15 23:46 ` [PATCH 2/9] Remove redundant locking dann frazier
` (8 subsequent siblings)
9 siblings, 0 replies; 16+ messages in thread
From: dann frazier @ 2009-01-15 23:46 UTC (permalink / raw)
To: linux-parisc, rtc-linux; +Cc: lkml, kyle, dann frazier
Signed-off-by: dann frazier <dannf@hp.com>
---
drivers/rtc/rtc-parisc.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/rtc/rtc-parisc.c b/drivers/rtc/rtc-parisc.c
index c6bfa6f..319bb5d 100644
--- a/drivers/rtc/rtc-parisc.c
+++ b/drivers/rtc/rtc-parisc.c
@@ -7,6 +7,7 @@
#include <linux/module.h>
#include <linux/time.h>
#include <linux/platform_device.h>
+#include <linux/rtc.h>
#include <asm/rtc.h>
--
1.5.6.5
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 2/9] Remove redundant locking
2009-01-15 23:46 [PATCH 0/9] rtc-parisc cleanup dann frazier
2009-01-15 23:46 ` [PATCH 1/9] Add a missing include for linux/rtc.h dann frazier
@ 2009-01-15 23:46 ` dann frazier
2009-01-15 23:46 ` [PATCH 3/9] remove struct parisc_rtc dann frazier
` (7 subsequent siblings)
9 siblings, 0 replies; 16+ messages in thread
From: dann frazier @ 2009-01-15 23:46 UTC (permalink / raw)
To: linux-parisc, rtc-linux; +Cc: lkml, kyle, dann frazier
The RTC subsystem proides ops locking, no need to implement our own
Signed-off-by: dann frazier <dannf@hp.com>
---
drivers/rtc/rtc-parisc.c | 12 +-----------
1 files changed, 1 insertions(+), 11 deletions(-)
diff --git a/drivers/rtc/rtc-parisc.c b/drivers/rtc/rtc-parisc.c
index 319bb5d..cb087ad 100644
--- a/drivers/rtc/rtc-parisc.c
+++ b/drivers/rtc/rtc-parisc.c
@@ -14,17 +14,13 @@
/* as simple as can be, and no simpler. */
struct parisc_rtc {
struct rtc_device *rtc;
- spinlock_t lock;
};
static int parisc_get_time(struct device *dev, struct rtc_time *tm)
{
- struct parisc_rtc *p = dev_get_drvdata(dev);
- unsigned long flags, ret;
+ unsigned long ret;
- spin_lock_irqsave(&p->lock, flags);
ret = get_rtc_time(tm);
- spin_unlock_irqrestore(&p->lock, flags);
if (ret & RTC_BATT_BAD)
return -EOPNOTSUPP;
@@ -34,13 +30,9 @@ static int parisc_get_time(struct device *dev, struct rtc_time *tm)
static int parisc_set_time(struct device *dev, struct rtc_time *tm)
{
- struct parisc_rtc *p = dev_get_drvdata(dev);
- unsigned long flags;
int ret;
- spin_lock_irqsave(&p->lock, flags);
ret = set_rtc_time(tm);
- spin_unlock_irqrestore(&p->lock, flags);
if (ret < 0)
return -EOPNOTSUPP;
@@ -61,8 +53,6 @@ static int __devinit parisc_rtc_probe(struct platform_device *dev)
if (!p)
return -ENOMEM;
- spin_lock_init(&p->lock);
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 3/9] remove struct parisc_rtc
2009-01-15 23:46 [PATCH 0/9] rtc-parisc cleanup dann frazier
2009-01-15 23:46 ` [PATCH 1/9] Add a missing include for linux/rtc.h dann frazier
2009-01-15 23:46 ` [PATCH 2/9] Remove redundant locking dann frazier
@ 2009-01-15 23:46 ` dann frazier
2009-01-15 23:46 ` [PATCH 4/9] Use rtc_valid_tm() in parisc_get_time dann frazier
` (6 subsequent siblings)
9 siblings, 0 replies; 16+ messages in thread
From: dann frazier @ 2009-01-15 23:46 UTC (permalink / raw)
To: linux-parisc, rtc-linux; +Cc: lkml, kyle, dann frazier
parisc_rtc now only includes an rtc_device pointer, so let's
just use the rtc_device type directly.
Signed-off-by: dann frazier <dannf@hp.com>
---
drivers/rtc/rtc-parisc.c | 19 +++++++------------
1 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/rtc/rtc-parisc.c b/drivers/rtc/rtc-parisc.c
index cb087ad..ee4e9a3 100644
--- a/drivers/rtc/rtc-parisc.c
+++ b/drivers/rtc/rtc-parisc.c
@@ -11,11 +11,6 @@
#include <asm/rtc.h>
-/* as simple as can be, and no simpler. */
-struct parisc_rtc {
- struct rtc_device *rtc;
-};
-
static int parisc_get_time(struct device *dev, struct rtc_time *tm)
{
unsigned long ret;
@@ -47,16 +42,16 @@ static const struct rtc_class_ops parisc_rtc_ops = {
static int __devinit parisc_rtc_probe(struct platform_device *dev)
{
- struct parisc_rtc *p;
+ struct rtc_device *p;
p = kzalloc(sizeof (*p), GFP_KERNEL);
if (!p)
return -ENOMEM;
- p->rtc = rtc_device_register("rtc-parisc", &dev->dev, &parisc_rtc_ops,
- THIS_MODULE);
- if (IS_ERR(p->rtc)) {
- int err = PTR_ERR(p->rtc);
+ p = rtc_device_register("rtc-parisc", &dev->dev, &parisc_rtc_ops,
+ THIS_MODULE);
+ if (IS_ERR(p)) {
+ int err = PTR_ERR(p);
kfree(p);
return err;
}
@@ -68,9 +63,9 @@ static int __devinit parisc_rtc_probe(struct platform_device *dev)
static int __devexit parisc_rtc_remove(struct platform_device *dev)
{
- struct parisc_rtc *p = platform_get_drvdata(dev);
+ struct rtc_device *p = platform_get_drvdata(dev);
- rtc_device_unregister(p->rtc);
+ rtc_device_unregister(p);
kfree(p);
return 0;
--
1.5.6.5
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 4/9] Use rtc_valid_tm() in parisc_get_time
2009-01-15 23:46 [PATCH 0/9] rtc-parisc cleanup dann frazier
` (2 preceding siblings ...)
2009-01-15 23:46 ` [PATCH 3/9] remove struct parisc_rtc dann frazier
@ 2009-01-15 23:46 ` dann frazier
2009-01-15 23:46 ` [PATCH 5/9] Use platform_driver_probe dann frazier
` (5 subsequent siblings)
9 siblings, 0 replies; 16+ messages in thread
From: dann frazier @ 2009-01-15 23:46 UTC (permalink / raw)
To: linux-parisc, rtc-linux; +Cc: lkml, kyle, dann frazier
Use the return value of rtc_valid_tm() instead of just returning 0.
Signed-off-by: dann frazier <dannf@hp.com>
---
drivers/rtc/rtc-parisc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/rtc/rtc-parisc.c b/drivers/rtc/rtc-parisc.c
index ee4e9a3..0477cc1 100644
--- a/drivers/rtc/rtc-parisc.c
+++ b/drivers/rtc/rtc-parisc.c
@@ -20,7 +20,7 @@ static int parisc_get_time(struct device *dev, struct rtc_time *tm)
if (ret & RTC_BATT_BAD)
return -EOPNOTSUPP;
- return 0;
+ return rtc_valid_tm(tm);
}
static int parisc_set_time(struct device *dev, struct rtc_time *tm)
--
1.5.6.5
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 5/9] Use platform_driver_probe
2009-01-15 23:46 [PATCH 0/9] rtc-parisc cleanup dann frazier
` (3 preceding siblings ...)
2009-01-15 23:46 ` [PATCH 4/9] Use rtc_valid_tm() in parisc_get_time dann frazier
@ 2009-01-15 23:46 ` dann frazier
2009-01-15 23:46 ` [PATCH 6/9] declare rtc_parisc_dev as static dann frazier
` (4 subsequent siblings)
9 siblings, 0 replies; 16+ messages in thread
From: dann frazier @ 2009-01-15 23:46 UTC (permalink / raw)
To: linux-parisc, rtc-linux; +Cc: lkml, kyle, dann frazier
This isn't a hotpluggable device, so call platform_driver_probe
directly in parisc_rtc_init
Signed-off-by: dann frazier <dannf@hp.com>
---
drivers/rtc/rtc-parisc.c | 12 +++---------
1 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/rtc/rtc-parisc.c b/drivers/rtc/rtc-parisc.c
index 0477cc1..a2ca07a 100644
--- a/drivers/rtc/rtc-parisc.c
+++ b/drivers/rtc/rtc-parisc.c
@@ -40,19 +40,14 @@ static const struct rtc_class_ops parisc_rtc_ops = {
.set_time = parisc_set_time,
};
-static int __devinit parisc_rtc_probe(struct platform_device *dev)
+static int __init parisc_rtc_probe(struct platform_device *dev)
{
struct rtc_device *p;
- p = kzalloc(sizeof (*p), GFP_KERNEL);
- if (!p)
- return -ENOMEM;
-
p = rtc_device_register("rtc-parisc", &dev->dev, &parisc_rtc_ops,
THIS_MODULE);
if (IS_ERR(p)) {
int err = PTR_ERR(p);
- kfree(p);
return err;
}
@@ -61,12 +56,11 @@ static int __devinit parisc_rtc_probe(struct platform_device *dev)
return 0;
}
-static int __devexit parisc_rtc_remove(struct platform_device *dev)
+static int __exit parisc_rtc_remove(struct platform_device *dev)
{
struct rtc_device *p = platform_get_drvdata(dev);
rtc_device_unregister(p);
- kfree(p);
return 0;
}
@@ -82,7 +76,7 @@ static struct platform_driver parisc_rtc_driver = {
static int __init parisc_rtc_init(void)
{
- return platform_driver_register(&parisc_rtc_driver);
+ return platform_driver_probe(&parisc_rtc_driver, parisc_rtc_probe);
}
static void __exit parisc_rtc_fini(void)
--
1.5.6.5
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 6/9] declare rtc_parisc_dev as static
2009-01-15 23:46 [PATCH 0/9] rtc-parisc cleanup dann frazier
` (4 preceding siblings ...)
2009-01-15 23:46 ` [PATCH 5/9] Use platform_driver_probe dann frazier
@ 2009-01-15 23:46 ` dann frazier
2009-01-15 23:46 ` [PATCH 7/9] remove unnecessary ret variable dann frazier
` (3 subsequent siblings)
9 siblings, 0 replies; 16+ messages in thread
From: dann frazier @ 2009-01-15 23:46 UTC (permalink / raw)
To: linux-parisc, rtc-linux; +Cc: lkml, kyle, dann frazier
Signed-off-by: dann frazier <dannf@hp.com>
---
arch/parisc/kernel/time.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/parisc/kernel/time.c b/arch/parisc/kernel/time.c
index 9d46c43..a479d08 100644
--- a/arch/parisc/kernel/time.c
+++ b/arch/parisc/kernel/time.c
@@ -216,7 +216,7 @@ void __init start_cpu_itimer(void)
per_cpu(cpu_data, cpu).it_value = next_tick;
}
-struct platform_device rtc_parisc_dev = {
+static struct platform_device rtc_parisc_dev = {
.name = "rtc-parisc",
.id = -1,
};
--
1.5.6.5
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 7/9] remove unnecessary ret variable
2009-01-15 23:46 [PATCH 0/9] rtc-parisc cleanup dann frazier
` (5 preceding siblings ...)
2009-01-15 23:46 ` [PATCH 6/9] declare rtc_parisc_dev as static dann frazier
@ 2009-01-15 23:46 ` dann frazier
2009-01-15 23:46 ` [PATCH 8/9] remove a couple unnecessary variables dann frazier
` (2 subsequent siblings)
9 siblings, 0 replies; 16+ messages in thread
From: dann frazier @ 2009-01-15 23:46 UTC (permalink / raw)
To: linux-parisc, rtc-linux; +Cc: lkml, kyle, dann frazier
Signed-off-by: dann frazier <dannf@hp.com>
---
arch/parisc/kernel/time.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/arch/parisc/kernel/time.c b/arch/parisc/kernel/time.c
index a479d08..e75cae6 100644
--- a/arch/parisc/kernel/time.c
+++ b/arch/parisc/kernel/time.c
@@ -223,10 +223,7 @@ static struct platform_device rtc_parisc_dev = {
static int __init rtc_init(void)
{
- int ret;
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 8/9] remove a couple unnecessary variables
2009-01-15 23:46 [PATCH 0/9] rtc-parisc cleanup dann frazier
` (6 preceding siblings ...)
2009-01-15 23:46 ` [PATCH 7/9] remove unnecessary ret variable dann frazier
@ 2009-01-15 23:46 ` dann frazier
2009-01-15 23:46 ` [PATCH 9/9] rename p pointer to rtc dann frazier
2009-01-16 0:06 ` [rtc-linux] [PATCH 0/9] rtc-parisc cleanup Alessandro Zummo
9 siblings, 0 replies; 16+ messages in thread
From: dann frazier @ 2009-01-15 23:46 UTC (permalink / raw)
To: linux-parisc, rtc-linux; +Cc: lkml, kyle, dann frazier
Signed-off-by: dann frazier <dannf@hp.com>
---
drivers/rtc/rtc-parisc.c | 12 +++---------
1 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/rtc/rtc-parisc.c b/drivers/rtc/rtc-parisc.c
index a2ca07a..c29e918 100644
--- a/drivers/rtc/rtc-parisc.c
+++ b/drivers/rtc/rtc-parisc.c
@@ -25,11 +25,7 @@ static int parisc_get_time(struct device *dev, struct rtc_time *tm)
static int parisc_set_time(struct device *dev, struct rtc_time *tm)
{
- int ret;
-
- ret = set_rtc_time(tm);
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 9/9] rename p pointer to rtc
2009-01-15 23:46 [PATCH 0/9] rtc-parisc cleanup dann frazier
` (7 preceding siblings ...)
2009-01-15 23:46 ` [PATCH 8/9] remove a couple unnecessary variables dann frazier
@ 2009-01-15 23:46 ` dann frazier
2009-01-16 0:06 ` [rtc-linux] [PATCH 0/9] rtc-parisc cleanup Alessandro Zummo
9 siblings, 0 replies; 16+ messages in thread
From: dann frazier @ 2009-01-15 23:46 UTC (permalink / raw)
To: linux-parisc, rtc-linux; +Cc: lkml, kyle, dann frazier
Signed-off-by: dann frazier <dannf@hp.com>
---
drivers/rtc/rtc-parisc.c | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/rtc/rtc-parisc.c b/drivers/rtc/rtc-parisc.c
index c29e918..b966f56 100644
--- a/drivers/rtc/rtc-parisc.c
+++ b/drivers/rtc/rtc-parisc.c
@@ -38,23 +38,23 @@ static const struct rtc_class_ops parisc_rtc_ops = {
static int __init parisc_rtc_probe(struct platform_device *dev)
{
- struct rtc_device *p;
+ struct rtc_device *rtc;
- p = rtc_device_register("rtc-parisc", &dev->dev, &parisc_rtc_ops,
- THIS_MODULE);
- if (IS_ERR(p))
- return PTR_ERR(p);
+ rtc = rtc_device_register("rtc-parisc", &dev->dev, &parisc_rtc_ops,
+ THIS_MODULE);
+ if (IS_ERR(rtc))
+ return PTR_ERR(rtc);
- platform_set_drvdata(dev, p);
+ platform_set_drvdata(dev, rtc);
return 0;
}
static int __exit parisc_rtc_remove(struct platform_device *dev)
{
- struct rtc_device *p = platform_get_drvdata(dev);
+ struct rtc_device *rtc = platform_get_drvdata(dev);
- rtc_device_unregister(p);
+ rtc_device_unregister(rtc);
return 0;
}
--
1.5.6.5
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [rtc-linux] [PATCH 0/9] rtc-parisc cleanup
2009-01-15 23:46 [PATCH 0/9] rtc-parisc cleanup dann frazier
` (8 preceding siblings ...)
2009-01-15 23:46 ` [PATCH 9/9] rename p pointer to rtc dann frazier
@ 2009-01-16 0:06 ` Alessandro Zummo
2009-01-16 0:36 ` Kyle McMartin
2009-01-16 20:47 ` Andrew Morton
9 siblings, 2 replies; 16+ messages in thread
From: Alessandro Zummo @ 2009-01-16 0:06 UTC (permalink / raw)
To: rtc-linux; +Cc: dannf, linux-parisc, lkml, kyle, akpm
On Thu, 15 Jan 2009 16:46:47 -0700
dann frazier <dannf@hp.com> wrote:
> I recently submitted an rtc-efi driver having used rtc-parisc as a
> template. I received several suggestions from Alessandro Zummo and
> Andrew Morton that also apply to rtc-parisc. This series merges the
> relevant changes back into the rtc-parisc driver.
Acked-by: Alessandro Zummo <a.zummo@towertech.it>
on the whole series. Thank you Dann!
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [rtc-linux] [PATCH 0/9] rtc-parisc cleanup
2009-01-16 0:06 ` [rtc-linux] [PATCH 0/9] rtc-parisc cleanup Alessandro Zummo
@ 2009-01-16 0:36 ` Kyle McMartin
2009-01-16 1:48 ` Alessandro Zummo
2009-01-16 20:47 ` Andrew Morton
1 sibling, 1 reply; 16+ messages in thread
From: Kyle McMartin @ 2009-01-16 0:36 UTC (permalink / raw)
To: Alessandro Zummo; +Cc: rtc-linux, dannf, linux-parisc, lkml, kyle, akpm, lethal
On Fri, Jan 16, 2009 at 01:06:33AM +0100, Alessandro Zummo wrote:
> On Thu, 15 Jan 2009 16:46:47 -0700
> dann frazier <dannf@hp.com> wrote:
>
> > I recently submitted an rtc-efi driver having used rtc-parisc as a
> > template. I received several suggestions from Alessandro Zummo and
> > Andrew Morton that also apply to rtc-parisc. This series merges the
> > relevant changes back into the rtc-parisc driver.
>
> Acked-by: Alessandro Zummo <a.zummo@towertech.it>
>
> on the whole series. Thank you Dann!
>
How does this jive with Paul Mundt's work that kills a bunch of these
rtc- drivers? (added Paul to CC)
These patches are cool with me. (I noticed you kept the same comment in
the ia64 time.c code. ;-)
Signed-off-by: Kyle McMartin <kyle@mcmartin.ca>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [rtc-linux] [PATCH 0/9] rtc-parisc cleanup
2009-01-16 0:36 ` Kyle McMartin
@ 2009-01-16 1:48 ` Alessandro Zummo
0 siblings, 0 replies; 16+ messages in thread
From: Alessandro Zummo @ 2009-01-16 1:48 UTC (permalink / raw)
To: Kyle McMartin; +Cc: rtc-linux, dannf, linux-parisc, lkml, kyle, akpm, lethal
On Thu, 15 Jan 2009 19:36:06 -0500
Kyle McMartin <kyle@infradead.org> wrote:
> How does this jive with Paul Mundt's work that kills a bunch of these
> rtc- drivers? (added Paul to CC)
You mean rtc-firmware? I'm not comfortable in having another legacy
bridge. archs need to move to the rtc subsystem as a whole.
I saw a lot of improvements in this direction in the last few kernels,
and I don't want to have something that will have to be removed in a couple
of months.
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [rtc-linux] [PATCH 0/9] rtc-parisc cleanup
2009-01-16 0:06 ` [rtc-linux] [PATCH 0/9] rtc-parisc cleanup Alessandro Zummo
2009-01-16 0:36 ` Kyle McMartin
@ 2009-01-16 20:47 ` Andrew Morton
2009-01-17 1:10 ` Alessandro Zummo
1 sibling, 1 reply; 16+ messages in thread
From: Andrew Morton @ 2009-01-16 20:47 UTC (permalink / raw)
To: Alessandro Zummo; +Cc: rtc-linux, dannf, linux-parisc, lkml, kyle
On Fri, 16 Jan 2009 01:06:33 +0100
Alessandro Zummo <alessandro.zummo@towertech.it> wrote:
> On Thu, 15 Jan 2009 16:46:47 -0700
> dann frazier <dannf@hp.com> wrote:
>
> > I recently submitted an rtc-efi driver having used rtc-parisc as a
> > template. I received several suggestions from Alessandro Zummo and
> > Andrew Morton that also apply to rtc-parisc. This series merges the
> > relevant changes back into the rtc-parisc driver.
>
> Acked-by: Alessandro Zummo <a.zummo@towertech.it>
>
> on the whole series. Thank you Dann!
>
I don't have a copy of these patches anywhere.
Whoever cc'ed "lkml@vger.kernel.org", please slap thyself!
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [rtc-linux] [PATCH 0/9] rtc-parisc cleanup
2009-01-16 20:47 ` Andrew Morton
@ 2009-01-17 1:10 ` Alessandro Zummo
2009-01-17 1:49 ` Andrew Morton
0 siblings, 1 reply; 16+ messages in thread
From: Alessandro Zummo @ 2009-01-17 1:10 UTC (permalink / raw)
To: Andrew Morton; +Cc: rtc-linux, dannf, linux-parisc, kyle
On Fri, 16 Jan 2009 12:47:30 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:
>
> I don't have a copy of these patches anywhere.
>
> Whoever cc'ed "lkml@vger.kernel.org", please slap thyself!
Here's the series in mbox format
http://patchwork.ozlabs.org/user/bundle/74/mbox/
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [rtc-linux] [PATCH 0/9] rtc-parisc cleanup
2009-01-17 1:10 ` Alessandro Zummo
@ 2009-01-17 1:49 ` Andrew Morton
0 siblings, 0 replies; 16+ messages in thread
From: Andrew Morton @ 2009-01-17 1:49 UTC (permalink / raw)
To: Alessandro Zummo; +Cc: rtc-linux, dannf, linux-parisc, kyle
On Sat, 17 Jan 2009 02:10:26 +0100 Alessandro Zummo <alessandro.zummo@towertech.it> wrote:
> On Fri, 16 Jan 2009 12:47:30 -0800
> Andrew Morton <akpm@linux-foundation.org> wrote:
>
> >
> > I don't have a copy of these patches anywhere.
> >
> > Whoever cc'ed "lkml@vger.kernel.org", please slap thyself!
>
> Here's the series in mbox format
> http://patchwork.ozlabs.org/user/bundle/74/mbox/
>
<fiddles around for a while, eventually gets them>
From: dann frazier <dannf@hp.com>
Subject: [1/9] Add a missing include for linux/rtc.h
Date: Thu, 15 Jan 2009 13:46:48 -0000
That's a bit awkward - if I do a reply-to-all with review comments, it
goes privately.
Obviously I can manually fix that up in this case, but...
^ permalink raw reply [flat|nested] 16+ messages in thread