[PATCH 00/33] net: ethernet: Mark expected switch fall-throughs

[PATCH 00/33] net: ethernet: Mark expected switch fall-throughs

[Gustavo A. R. Silva]

Hi all,

In preparation to enabling -Wimplicit-fallthrough, this patchset aims
to add some annotations in order to mark switch cases where we are
expecting to fall through.

Thanks

Gustavo A. R. Silva (33):
  8390: axnet_cs: Mark expected switch fall-through
  alteon: acenic: mark expected switch fall-through
  bnx2x: Mark expected switch fall-thoughs
  net: macb: Mark expected switch fall-through
  liquidio: mark expected switch fall-through
  cxgb4/l2t: Mark expected switch fall-through
  cxgb4/t4_hw: mark expected switch fall-throughs
  cxgb3/l2t: Mark expected switch fall-through
  net: thunderx: mark expected switch fall-through
  net: tulip_core: mark expected switch fall-through
  net: tulip: de4x5: mark expected switch fall-throughs
  be2net: Mark expected switch fall-through
  net: hns: Mark expected switch fall-through
  net: hns3: Mark expected switch fall-through
  i40e_main: mark expected switch fall-through
  i40e_txrx: mark expected switch fall-through
  net/mlx4/mcg: Mark expected switch fall-throughs
  net/mlx4/en_rx: Mark expected switch fall-throughs
  igb_main: Mark expected switch fall-throughs
  igb: e1000_82575: Mark expected switch fall-through
  igb: e1000_phy: Mark expected switch fall-through
  igbvf: netdev: Mark expected switch fall-through
  vxge: Mark expected switch fall-throughs
  net/mlx5e: Mark expected switch fall-throughs
  qed: qed_dev: Mark expected switch fall-throughs
  netxen_nic: Mark expected switch fall-throughs
  qede: qede_fp: Mark expected switch fall-through
  qlcnic: Mark expected switch fall-througs
  qlge: mark expected switch fall-through
  net: ethernet: sxgbe: mark expected switch fall-throughs
  net: sfc: falcon: mark expected switch fall-through
  net: tlan: Mark expected switch fall-through
  net: ethernet: ti: cpts: mark expected switch fall-through

 drivers/net/ethernet/8390/axnet_cs.c                    | 1 +
 drivers/net/ethernet/alteon/acenic.c                    | 1 +
 drivers/net/ethernet/broadcom/bnxt/bnxt.c               | 2 +-
 drivers/net/ethernet/cadence/macb_ptp.c                 | 1 +
 drivers/net/ethernet/cavium/liquidio/lio_main.c         | 1 +
 drivers/net/ethernet/cavium/thunder/nicvf_ethtool.c     | 1 +
 drivers/net/ethernet/chelsio/cxgb3/l2t.c                | 1 +
 drivers/net/ethernet/chelsio/cxgb4/l2t.c                | 1 +
 drivers/net/ethernet/chelsio/cxgb4/t4_hw.c              | 3 +++
 drivers/net/ethernet/dec/tulip/de4x5.c                  | 6 ++++++
 drivers/net/ethernet/dec/tulip/tulip_core.c             | 1 +
 drivers/net/ethernet/emulex/benet/be_ethtool.c          | 1 +
 drivers/net/ethernet/hisilicon/hns/hns_ethtool.c        | 1 +
 drivers/net/ethernet/hisilicon/hns3/hns3_enet.c         | 1 +
 drivers/net/ethernet/intel/i40e/i40e_main.c             | 1 +
 drivers/net/ethernet/intel/i40e/i40e_txrx.c             | 3 ++-
 drivers/net/ethernet/intel/igb/e1000_82575.c            | 1 +
 drivers/net/ethernet/intel/igb/e1000_phy.c              | 1 +
 drivers/net/ethernet/intel/igb/igb_main.c               | 2 ++
 drivers/net/ethernet/intel/igbvf/netdev.c               | 1 +
 drivers/net/ethernet/mellanox/mlx4/en_rx.c              | 2 ++
 drivers/net/ethernet/mellanox/mlx4/mcg.c                | 2 ++
 drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c        | 2 ++
 drivers/net/ethernet/neterion/vxge/vxge-config.c        | 3 +++
 drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c | 3 ++-
 drivers/net/ethernet/qlogic/qed/qed_dev.c               | 4 ++--
 drivers/net/ethernet/qlogic/qede/qede_fp.c              | 2 ++
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c     | 3 ++-
 drivers/net/ethernet/qlogic/qlge/qlge_mpi.c             | 1 +
 drivers/net/ethernet/samsung/sxgbe/sxgbe_ethtool.c      | 2 ++
 drivers/net/ethernet/sfc/falcon/ethtool.c               | 1 +
 drivers/net/ethernet/ti/cpts.c                          | 1 +
 drivers/net/ethernet/ti/tlan.c                          | 1 +
 33 files changed, 52 insertions(+), 6 deletions(-)

-- 
2.7.4

[PATCH 10/33] net: tulip_core: mark expected switch fall-through

[Gustavo A. R. Silva]

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 114782 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/net/ethernet/dec/tulip/tulip_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c
index 00d02a0..3e3e086 100644
--- a/drivers/net/ethernet/dec/tulip/tulip_core.c
+++ b/drivers/net/ethernet/dec/tulip/tulip_core.c
@@ -923,6 +923,7 @@ static int private_ioctl (struct net_device *dev, struct ifreq *rq, int cmd)
 			data->phy_id = 1;
 		else
 			return -ENODEV;
+		/* Fall through */
 
 	case SIOCGMIIREG:		/* Read MII PHY register. */
 		if (data->phy_id == 32 && (tp->flags & HAS_NWAY)) {
-- 
2.7.4

[PATCH 11/33] net: tulip: de4x5: mark expected switch fall-throughs

[Gustavo A. R. Silva]

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 114784 ("Missing break in switch")
Addresses-Coverity-ID: 114785 ("Missing break in switch")
Addresses-Coverity-ID: 114786 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/net/ethernet/dec/tulip/de4x5.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/ethernet/dec/tulip/de4x5.c b/drivers/net/ethernet/dec/tulip/de4x5.c
index a31b4df..66535d1 100644
--- a/drivers/net/ethernet/dec/tulip/de4x5.c
+++ b/drivers/net/ethernet/dec/tulip/de4x5.c
@@ -3204,6 +3204,8 @@ srom_map_media(struct net_device *dev)
       case SROM_10BASETF:
 	if (!lp->params.fdx) return -1;
 	lp->fdx = true;
+	/* fall through */
+
       case SROM_10BASET:
 	if (lp->params.fdx && !lp->fdx) return -1;
 	if ((lp->chipset == DC21140) || ((lp->chipset & ~0x00ff) == DC2114x)) {
@@ -3224,6 +3226,8 @@ srom_map_media(struct net_device *dev)
       case SROM_100BASETF:
         if (!lp->params.fdx) return -1;
 	lp->fdx = true;
+	/* fall through */
+
       case SROM_100BASET:
 	if (lp->params.fdx && !lp->fdx) return -1;
 	lp->media = _100Mb;
@@ -3236,6 +3240,8 @@ srom_map_media(struct net_device *dev)
       case SROM_100BASEFF:
 	if (!lp->params.fdx) return -1;
 	lp->fdx = true;
+	/* fall through */
+
       case SROM_100BASEF:
 	if (lp->params.fdx && !lp->fdx) return -1;
 	lp->media = _100Mb;
-- 
2.7.4

Re: [PATCH 00/33] net: ethernet: Mark expected switch fall-throughs

[David Miller]

From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Tue, 7 Aug 2018 18:09:00 -0500

> In preparation to enabling -Wimplicit-fallthrough, this patchset aims
> to add some annotations in order to mark switch cases where we are
> expecting to fall through.

Ok, I went through all of these and they look good.

If any are not correct we can revert/fix.

Series applied, thanks.

Re: [PATCH 00/33] net: ethernet: Mark expected switch fall-throughs

[Gustavo A. R. Silva]

On 8/7/18 7:59 PM, David Miller wrote:
> From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
> Date: Tue, 7 Aug 2018 18:09:00 -0500
> 
>> In preparation to enabling -Wimplicit-fallthrough, this patchset aims
>> to add some annotations in order to mark switch cases where we are
>> expecting to fall through.
> 
> Ok, I went through all of these and they look good.
> 
> If any are not correct we can revert/fix.
> 

Yep. If anything is reported, I'll take a look right away.

> Series applied, thanks.
> 

Thanks