From: Helge Deller <deller@gmx.de>
To: Xin Gao <gaoxin@cdjrlc.com>
Cc: linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma-mapping:do not initialise statics to 0.
Date: Thu, 21 Jul 2022 10:21:32 +0200 [thread overview]
Message-ID: <e63cfffa-126c-d6da-207d-43db651d2d92@gmx.de> (raw)
In-Reply-To: <20220720193941.8261-1-gaoxin@cdjrlc.com>
On 7/20/22 21:39, Xin Gao wrote:
> do not initialise statics to 0.
>
> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> ---
> arch/parisc/kernel/pci-dma.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/parisc/kernel/pci-dma.c b/arch/parisc/kernel/pci-dma.c
> index 160996f2198e..ba87f791323b 100644
> --- a/arch/parisc/kernel/pci-dma.c
> +++ b/arch/parisc/kernel/pci-dma.c
> @@ -36,8 +36,8 @@
> #include <asm/tlbflush.h> /* for purge_tlb_*() macros */
>
> static struct proc_dir_entry * proc_gsc_root __read_mostly = NULL;
While at it, you could remove the "= NULL" as well.
Helge
> -static unsigned long pcxl_used_bytes __read_mostly = 0;
> -static unsigned long pcxl_used_pages __read_mostly = 0;
> +static unsigned long pcxl_used_bytes __read_mostly;
> +static unsigned long pcxl_used_pages __read_mostly;
>
> extern unsigned long pcxl_dma_start; /* Start of pcxl dma mapping area */
> static DEFINE_SPINLOCK(pcxl_res_lock);
prev parent reply other threads:[~2022-07-21 8:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 19:39 [PATCH] dma-mapping:do not initialise statics to 0 Xin Gao
2022-07-21 8:21 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e63cfffa-126c-d6da-207d-43db651d2d92@gmx.de \
--to=deller@gmx.de \
--cc=gaoxin@cdjrlc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox