* [PATCH] dma-mapping:do not initialise statics to 0.
@ 2022-07-20 19:39 Xin Gao
2022-07-21 8:21 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Xin Gao @ 2022-07-20 19:39 UTC (permalink / raw)
To: James.Bottomley, deller; +Cc: linux-parisc, linux-kernel, Xin Gao
do not initialise statics to 0.
Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
---
arch/parisc/kernel/pci-dma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/parisc/kernel/pci-dma.c b/arch/parisc/kernel/pci-dma.c
index 160996f2198e..ba87f791323b 100644
--- a/arch/parisc/kernel/pci-dma.c
+++ b/arch/parisc/kernel/pci-dma.c
@@ -36,8 +36,8 @@
#include <asm/tlbflush.h> /* for purge_tlb_*() macros */
static struct proc_dir_entry * proc_gsc_root __read_mostly = NULL;
-static unsigned long pcxl_used_bytes __read_mostly = 0;
-static unsigned long pcxl_used_pages __read_mostly = 0;
+static unsigned long pcxl_used_bytes __read_mostly;
+static unsigned long pcxl_used_pages __read_mostly;
extern unsigned long pcxl_dma_start; /* Start of pcxl dma mapping area */
static DEFINE_SPINLOCK(pcxl_res_lock);
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dma-mapping:do not initialise statics to 0.
2022-07-20 19:39 [PATCH] dma-mapping:do not initialise statics to 0 Xin Gao
@ 2022-07-21 8:21 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2022-07-21 8:21 UTC (permalink / raw)
To: Xin Gao; +Cc: linux-parisc, linux-kernel
On 7/20/22 21:39, Xin Gao wrote:
> do not initialise statics to 0.
>
> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> ---
> arch/parisc/kernel/pci-dma.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/parisc/kernel/pci-dma.c b/arch/parisc/kernel/pci-dma.c
> index 160996f2198e..ba87f791323b 100644
> --- a/arch/parisc/kernel/pci-dma.c
> +++ b/arch/parisc/kernel/pci-dma.c
> @@ -36,8 +36,8 @@
> #include <asm/tlbflush.h> /* for purge_tlb_*() macros */
>
> static struct proc_dir_entry * proc_gsc_root __read_mostly = NULL;
While at it, you could remove the "= NULL" as well.
Helge
> -static unsigned long pcxl_used_bytes __read_mostly = 0;
> -static unsigned long pcxl_used_pages __read_mostly = 0;
> +static unsigned long pcxl_used_bytes __read_mostly;
> +static unsigned long pcxl_used_pages __read_mostly;
>
> extern unsigned long pcxl_dma_start; /* Start of pcxl dma mapping area */
> static DEFINE_SPINLOCK(pcxl_res_lock);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-21 8:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-20 19:39 [PATCH] dma-mapping:do not initialise statics to 0 Xin Gao
2022-07-21 8:21 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox