Re: [PATCH v3 05/11] of: Add a KUnit test for overlays and test managed APIs

[Stephen Boyd <sboyd@kernel.org>]

Quoting Rob Herring (2023-04-06 07:59:16)
> On Mon, Mar 27, 2023 at 03:21:53PM -0700, Stephen Boyd wrote:
> > diff --git a/drivers/of/overlay_test.c b/drivers/of/overlay_test.c
> > new file mode 100644
> > index 000000000000..66b1dceea568
> > --- /dev/null
> > +++ b/drivers/of/overlay_test.c
> > @@ -0,0 +1,110 @@
> > +// SPDX-License-Identifier: GPL-2.0
[...]
> > +/*
> > + * Test that of_overlay_apply_kunit() creates platform devices with the
> > + * expected device_node
> > + */
> > +static void of_overlay_apply_kunit_platform_device(struct kunit *test)
> > +{
> > +     struct device *dev;
> > +     struct device_node *np;
> > +
> > +     KUNIT_ASSERT_EQ(test, 0,
> > +                     of_overlay_apply_kunit(test, kunit_overlay_test));
> > +
> > +     np = of_find_node_by_name(NULL, kunit_node_name);
> > +     of_node_put_kunit(test, np);
> > +     KUNIT_ASSERT_NOT_ERR_OR_NULL(test, np);
> > +
> > +     dev = bus_find_device(&platform_bus_type, NULL, np, bus_match_np);
> 
> of_find_device_by_node()

Done.

> 
> > +     put_device(dev); /* Not derefing 'device' after this */
> > +     KUNIT_ASSERT_NOT_ERR_OR_NULL(test, dev);
> > +
> > +     /* Remove overlay */
> > +     kunit_cleanup(test);
> 
> I guess this is testing the cleanup. It's not that obvious given the 
> overlay is removed by kunit_cleanup(). Not sure if anything can be done 
> though...

Don't think so? The test name is "of_overlay_apply_kunit_cleanup", so we
need to use the kunit_cleanup() API to simulate that the "test is done".
Otherwise we're testing some other API like of_overlay_remove(), which
could be added as another test case. I specifically wanted to test that
the kunit cleanup path does what we're expecting here.