From: Stephen Boyd <sboyd@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
patches@lists.linux.dev,
Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <davidgow@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rafael J . Wysocki <rafael@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Christian Marangi <ansuelsmth@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com, Maxime Ripard <maxime@cerno.tech>
Subject: Re: [PATCH v3 02/11] of: Add test managed wrappers for of_overlay_apply()/of_node_put()
Date: Mon, 10 Apr 2023 12:51:04 -0700 [thread overview]
Message-ID: <b975ea0742459609ce43e54af3e0da31.sboyd@kernel.org> (raw)
In-Reply-To: <20230406143514.GA3036886-robh@kernel.org>
Quoting Rob Herring (2023-04-06 07:35:14)
> On Mon, Mar 27, 2023 at 03:21:50PM -0700, Stephen Boyd wrote:
> > Add test managed wrappers for of_overlay_apply() that automatically
> > removes the overlay when the test is finished. This API is intended for
> > use by KUnit tests that test code which relies on 'struct device_node's
> > and of_*() APIs.
> >
> > KUnit tests will call of_overlay_apply_kunit() to load an overlay that's
> > been built into the kernel image. When the test is complete, the overlay
> > will be removed.
>
> What if one wants to test the removal part itself?
>
We can add an of_overlay_remove_kunit() wrapper API that searches the
KUnit resource list for an 'ovcs_id'. I don't have a need for that API
currently so I didn't add it. As you found out, I used kunit_cleanup()
instead.
next prev parent reply other threads:[~2023-04-10 19:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 22:21 [PATCH v3 00/11] clk: Add kunit tests for fixed rate and parent data Stephen Boyd
2023-03-27 22:21 ` [PATCH v3 01/11] of: Add KUnit test to confirm DTB is loaded Stephen Boyd
2023-03-27 22:21 ` [PATCH v3 02/11] of: Add test managed wrappers for of_overlay_apply()/of_node_put() Stephen Boyd
2023-04-06 14:35 ` Rob Herring
2023-04-10 19:51 ` Stephen Boyd [this message]
2023-03-27 22:21 ` [PATCH v3 03/11] dt-bindings: vendor-prefixes: Add "test" vendor for KUnit and friends Stephen Boyd
2023-04-06 15:02 ` Rob Herring
2023-03-27 22:21 ` [PATCH v3 04/11] dt-bindings: test: Add KUnit empty node binding Stephen Boyd
2023-04-06 15:02 ` Rob Herring
2023-03-27 22:21 ` [PATCH v3 05/11] of: Add a KUnit test for overlays and test managed APIs Stephen Boyd
2023-04-06 14:59 ` Rob Herring
2023-04-10 20:12 ` Stephen Boyd
2023-04-13 0:04 ` Daniel Latypov
2023-04-13 0:26 ` Stephen Boyd
2023-03-27 22:21 ` [PATCH v3 06/11] platform: Add test managed platform_device/driver APIs Stephen Boyd
2023-03-27 22:21 ` [PATCH v3 07/11] dt-bindings: kunit: Add fixed rate clk consumer test Stephen Boyd
2023-04-06 15:02 ` Rob Herring
2023-03-27 22:21 ` [PATCH v3 08/11] clk: Add test managed clk provider/consumer APIs Stephen Boyd
2023-03-27 22:21 ` [PATCH v3 09/11] clk: Add KUnit tests for clk fixed rate basic type Stephen Boyd
2023-03-27 22:21 ` [PATCH v3 10/11] dt-bindings: clk: Add KUnit clk_parent_data test Stephen Boyd
2023-04-06 15:03 ` Rob Herring
2023-03-27 22:21 ` [PATCH v3 11/11] clk: Add KUnit tests for clks registered with struct clk_parent_data Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b975ea0742459609ce43e54af3e0da31.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=brendan.higgins@linux.dev \
--cc=davidgow@google.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=mturquette@baylibre.com \
--cc=patches@lists.linux.dev \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox