From: Sasha Levin <sashal@kernel.org>
To: patches@lists.linux.dev, stable@vger.kernel.org
Cc: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Sasha Levin <sashal@kernel.org>
Subject: [PATCH AUTOSEL 5.10 16/39] selftests: tracing: Use mutex_unlock for testing glob filter
Date: Sun, 3 Aug 2025 20:40:18 -0400 [thread overview]
Message-ID: <20250804004041.3628812-16-sashal@kernel.org> (raw)
In-Reply-To: <20250804004041.3628812-1-sashal@kernel.org>
From: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
[ Upstream commit a089bb2822a49b0c5777a8936f82c1f8629231fb ]
Since commit c5b6ababd21a ("locking/mutex: implement
mutex_trylock_nested") makes mutex_trylock() as an inlined
function if CONFIG_DEBUG_LOCK_ALLOC=y, we can not use
mutex_trylock() for testing the glob filter of ftrace.
Use mutex_unlock instead.
Link: https://lore.kernel.org/r/175151680309.2149615.9795104805153538717.stgit@mhiramat.tok.corp.google.com
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
LLM Generated explanations, may be completely bogus:
## Backport Status: YES
This commit should be backported to stable kernel trees for the
following reasons:
1. **It fixes a test regression**: The commit c5b6ababd21a changed
mutex_trylock() from being a regular function to an inline macro when
CONFIG_DEBUG_LOCK_ALLOC=y. This broke the ftrace glob filter selftest
that was trying to match functions with the pattern `mutex*try*`.
Since mutex_trylock is no longer a regular function symbol in certain
configurations, the test would fail.
2. **Simple and contained fix**: The change is minimal - it simply
replaces the test pattern from `mutex*try*` to `mutex*unl*` on line
32. This is a one-line change that:
- Changes the glob pattern from matching mutex_trylock functions to
mutex_unlock functions
- Maintains the same test logic and purpose (testing glob pattern
matching)
- mutex_unlock remains a regular function symbol regardless of
CONFIG_DEBUG_LOCK_ALLOC
3. **No functional changes to kernel code**: This only affects a
selftest, not any kernel functionality. The risk of regression is
zero for normal kernel operation.
4. **Test reliability**: Without this fix, the ftrace selftest suite
would fail on kernels built with CONFIG_DEBUG_LOCK_ALLOC=y after
commit c5b6ababd21a is applied. This could:
- Cause false test failures in CI/CD pipelines
- Make it harder to detect real ftrace issues
- Confuse developers running the test suite
5. **Clear dependency**: The commit message explicitly states this is
needed "Since commit c5b6ababd21a" which indicates this is a direct
fix for a known regression introduced by that specific commit.
The change is exactly the type that stable rules recommend: it fixes a
clear bug (test regression), is minimal in scope, has no risk of
breaking functionality, and maintains test coverage for an important
kernel feature (ftrace glob filtering).
.../testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc
index 4b994b6df5ac..ed81eaf2afd6 100644
--- a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc
+++ b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc
@@ -29,7 +29,7 @@ ftrace_filter_check 'schedule*' '^schedule.*$'
ftrace_filter_check '*pin*lock' '.*pin.*lock$'
# filter by start*mid*
-ftrace_filter_check 'mutex*try*' '^mutex.*try.*'
+ftrace_filter_check 'mutex*unl*' '^mutex.*unl.*'
# Advanced full-glob matching feature is recently supported.
# Skip the tests if we are sure the kernel does not support it.
--
2.39.5
next prev parent reply other threads:[~2025-08-04 0:41 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 0:40 [PATCH AUTOSEL 5.10 01/39] usb: xhci: print xhci->xhc_state when queue_command failed Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 02/39] cpufreq: CPPC: Mark driver with NEED_UPDATE_LIMITS flag Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 03/39] selftests/futex: Define SYS_futex on 32-bit architectures with 64-bit time_t Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 04/39] usb: typec: ucsi: psy: Set current max to 100mA for BC 1.2 and Default Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 05/39] regulator: core: repeat voltage setting request for stepped regulators Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 06/39] usb: xhci: Avoid showing warnings for dying controller Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 07/39] usb: xhci: Set avg_trb_len = 8 for EP0 during Address Device Command Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 08/39] usb: xhci: Avoid showing errors during surprise removal Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 09/39] gpio: wcd934x: check the return value of regmap_update_bits() Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 10/39] cpufreq: Exit governor when failed to start old governor Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 11/39] ARM: rockchip: fix kernel hang during smp initialization Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 12/39] PM / devfreq: governor: Replace sscanf() with kstrtoul() in set_freq_store() Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 13/39] ASoC: soc-dapm: set bias_level if snd_soc_dapm_set_bias_level() was successed Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 14/39] gpio: tps65912: check the return value of regmap_update_bits() Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 15/39] ARM: tegra: Use I/O memcpy to write to IRAM Sasha Levin
2025-08-04 0:40 ` Sasha Levin [this message]
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 17/39] PM: runtime: Clear power.needs_force_resume in pm_runtime_reinit() Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 18/39] thermal: sysfs: Return ENODATA instead of EAGAIN for reads Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 19/39] PM: sleep: console: Fix the black screen issue Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 20/39] ACPI: processor: fix acpi_object initialization Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 21/39] mmc: sdhci-msm: Ensure SD card power isn't ON when card removed Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 22/39] ACPI: APEI: GHES: add TAINT_MACHINE_CHECK on GHES panic path Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 23/39] reset: brcmstb: Enable reset drivers for ARCH_BCM2835 Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 24/39] mmc: rtsx_usb_sdmmc: Fix error-path in sd_set_power_mode() Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 25/39] x86/bugs: Avoid warning when overriding return thunk Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 26/39] ASoC: hdac_hdmi: Rate limit logging on connection and disconnection Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 27/39] ALSA: intel8x0: Fix incorrect codec index usage in mixer for ICH4 Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 28/39] ASoC: core: Check for rtd == NULL in snd_soc_remove_pcm_runtime() Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 29/39] usb: typec: intel_pmc_mux: Defer probe if SCU IPC isn't present Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 30/39] usb: core: usb_submit_urb: downgrade type check Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 31/39] usb: typec: fusb302: fix scheduling while atomic when using virtio-gpio Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 32/39] pm: cpupower: Fix the snapshot-order of tsc,mperf, clock in mperf_stop() Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 33/39] platform/x86: thinkpad_acpi: Handle KCOV __init vs inline mismatches Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 34/39] platform/chrome: cros_ec_typec: Defer probe on missing EC parent Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 35/39] ALSA: hda/ca0132: Fix buffer overflow in add_tuning_control Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 36/39] ALSA: pcm: Rewrite recalculate_boundary() to avoid costly loop Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 37/39] ALSA: usb-audio: Avoid precedence issues in mixer_quirks macros Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 38/39] iio: adc: ad7768-1: Ensure SYNC_IN pulse minimum timing requirement Sasha Levin
2025-08-04 0:40 ` [PATCH AUTOSEL 5.10 39/39] ASoC: codecs: rt5640: Retry DEVICE_ID verification Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250804004041.3628812-16-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=mhiramat@kernel.org \
--cc=patches@lists.linux.dev \
--cc=rostedt@goodmis.org \
--cc=skhan@linuxfoundation.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox