Archive-only list for patches
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: patches@lists.linux.dev, stable@vger.kernel.org
Cc: "Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Sasha Levin" <sashal@kernel.org>,
	alexhung@gmail.com, platform-driver-x86@vger.kernel.org
Subject: [PATCH AUTOSEL 6.17] platform/x86/intel/hid: Add Nova Lake support
Date: Mon, 24 Nov 2025 03:06:27 -0500	[thread overview]
Message-ID: <20251124080644.3871678-13-sashal@kernel.org> (raw)
In-Reply-To: <20251124080644.3871678-1-sashal@kernel.org>

From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

[ Upstream commit ddf5ffff3a5fe95bed178f5554596b93c52afbc9 ]

Add ACPI ID for Nova Lake.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Link: https://patch.msgid.link/20251110235041.123685-1-srinivas.pandruvada@linux.intel.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

LLM Generated explanations, may be completely bogus:

1. **COMMIT MESSAGE ANALYSIS**
   - The subject "platform/x86/intel/hid: Add Nova Lake support" and
     body "Add ACPI ID for Nova Lake" clearly identify this as a
     hardware enablement patch.
   - There are no "Fixes:" or "Cc: stable@" tags. While this often
     signals a feature, simple device ID additions are frequently
     backported without these tags under specific stable rule
     exceptions.
   - The change is signed off by the subsystem maintainer.

2. **DEEP CODE RESEARCH**
   - **File:** `drivers/platform/x86/intel/hid.c`
   - **Mechanism:** The `intel_hid` driver relies on an ACPI device ID
     table (`intel_hid_ids`) to bind to the underlying platform
     firmware. When the ACPI subsystem enumerates devices, it checks
     this table.
   - **The Change:** The commit adds a single line `{ "INTC10F2" }` to
     this array. This ID corresponds to the Nova Lake platform.
   - **Impact:** Without this ID, the kernel will fail to load this
     driver on Nova Lake laptops. Users would experience broken
     functionality for hotkeys (brightness, volume, WiFi toggle) and
     5-button array features (common on 2-in-1s/tablets).
   - **Context:** The diff shows the immediate predecessor `{ "INTC10F1"
     }` (Wildcat Lake), confirming that this driver is mature and
     regularly updated for new Intel generations via this exact
     mechanism.

3. **STABLE KERNEL RULES ALIGNMENT**
   - **General Rule:** Usually, new hardware support is not appropriate
     for stable.
   - **Exception Check (CRITICAL):** However, the *Stable Kernel Rules*
     (Documentation/process/stable-kernel-rules.rst) contain a specific
     exception for **"NEW DEVICE IDs"**. It explicitly states that
     adding ACPI IDs to existing drivers is allowed.
   - **Compliance:**
     - Does the driver exist in stable? **Yes**, `intel/hid.c` is a
       long-standing driver.
     - Is the change minimal? **Yes**, it is a one-line data addition.
     - Is it obviously correct? **Yes**, it strictly follows the pattern
       of previous platforms.

4. **RISK VS BENEFIT ASSESSMENT**
   - **Regression Risk:** **Negligible**. The change effectively only
     executes when the specific ACPI ID `INTC10F2` is present in the
     system firmware. Existing systems (with different IDs) will skip
     this entry in the match table, resulting in zero change in behavior
     for current users.
   - **Benefit:** High for users of new hardware. It allows enterprise
     and LTS distributions (which rely on stable kernels) to function
     correctly on upcoming Nova Lake devices without requiring a full
     kernel upgrade.

5. **CONCLUSION**
  This commit is a textbook example of the "New Device ID" exception. It
  provides necessary hardware enablement for stable kernel users with
  zero risk of regression for existing users. While it lacks a stable
  tag, it qualifies for backporting based on the documented rules and
  the trivial nature of the change.

**YES**

 drivers/platform/x86/intel/hid.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c
index f25a427cccdac..9c07a7faf18fe 100644
--- a/drivers/platform/x86/intel/hid.c
+++ b/drivers/platform/x86/intel/hid.c
@@ -55,6 +55,7 @@ static const struct acpi_device_id intel_hid_ids[] = {
 	{ "INTC10CB" },
 	{ "INTC10CC" },
 	{ "INTC10F1" },
+	{ "INTC10F2" },
 	{ }
 };
 MODULE_DEVICE_TABLE(acpi, intel_hid_ids);
-- 
2.51.0


  parent reply	other threads:[~2025-11-24  8:07 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-24  8:06 [PATCH AUTOSEL 6.17-5.10] platform/x86: huawei-wmi: add keys for HONOR models Sasha Levin
2025-11-24  8:06 ` [PATCH AUTOSEL 6.17] sched_ext: Fix possible deadlock in the deferred_irq_workfn() Sasha Levin
2025-11-24  8:06 ` [PATCH AUTOSEL 6.17-5.15] HID: elecom: Add support for ELECOM M-XT3URBK (018F) Sasha Levin
2025-11-24  8:06 ` [PATCH AUTOSEL 6.17] platform/x86: intel-uncore-freq: Add additional client processors Sasha Levin
2025-11-24  8:06 ` [PATCH AUTOSEL 6.17-6.6] platform/x86/amd/pmc: Add spurious_8042 to Xbox Ally Sasha Levin
2025-11-24  8:06 ` [PATCH AUTOSEL 6.17-5.10] pinctrl: qcom: msm: Fix deadlock in pinmux configuration Sasha Levin
2025-11-24  8:06 ` [PATCH AUTOSEL 6.17] platform/x86: hp-wmi: Add Omen 16-wf1xxx fan support Sasha Levin
2025-11-24  8:06 ` [PATCH AUTOSEL 6.17-5.10] samples: work around glibc redefining some of our defines wrong Sasha Levin
2025-11-24  8:06 ` [PATCH AUTOSEL 6.17-6.6] HID: hid-input: Extend Elan ignore battery quirk to USB Sasha Levin
2025-11-24  8:06 ` [PATCH AUTOSEL 6.17] HID: lenovo: fixup Lenovo Yoga Slim 7x Keyboard rdesc Sasha Levin
2025-11-24  8:06 ` [PATCH AUTOSEL 6.17] platform/x86/amd/pmc: Add support for Van Gogh SoC Sasha Levin
2025-11-24  8:06 ` [PATCH AUTOSEL 6.17] sched_ext: Use IRQ_WORK_INIT_HARD() to initialize rq->scx.kick_cpus_irq_work Sasha Levin
2025-11-24  8:06 ` Sasha Levin [this message]
2025-11-24  8:06 ` [PATCH AUTOSEL 6.17] platform/x86: hp-wmi: mark Victus 16-r0 and 16-s0 for victus_s fan and thermal profile support Sasha Levin
2025-11-24  8:06 ` [PATCH AUTOSEL 6.17-5.4] platform/x86: acer-wmi: Ignore backlight event Sasha Levin
2025-11-24  8:06 ` [PATCH AUTOSEL 6.17] platform/x86: hp-wmi: Add Omen MAX 16-ah0xx fan support and thermal profile Sasha Levin
2025-11-24  8:06 ` [PATCH AUTOSEL 6.17-6.6] platform/x86/amd: pmc: Add Lenovo Legion Go 2 to pmc quirk list Sasha Levin
2025-11-24  8:06 ` [PATCH AUTOSEL 6.17-6.6] nvme: fix admin request_queue lifetime Sasha Levin
2025-11-24  8:06 ` [PATCH AUTOSEL 6.17-6.1] LoongArch: Mask all interrupts during kexec/kdump Sasha Levin
2025-11-24  8:06 ` [PATCH AUTOSEL 6.17-6.1] HID: apple: Add SONiX AK870 PRO to non_apple_keyboards quirk list Sasha Levin
2025-11-24  8:06 ` [PATCH AUTOSEL 6.17-5.4] bfs: Reconstruct file type when loading from disk Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251124080644.3871678-13-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=alexhung@gmail.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=patches@lists.linux.dev \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox