From: Sasha Levin <sashal@kernel.org>
To: patches@lists.linux.dev, stable@vger.kernel.org
Cc: "Edip Hazuri" <edip@medip.dev>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Sasha Levin" <sashal@kernel.org>,
mpearson-lenovo@squebb.ca, mario.limonciello@amd.com,
kuurtb@gmail.com, luzmaximilian@gmail.com, jeffbai@aosc.io,
julien.robin28@free.fr, alexandre.f.demers@gmail.com
Subject: [PATCH AUTOSEL 6.17] platform/x86: hp-wmi: mark Victus 16-r0 and 16-s0 for victus_s fan and thermal profile support
Date: Mon, 24 Nov 2025 03:06:28 -0500 [thread overview]
Message-ID: <20251124080644.3871678-14-sashal@kernel.org> (raw)
In-Reply-To: <20251124080644.3871678-1-sashal@kernel.org>
From: Edip Hazuri <edip@medip.dev>
[ Upstream commit 54afb047cd7eb40149f3fc42d69fd4ddde2be9f0 ]
This patch adds Victus 16-r0 (8bbe) and Victus 16-s0(8bd4, 8bd5) laptop
DMI board name into existing list
Signed-off-by: Edip Hazuri <edip@medip.dev>
Link: https://patch.msgid.link/20251015181042.23961-3-edip@medip.dev
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
LLM Generated explanations, may be completely bogus:
### 1. COMMIT MESSAGE ANALYSIS
The commit subject "platform/x86: hp-wmi: mark Victus 16-r0 and 16-s0
for victus_s fan and thermal profile support" clearly indicates a
hardware enablement patch.
- **Problem:** Specific HP Victus laptop models (16-r0 and 16-s0) are
not recognized by the `hp-wmi` driver's thermal management logic.
- **Solution:** Add their DMI board names to the driver's allowlist.
- **Tags:** No "Fixes:" or "Cc: stable" tags are present, which is
common for device ID additions, though "Cc: stable" is preferred.
- **Type:** Hardware enablement via ID addition.
### 2. DEEP CODE RESEARCH
**Code Change:**
The patch modifies `drivers/platform/x86/hp/hp-wmi.c` by adding three
strings (`"8BBE"`, `"8BD4"`, `"8BD5"`) to the
`victus_s_thermal_profile_boards[]` array.
**Mechanism:**
1. **Entry Point:** The driver initializes platform profiles
(performance, balanced, quiet modes).
2. **Detection:** The function `is_victus_s_thermal_profile()` (not
shown in diff but known from context) checks `dmi_check_system()` or
compares the board name against the
`victus_s_thermal_profile_boards[]` array.
3. **Behavior:**
- **Before:** These laptops return `false`, causing the driver to
fall back to generic or legacy thermal handling, or disable
thermal profile support entirely. This results in users being
unable to control fan speeds or thermal envelopes (e.g.,
"Performance" mode won't work).
- **After:** The board names match, returning `true`. This engages
the `victus_s` code path, enabling the correct WMI calls for these
specific motherboard revisions.
**Dependencies:**
The patch relies on the `victus_s` infrastructure (functions like
`platform_profile_victus_s_ops`) being present in the kernel. This
infrastructure was introduced recently. Therefore, this backport is
valid **only** for stable trees that contain the base `victus_s` support
(likely 6.13+ or earlier kernels where the feature itself was
backported). For kernels lacking the base feature, this patch is
irrelevant. Assuming the target stable tree has the driver
infrastructure, this ID addition is correct.
### 3. STABLE KERNEL RULES ASSESSMENT
This commit falls squarely under **Exception #1: NEW DEVICE IDs**.
- **Rule:** "Adding PCI IDs, USB IDs, ACPI IDs, etc. to existing
drivers... These are trivial one-line additions that enable hardware
support."
- **Analysis:**
- **Existing Driver:** The `hp-wmi` driver and the `victus_s`
capability already exist in the tree.
- **Trivial:** The change is purely data (adding strings to an
array).
- **No Logic Change:** No executable code logic is altered; only the
data set for detection is expanded.
- **Hardware Support:** It enables existing, tested driver code to
function on new hardware variants.
### 4. RISK VS BENEFIT
- **Benefit:** High for affected users. Without this patch, owners of
these laptops on stable kernels (e.g., enterprise desktops, LTS
distros) have broken thermal management.
- **Risk:** Negligible. The change is isolated to a string array. It
cannot cause regressions for other devices because the strings are
unique identifiers.
- **Regression Potential:** Zero. Existing supported devices (`8C99`,
`8C9C`) are untouched.
### 5. CONCLUSION
This is a textbook example of a safe stable backport. While it
technically adds support for "new" hardware, the Linux stable process
explicitly allows adding Device IDs to existing drivers to ensure that
users on long-term kernels can use new hardware revisions. The change is
minimal, obviously correct, and fixes a functional deficiency for
specific hardware models without impacting others.
**YES**
drivers/platform/x86/hp/hp-wmi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
index 8b3533d6ba091..9a668e2587952 100644
--- a/drivers/platform/x86/hp/hp-wmi.c
+++ b/drivers/platform/x86/hp/hp-wmi.c
@@ -92,8 +92,9 @@ static const char * const victus_thermal_profile_boards[] = {
"8A25"
};
-/* DMI Board names of Victus 16-r1000 and Victus 16-s1000 laptops */
+/* DMI Board names of Victus 16-r and Victus 16-s laptops */
static const char * const victus_s_thermal_profile_boards[] = {
+ "8BBE", "8BD4", "8BD5",
"8C99", "8C9C"
};
--
2.51.0
next prev parent reply other threads:[~2025-11-24 8:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 8:06 [PATCH AUTOSEL 6.17-5.10] platform/x86: huawei-wmi: add keys for HONOR models Sasha Levin
2025-11-24 8:06 ` [PATCH AUTOSEL 6.17] sched_ext: Fix possible deadlock in the deferred_irq_workfn() Sasha Levin
2025-11-24 8:06 ` [PATCH AUTOSEL 6.17-5.15] HID: elecom: Add support for ELECOM M-XT3URBK (018F) Sasha Levin
2025-11-24 8:06 ` [PATCH AUTOSEL 6.17] platform/x86: intel-uncore-freq: Add additional client processors Sasha Levin
2025-11-24 8:06 ` [PATCH AUTOSEL 6.17-6.6] platform/x86/amd/pmc: Add spurious_8042 to Xbox Ally Sasha Levin
2025-11-24 8:06 ` [PATCH AUTOSEL 6.17-5.10] pinctrl: qcom: msm: Fix deadlock in pinmux configuration Sasha Levin
2025-11-24 8:06 ` [PATCH AUTOSEL 6.17] platform/x86: hp-wmi: Add Omen 16-wf1xxx fan support Sasha Levin
2025-11-24 8:06 ` [PATCH AUTOSEL 6.17-5.10] samples: work around glibc redefining some of our defines wrong Sasha Levin
2025-11-24 8:06 ` [PATCH AUTOSEL 6.17-6.6] HID: hid-input: Extend Elan ignore battery quirk to USB Sasha Levin
2025-11-24 8:06 ` [PATCH AUTOSEL 6.17] HID: lenovo: fixup Lenovo Yoga Slim 7x Keyboard rdesc Sasha Levin
2025-11-24 8:06 ` [PATCH AUTOSEL 6.17] platform/x86/amd/pmc: Add support for Van Gogh SoC Sasha Levin
2025-11-24 8:06 ` [PATCH AUTOSEL 6.17] sched_ext: Use IRQ_WORK_INIT_HARD() to initialize rq->scx.kick_cpus_irq_work Sasha Levin
2025-11-24 8:06 ` [PATCH AUTOSEL 6.17] platform/x86/intel/hid: Add Nova Lake support Sasha Levin
2025-11-24 8:06 ` Sasha Levin [this message]
2025-11-24 8:06 ` [PATCH AUTOSEL 6.17-5.4] platform/x86: acer-wmi: Ignore backlight event Sasha Levin
2025-11-24 8:06 ` [PATCH AUTOSEL 6.17] platform/x86: hp-wmi: Add Omen MAX 16-ah0xx fan support and thermal profile Sasha Levin
2025-11-24 8:06 ` [PATCH AUTOSEL 6.17-6.6] platform/x86/amd: pmc: Add Lenovo Legion Go 2 to pmc quirk list Sasha Levin
2025-11-24 8:06 ` [PATCH AUTOSEL 6.17-6.6] nvme: fix admin request_queue lifetime Sasha Levin
2025-11-24 8:06 ` [PATCH AUTOSEL 6.17-6.1] LoongArch: Mask all interrupts during kexec/kdump Sasha Levin
2025-11-24 8:06 ` [PATCH AUTOSEL 6.17-6.1] HID: apple: Add SONiX AK870 PRO to non_apple_keyboards quirk list Sasha Levin
2025-11-24 8:06 ` [PATCH AUTOSEL 6.17-5.4] bfs: Reconstruct file type when loading from disk Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251124080644.3871678-14-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=alexandre.f.demers@gmail.com \
--cc=edip@medip.dev \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jeffbai@aosc.io \
--cc=julien.robin28@free.fr \
--cc=kuurtb@gmail.com \
--cc=luzmaximilian@gmail.com \
--cc=mario.limonciello@amd.com \
--cc=mpearson-lenovo@squebb.ca \
--cc=patches@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox