* [PATCH] drm/amd/display: Respect CONFIG_FRAME_WARN=0 in DML2
@ 2023-10-18 18:45 Nathan Chancellor
2023-10-18 19:06 ` Hamza Mahfooz
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Chancellor @ 2023-10-18 18:45 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan
Cc: amd-gfx, dri-devel, patches, Nathan Chancellor
display_mode_code.c is unconditionally built with
-Wframe-larger-than=2048, which causes warnings even when
CONFIG_FRAME_WARN has been set to 0, which should show no warnings.
Use the existing $(frame_warn_flag) variable, which handles this
situation. This is basically commit 25f178bbd078 ("drm/amd/display:
Respect CONFIG_FRAME_WARN=0 in dml Makefile") but for DML2.
Fixes: 7966f319c66d ("drm/amd/display: Introduce DML2")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
drivers/gpu/drm/amd/display/dc/dml2/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dml2/Makefile b/drivers/gpu/drm/amd/display/dc/dml2/Makefile
index f35ed8de260d..66431525f2a0 100644
--- a/drivers/gpu/drm/amd/display/dc/dml2/Makefile
+++ b/drivers/gpu/drm/amd/display/dc/dml2/Makefile
@@ -61,7 +61,7 @@ ifneq ($(CONFIG_FRAME_WARN),0)
frame_warn_flag := -Wframe-larger-than=2048
endif
-CFLAGS_$(AMDDALPATH)/dc/dml2/display_mode_core.o := $(dml2_ccflags) -Wframe-larger-than=2048
+CFLAGS_$(AMDDALPATH)/dc/dml2/display_mode_core.o := $(dml2_ccflags) $(frame_warn_flag)
CFLAGS_$(AMDDALPATH)/dc/dml2/display_mode_util.o := $(dml2_ccflags)
CFLAGS_$(AMDDALPATH)/dc/dml2/dml2_wrapper.o := $(dml2_ccflags)
CFLAGS_$(AMDDALPATH)/dc/dml2/dml2_utils.o := $(dml2_ccflags)
---
base-commit: cd90511557fdfb394bb4ac4c3b539b007383914c
change-id: 20231018-amdgpu-dml2-respect-frame_warn-536e19b69ce0
Best regards,
--
Nathan Chancellor <nathan@kernel.org>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amd/display: Respect CONFIG_FRAME_WARN=0 in DML2
2023-10-18 18:45 [PATCH] drm/amd/display: Respect CONFIG_FRAME_WARN=0 in DML2 Nathan Chancellor
@ 2023-10-18 19:06 ` Hamza Mahfooz
0 siblings, 0 replies; 2+ messages in thread
From: Hamza Mahfooz @ 2023-10-18 19:06 UTC (permalink / raw)
To: Nathan Chancellor, harry.wentland, sunpeng.li, Rodrigo.Siqueira,
alexander.deucher, christian.koenig, Xinhui.Pan
Cc: dri-devel, amd-gfx, patches
On 10/18/23 14:45, Nathan Chancellor wrote:
> display_mode_code.c is unconditionally built with
> -Wframe-larger-than=2048, which causes warnings even when
> CONFIG_FRAME_WARN has been set to 0, which should show no warnings.
>
> Use the existing $(frame_warn_flag) variable, which handles this
> situation. This is basically commit 25f178bbd078 ("drm/amd/display:
> Respect CONFIG_FRAME_WARN=0 in dml Makefile") but for DML2.
>
> Fixes: 7966f319c66d ("drm/amd/display: Introduce DML2")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Applied, thanks!
> ---
> drivers/gpu/drm/amd/display/dc/dml2/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml2/Makefile b/drivers/gpu/drm/amd/display/dc/dml2/Makefile
> index f35ed8de260d..66431525f2a0 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml2/Makefile
> +++ b/drivers/gpu/drm/amd/display/dc/dml2/Makefile
> @@ -61,7 +61,7 @@ ifneq ($(CONFIG_FRAME_WARN),0)
> frame_warn_flag := -Wframe-larger-than=2048
> endif
>
> -CFLAGS_$(AMDDALPATH)/dc/dml2/display_mode_core.o := $(dml2_ccflags) -Wframe-larger-than=2048
> +CFLAGS_$(AMDDALPATH)/dc/dml2/display_mode_core.o := $(dml2_ccflags) $(frame_warn_flag)
> CFLAGS_$(AMDDALPATH)/dc/dml2/display_mode_util.o := $(dml2_ccflags)
> CFLAGS_$(AMDDALPATH)/dc/dml2/dml2_wrapper.o := $(dml2_ccflags)
> CFLAGS_$(AMDDALPATH)/dc/dml2/dml2_utils.o := $(dml2_ccflags)
>
> ---
> base-commit: cd90511557fdfb394bb4ac4c3b539b007383914c
> change-id: 20231018-amdgpu-dml2-respect-frame_warn-536e19b69ce0
>
> Best regards,
--
Hamza
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-18 19:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-18 18:45 [PATCH] drm/amd/display: Respect CONFIG_FRAME_WARN=0 in DML2 Nathan Chancellor
2023-10-18 19:06 ` Hamza Mahfooz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox