* [PATCH] ASoC: tegra: Revert fix for uninitialized flat cache warning in tegra210_ahub
@ 2025-12-17 13:25 Sheetal .
2025-12-17 13:40 ` Jon Hunter
0 siblings, 1 reply; 2+ messages in thread
From: Sheetal . @ 2025-12-17 13:25 UTC (permalink / raw)
To: linux-sound, Mark Brown
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Thierry Reding,
Jonathan Hunter, Charles Keepax, linux-tegra, linux-kernel,
sheetal
From: sheetal <sheetal@nvidia.com>
Commit 4d4021b0bbd1 ("ASoC: tegra: Fix uninitialized flat cache warning
in tegra210_ahub") attempted to fix the uninitialized flat cache warning
that is observed for the Tegra210 AHUB driver. However, the change broke
various audio tests because an -EBUSY error is returned when accessing
registers from cache before they are read from hardware. Revert this
change for now, until a proper fix is available.
Fixes: 4d4021b0bbd1 ("ASoC: tegra: Fix uninitialized flat cache warning in tegra210_ahub")
Signed-off-by: sheetal <sheetal@nvidia.com>
---
sound/soc/tegra/tegra210_ahub.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/tegra/tegra210_ahub.c b/sound/soc/tegra/tegra210_ahub.c
index 261d9067d27b..e795907a3963 100644
--- a/sound/soc/tegra/tegra210_ahub.c
+++ b/sound/soc/tegra/tegra210_ahub.c
@@ -2077,7 +2077,7 @@ static const struct regmap_config tegra210_ahub_regmap_config = {
.val_bits = 32,
.reg_stride = 4,
.max_register = TEGRA210_MAX_REGISTER_ADDR,
- .cache_type = REGCACHE_FLAT_S,
+ .cache_type = REGCACHE_FLAT,
};
static const struct regmap_config tegra186_ahub_regmap_config = {
@@ -2085,7 +2085,7 @@ static const struct regmap_config tegra186_ahub_regmap_config = {
.val_bits = 32,
.reg_stride = 4,
.max_register = TEGRA186_MAX_REGISTER_ADDR,
- .cache_type = REGCACHE_FLAT_S,
+ .cache_type = REGCACHE_FLAT,
};
static const struct regmap_config tegra264_ahub_regmap_config = {
@@ -2094,7 +2094,7 @@ static const struct regmap_config tegra264_ahub_regmap_config = {
.reg_stride = 4,
.writeable_reg = tegra264_ahub_wr_reg,
.max_register = TEGRA264_MAX_REGISTER_ADDR,
- .cache_type = REGCACHE_FLAT_S,
+ .cache_type = REGCACHE_FLAT,
};
static const struct tegra_ahub_soc_data soc_data_tegra210 = {
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: tegra: Revert fix for uninitialized flat cache warning in tegra210_ahub
2025-12-17 13:25 [PATCH] ASoC: tegra: Revert fix for uninitialized flat cache warning in tegra210_ahub Sheetal .
@ 2025-12-17 13:40 ` Jon Hunter
0 siblings, 0 replies; 2+ messages in thread
From: Jon Hunter @ 2025-12-17 13:40 UTC (permalink / raw)
To: Sheetal ., linux-sound, Mark Brown
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Thierry Reding,
Charles Keepax, linux-tegra, linux-kernel
On 17/12/2025 13:25, Sheetal . wrote:
> From: sheetal <sheetal@nvidia.com>
>
> Commit 4d4021b0bbd1 ("ASoC: tegra: Fix uninitialized flat cache warning
> in tegra210_ahub") attempted to fix the uninitialized flat cache warning
> that is observed for the Tegra210 AHUB driver. However, the change broke
> various audio tests because an -EBUSY error is returned when accessing
> registers from cache before they are read from hardware. Revert this
> change for now, until a proper fix is available.
>
> Fixes: 4d4021b0bbd1 ("ASoC: tegra: Fix uninitialized flat cache warning in tegra210_ahub")
> Signed-off-by: sheetal <sheetal@nvidia.com>
> ---
> sound/soc/tegra/tegra210_ahub.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/tegra/tegra210_ahub.c b/sound/soc/tegra/tegra210_ahub.c
> index 261d9067d27b..e795907a3963 100644
> --- a/sound/soc/tegra/tegra210_ahub.c
> +++ b/sound/soc/tegra/tegra210_ahub.c
> @@ -2077,7 +2077,7 @@ static const struct regmap_config tegra210_ahub_regmap_config = {
> .val_bits = 32,
> .reg_stride = 4,
> .max_register = TEGRA210_MAX_REGISTER_ADDR,
> - .cache_type = REGCACHE_FLAT_S,
> + .cache_type = REGCACHE_FLAT,
> };
>
> static const struct regmap_config tegra186_ahub_regmap_config = {
> @@ -2085,7 +2085,7 @@ static const struct regmap_config tegra186_ahub_regmap_config = {
> .val_bits = 32,
> .reg_stride = 4,
> .max_register = TEGRA186_MAX_REGISTER_ADDR,
> - .cache_type = REGCACHE_FLAT_S,
> + .cache_type = REGCACHE_FLAT,
> };
>
> static const struct regmap_config tegra264_ahub_regmap_config = {
> @@ -2094,7 +2094,7 @@ static const struct regmap_config tegra264_ahub_regmap_config = {
> .reg_stride = 4,
> .writeable_reg = tegra264_ahub_wr_reg,
> .max_register = TEGRA264_MAX_REGISTER_ADDR,
> - .cache_type = REGCACHE_FLAT_S,
> + .cache_type = REGCACHE_FLAT,
> };
>
> static const struct tegra_ahub_soc_data soc_data_tegra210 = {
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Thanks!
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-17 13:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-17 13:25 [PATCH] ASoC: tegra: Revert fix for uninitialized flat cache warning in tegra210_ahub Sheetal .
2025-12-17 13:40 ` Jon Hunter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox